From patchwork Sun Apr 17 17:43:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 562826 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp1856573map; Sun, 17 Apr 2022 10:57:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9e9GoFHJMIimI6AXDHqIoNlYITArt1mY1mqXkFuiXv4Ka1W+DBQf3yui9fYH1nimD6NDC X-Received: by 2002:a05:620a:258e:b0:680:f33c:dbcd with SMTP id x14-20020a05620a258e00b00680f33cdbcdmr4840545qko.542.1650218236022; Sun, 17 Apr 2022 10:57:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650218236; cv=none; d=google.com; s=arc-20160816; b=tylCnCcIso9svqUTijRn3EtNgL8JZgLA9H8UOngVch1g3HPYcyZ+yw3+VZGSdM0YAc jnjpLSNuiex1Y30uNZzadAbNePF/z7dMr051BB4/g/T4w38xumistoV7vrpqQ7WwVbD3 WrYIC6yolmVyqvwM6LgTM5JPIFyaQQfVGUdA1Bkaa0kggE/k0kxpVbCzN0Tl9WrUxvkt WLa7IsUCO4JG2fzwB/I2Z8xmOh5t6WS7LOFD9a8B28q9FnIrEDp+sjcvyieFArPrstqY AvzQU2Kd0hPAZv3CA4dZalzSC5lW3fPJKQb+mm1aYHvAxOiwmZdecKeMpFqpnCI/CLKb BLUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=RxLRcUMRXZIX8VeQpjedlgnjJfO7UvkrNmgRZi4O4+0=; b=Q/XRNyXCxG1BuwNyZcTZf0+JGR5ICM0+tsHg1+llMaAw7uO/TsqGcHXXuwutaWP7lm Ut6dIoLg2k9ec2aR3UnxqkWoXH/jHhSbB2gnry+L5jHmOBCfd+8TpMGrVGGPlB7RlQLw xFKnWHtZysZswfDQTwp5oxb6BMg3wcYJC2u/8ZmHcZAZSU88OH3sQjmNT1zJ2PFUBYIj 5NtphzAi1jawvY7NrHpAzltmJYqSUjQ5jTsJGzvKLjzvWLAL7D12r+YLS3kb0+giK5zv RzDbyA6xMP419ten/JHtajL0qtvXp/9rrgK1mrvExN3EqKUv5+kgFb2k8PGLORIq9j96 kjKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KdLM8h1J; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x25-20020ac87a99000000b002e22bbe9f4esi2242615qtr.158.2022.04.17.10.57.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Apr 2022 10:57:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KdLM8h1J; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ng999-0007C5-KH for patch@linaro.org; Sun, 17 Apr 2022 13:57:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ng8wy-0000fU-Qj for qemu-devel@nongnu.org; Sun, 17 Apr 2022 13:44:41 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:44583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ng8wv-0003H9-Sl for qemu-devel@nongnu.org; Sun, 17 Apr 2022 13:44:40 -0400 Received: by mail-pg1-x530.google.com with SMTP id j71so1443664pge.11 for ; Sun, 17 Apr 2022 10:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RxLRcUMRXZIX8VeQpjedlgnjJfO7UvkrNmgRZi4O4+0=; b=KdLM8h1JGtzeZuX9glkjRthvPMUmMwW7CNEQ/sKHmk5U8L+Lptw5Cj5sJvm/W0qu6Y 1aQIDVX487Smbz7Tqsw/pP7DR4DmpUh4cvKjVuXnB9TWKHf3iQnK65l14jjz4yljw59B RF1ySx5Gb3CLSsWlepjHm0JeiezwKG7brMkVw1TuawQMvI2GoqEOm4pJKLpjuCbnGbg9 hXHKQNxfxSAJgr7AjVn1jMncJK1hFKLIMktb4ZtuIPfppky6hwDFivDupaEglnz44f5c RXCYzPzhN+brwePv6ln/I1dLX/8Fn4LEGJ4GWODZ/PTOvHHvhX0bZA7k0Zcfb0b6yT18 35TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RxLRcUMRXZIX8VeQpjedlgnjJfO7UvkrNmgRZi4O4+0=; b=4oZ9pkXMJjlehQ1HTsbVckC6mdrZr0tx86zmKQPsIdCVHGWhpRpv5PIg0Ko7SoTwbM ++axaJ+cfnU+b7nCz+oPI247pit2muvb4U1m104puFyzZNiZTqw4ORQ/Rjg4xFOBnNJl clDW61TsbooUfvm5orhM/dFmAYx1WZhCOt6u4R13RMUpSULjefaywgdeDStDYkA5NKG0 XdqLt2AariWWj0FioeLaGKBc6bHyZKCa1eITIlVxkAC/BGakivKxcarrGQlQFt0s/3Hh t4LGjsDqf0HW3ybRfho5PQPgmwYHkwnk+MaM8aCAHbMSenX2y4MO6Bos38GXW6YRxQ86 FCxQ== X-Gm-Message-State: AOAM5320eNbb5p7KjtXXWpe5riVbabuN7XtuTSr6TTmbT8AmziUV7My0 IHedV/5tPMuDfHQgHL6P6bgfrmsGrt7IAg== X-Received: by 2002:aa7:920b:0:b0:505:66a5:3029 with SMTP id 11-20020aa7920b000000b0050566a53029mr8313795pfo.40.1650217476615; Sun, 17 Apr 2022 10:44:36 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id i2-20020a17090a138200b001cb6512b579sm10372119pja.44.2022.04.17.10.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Apr 2022 10:44:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 08/60] target/arm: Change DisasContext.thumb to bool Date: Sun, 17 Apr 2022 10:43:34 -0700 Message-Id: <20220417174426.711829-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220417174426.711829-1-richard.henderson@linaro.org> References: <20220417174426.711829-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Bool is a more appropriate type for this value. Move the member down in the struct to keep the bool type members together and remove a hole. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Alex Bennée --- target/arm/translate.h | 2 +- target/arm/translate-a64.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate.h b/target/arm/translate.h index 8b7dd1a4c0..050d80f6f9 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -30,7 +30,6 @@ typedef struct DisasContext { bool eci_handled; /* TCG op to rewind to if this turns out to be an invalid ECI state */ TCGOp *insn_eci_rewind; - int thumb; int sctlr_b; MemOp be_data; #if !defined(CONFIG_USER_ONLY) @@ -65,6 +64,7 @@ typedef struct DisasContext { GHashTable *cp_regs; uint64_t features; /* CPU features bits */ bool aarch64; + bool thumb; /* Because unallocated encodings generate different exception syndrome * information from traps due to FP being disabled, we can't do a single * "is fp access disabled" check at a high level in the decode tree. diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 4dad23db48..be7283b966 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -14670,7 +14670,7 @@ static void aarch64_tr_init_disas_context(DisasContextBase *dcbase, */ dc->secure_routed_to_el3 = arm_feature(env, ARM_FEATURE_EL3) && !arm_el_is_aa64(env, 3); - dc->thumb = 0; + dc->thumb = false; dc->sctlr_b = 0; dc->be_data = EX_TBFLAG_ANY(tb_flags, BE_DATA) ? MO_BE : MO_LE; dc->condexec_mask = 0;