From patchwork Fri Apr 1 19:02:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 555582 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1248:0:0:0:0 with SMTP id z8csp1809264mag; Fri, 1 Apr 2022 12:03:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeDMIReL+TyrNMfRGsu88RWNhAACFwJ1ZCrW4QajKa77wSy9pxGH9XrMGt2FC2C3/reli+ X-Received: by 2002:a05:690c:81:b0:2e6:d4de:e04b with SMTP id be1-20020a05690c008100b002e6d4dee04bmr12559956ywb.303.1648839826873; Fri, 01 Apr 2022 12:03:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648839826; cv=none; d=google.com; s=arc-20160816; b=0pRKmyBR2CT69JnBtgOIAM2ZI14927gpdth9RdvKx/AF/zpXJvvs23XvZ4xco67+84 Qsid7EUJCWQoCir7iyBz9XbMpRVPEcpSZ5AQOj9eUQ1I1hbl4UoSzm6c5Qg6PdXUqf4A VPaNMDjpKPhw2E79FiSDnCrXk4Wdufh3zLTKXPd8w2ZaIafoF5DnaCoo1GeCa+OO7gHO QQ/ajIINtI15p2FuDl6Klml+/7OVzpmvC3aawZ8+te2szmkObDEZ4gCv9/a/ekN6EP3F naOccu3SgvBGZoGUEdkx8a9ig+763Y1GnLZh5GhscrN7pBwz4uB4lQnRjmTS/aGxOh2W NQSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=Qas/d64QhQzK6/1Vbuwj4Rdt35DYGLG/DMoXYM3wotY=; b=CucFOijCaBZjPPSnIPSjAYWvgGOxixL673JPQv3uIf1/nKsC8y35ouwB6uG6Wr1r+e rZdm34xtF+LOEPGhMbgPAFEpV1ix5tLfGA2FHo5vnwhDW09BN3R323J/IUWgVjxPEDKG SkjLLFX75RUbGEYljbQOghs/xfsFRKB+7hufJ7jEaqLdFv1ZAnq+yjNJyM+A37S3dz/f YUJQuEqMVFc/eqsgD0mDL6sL9k1t089iMy8jugzZiPUBK+c99L7MyVFMZ3JouFxky1dj fIh+5uTZvrRxNEcDbUl7phVyEnNqsuogYmhTaEV587X8M/DeAH3/P1aGosqDNYwicZ77 hWOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SCum9YOC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e7-20020a818b47000000b002e5bb9dcacfsi2880530ywk.344.2022.04.01.12.03.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Apr 2022 12:03:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SCum9YOC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naMYk-0002oy-Br for patch@linaro.org; Fri, 01 Apr 2022 15:03:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naMXk-0002oa-2y for qemu-devel@nongnu.org; Fri, 01 Apr 2022 15:02:44 -0400 Received: from [2a00:1450:4864:20::635] (port=35504 helo=mail-ej1-x635.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naMXi-0000Ut-Lo for qemu-devel@nongnu.org; Fri, 01 Apr 2022 15:02:43 -0400 Received: by mail-ej1-x635.google.com with SMTP id yy13so7787055ejb.2 for ; Fri, 01 Apr 2022 12:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qas/d64QhQzK6/1Vbuwj4Rdt35DYGLG/DMoXYM3wotY=; b=SCum9YOCkz/T2EO0XIxsGsuhnjGzSRBd0KhgUUFv9U0WAMvUN5BvlRWdJpoVUVKJl0 TpLpIS3EDryT4fpvTztpodkQsT/pGXXpvlMsp4VCCfmNlC3PcCDfFx3MfKIqCYEsDIVj dv7bXp7TWz6PT4NxVI9Uh4f04XpmXI+RAz3Y5LJXrSCt/Dqb3wHYzSIhCZIm/2bMVZnP 99SOBWkUg55j+bcuznMUj7G9DFeFgOsj28THIQK2Iib9x1Yzxyz+eu/LyodySYs/oFEW BXXgPS/dut5ibu/OqtKGx879wjFQO6fz9oxsMUBlef4CXG3xwjpQ862YTOJckk+Maasi JW5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qas/d64QhQzK6/1Vbuwj4Rdt35DYGLG/DMoXYM3wotY=; b=08poIfoAs670AoxWQTLVyoYD8JN7NtgWbgcn23fTDZ8ijW7K1fE3x77bmlGkWCYtio ojPIukBKK5+2D9p4T5uggeYaP4+mG7H5XmI9PN8nfbgrk2Yl5A0tSPNUooHVt24M0JWu AqK+TSd6rXqAIiJprkODplQUEaN+vEGLHzdI8bO8ayLV5CD+H9puSJ85CpiRjY9Ci1S7 Vq/X2Aadu8G5FROHF4bsTOHbTi3e+ZWRcbZtsgA1TAw0lsMVLE4qxzsRnj9/gLt5gmUj cMpcZOpA2CklkT3RJSeOyjZ6fNGt74kbD0ouB7QiP89nP8pZlk5LSdoPz3qKOXy6Vnis UfcQ== X-Gm-Message-State: AOAM533KELRWVEhfzsSXZt8EmwZO00BgcgGgxUoMoanzZxTCWWpkSy9W 79bt0gQdnvAX8wsrC7zhL9nqh9FfAAORmODsgLQ= X-Received: by 2002:a17:907:97cc:b0:6df:83bc:314c with SMTP id js12-20020a17090797cc00b006df83bc314cmr1037885ejc.587.1648839761140; Fri, 01 Apr 2022 12:02:41 -0700 (PDT) Received: from localhost.localdomain ([185.81.138.17]) by smtp.gmail.com with ESMTPSA id p12-20020a17090635cc00b006e055c9c91esm1264231ejb.101.2022.04.01.12.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 12:02:40 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr Date: Fri, 1 Apr 2022 13:02:33 -0600 Message-Id: <20220401190233.329360-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::635 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx. Fixes: Coverity CID 1487201 Signed-off-by: Richard Henderson Reviewed-by: Damien Hedde --- plugins/api.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/api.c b/plugins/api.c index 7bf71b189d..2078b16edb 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -289,6 +289,8 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info, enum qemu_plugin_mem_rw rw = get_plugin_meminfo_rw(info); hwaddr_info.is_store = (rw & QEMU_PLUGIN_MEM_W) != 0; + assert(mmu_idx < NB_MMU_MODES); + if (!tlb_plugin_lookup(cpu, vaddr, mmu_idx, hwaddr_info.is_store, &hwaddr_info)) { error_report("invalid use of qemu_plugin_get_hwaddr");