From patchwork Sat Mar 26 13:24:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 554350 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1248:0:0:0:0 with SMTP id z8csp6425831mag; Sat, 26 Mar 2022 06:32:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwq937Xc/NKE3SjmJO9ugGTNWWa1r/vdeoGL4ZKLcbZhDdIhUu4Pn/jnQOW4Zg8WtuXAlgC X-Received: by 2002:a05:6214:c63:b0:441:2263:56c1 with SMTP id t3-20020a0562140c6300b00441226356c1mr12993507qvj.131.1648301557242; Sat, 26 Mar 2022 06:32:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648301557; cv=none; d=google.com; s=arc-20160816; b=HRXximGroR4XPftfXCgUjxtZj5M6YLt7P1sJwglo0ILKpajhOa556s2xqaMoaUTccL zclluNQsj+5aqQDCs746dDfvYBY5fX/OhMf1n+1/l2ZRlDHSUjmR3RbtNwhqCWI2MrDE SfCmktWdzXstrcrTCYus/PeV58Bt909ViMaQSu5bbbCu6QmiPaMQUQIW6ZNdPT4QFFr9 NaMTZLomn2BKqPKR+JDriEz/AGziO2snJuOYW+xXJcwgYMbFFejxJ0eGJQvS65fPRted 86MMLX0U2ycHn4b2Hbsm/z+Q27hM20vNEeR90144FI0eopoyuBZOTRt2DMcKs5O55jkY EB7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=RUBe0C4iT5t4/OHe4DJ+hJf3HvDnr2dd4byJPft2OJg=; b=DlfaFDgSlPSJBm/g4zKHrk1JKg88RA0YWBXUgqXA65JXtrHuqc2XCiurjHAnt3rt/w gABI26JcUaonjSCIPIeOOIC8As77k+35DEwrNmXb6uMr/CHmztjLbj+17hN7qrDOZPKx eWAQQMWTKaHrB0IIVzQKc3F0fS0itUyHF4cdJiD5HZwzdhDiJ8QnGDyv3CwlDJNG/reL f9vVV59u+fjdfYY39JKcvdzMN5jkyKGaTaij04T1WvLSMAj9g0zV1Ph1UnDVl0MLXas+ ZPH+kQwtjhklSsdPO23+UHLzp5VXwTN3AzjQwI8iu93G/W4au4NWVlNTNyj62x8k96+U vvEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="SS7zup/S"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i12-20020ac8764c000000b002e1fbf3c0ddsi2929372qtr.718.2022.03.26.06.32.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Mar 2022 06:32:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="SS7zup/S"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nY6Wy-0004YW-SW for patch@linaro.org; Sat, 26 Mar 2022 09:32:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY6QM-0006k0-Ue for qemu-devel@nongnu.org; Sat, 26 Mar 2022 09:25:46 -0400 Received: from [2001:4860:4864:20::2b] (port=45849 helo=mail-oa1-x2b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nY6QL-0005Kb-EB for qemu-devel@nongnu.org; Sat, 26 Mar 2022 09:25:46 -0400 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-d6ca46da48so10698454fac.12 for ; Sat, 26 Mar 2022 06:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RUBe0C4iT5t4/OHe4DJ+hJf3HvDnr2dd4byJPft2OJg=; b=SS7zup/SZrIrLiMXZnwvbwZjRdq7LBu/EkobD595kZy9Z7pP/vxiFBZAIFnAKh4WWk pc2xu6WI2Pz1CufeZG9pgKJzAMeQ8P/waZu4NjbmSESFvQbTm8BoWgCKh08tESN8V/a5 B6rJjEPPS+sOXF0If5xMGV0vfZzsAMEadC9bVTMNjKEt855Ht/xdEeZ2Bn1IVoqnMHVh bZ447rWDcMuuAG5wt91pH6v3To4ridHOYE6HIeWiVN+3WcjwKT0PbtRdq/QCzVDnMJgA NKuvG5lfjgMrdQes3I6njT01abWH8FP18TplyObdAflPOI6gc2oQtm3JKN1eBYFGqW5Z KSQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RUBe0C4iT5t4/OHe4DJ+hJf3HvDnr2dd4byJPft2OJg=; b=RFS4Q6za2wzjqzFnjPRKIDjD4nPOn/L/SIBnbw40b5su5qaKF8Z6F4JCYEPIPQLdZW cv0WA8t5U1HIc4CBdjFnR9zqoi3cRLW21dejjTYw70ZAOM2KHo3dWI/9Irlq2sx2UKJv TI3cGseHjWCf5AMPXwN9TMJyqr+M2NhZIuTi8u1pjgirCOBBUNATC+/BfoCzq3FrKVO+ VwHUamGeeRsRGln4+m6zvs+UWWecuiGXn0MrGMxnF0s7yomQ3BRy57vtCuw+jo7KP7Cr Ll2/YlInHCIxhDJKsEYQODy3TZsfj88SmliDoRl9Rg9yWGPXzfWQF2t40ACl3nxr7T8X r3mw== X-Gm-Message-State: AOAM53023uo6tsV1BXsntOjBZsWffyiUYyCenwYYqGEG1171ADN4Ns92 9lRPz2PQOHtEZ38wfu6TI1TQJdqbtR9Al2AP X-Received: by 2002:a05:6870:14d6:b0:dd:9907:2c4c with SMTP id l22-20020a05687014d600b000dd99072c4cmr7200126oab.70.1648301143026; Sat, 26 Mar 2022 06:25:43 -0700 (PDT) Received: from localhost.localdomain (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id n62-20020acaef41000000b002ef646e6690sm4610331oih.53.2022.03.26.06.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 06:25:42 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 02/39] target/hexagon: Remove qemu_set_log in hexagon_translate_init Date: Sat, 26 Mar 2022 07:24:51 -0600 Message-Id: <20220326132534.543738-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220326132534.543738-1-richard.henderson@linaro.org> References: <20220326132534.543738-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4860:4864:20::2b (failed) Received-SPF: pass client-ip=2001:4860:4864:20::2b; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x2b.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This code appears to be trying to make sure there is a logfile. But that's already true -- the logfile will either be set by -D, or will be stderr. In either case, not appropriate here. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/hexagon/translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index b6f541ecb2..98f1452cad 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -874,12 +874,6 @@ void hexagon_translate_init(void) opcode_init(); - if (HEX_DEBUG) { - if (!qemu_logfile) { - qemu_set_log(qemu_loglevel); - } - } - for (i = 0; i < TOTAL_PER_THREAD_REGS; i++) { hex_gpr[i] = tcg_global_mem_new(cpu_env, offsetof(CPUHexagonState, gpr[i]),