From patchwork Fri Mar 25 19:52:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 554039 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1248:0:0:0:0 with SMTP id z8csp5788797mag; Fri, 25 Mar 2022 12:54:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzD1MhSssXwetFc+tHZqPy76lXsLXplIBdrGpw7NNUlqZocxdATMJhZPPsj8HL99kSr3H5T X-Received: by 2002:a0d:d143:0:b0:2db:dfa5:e376 with SMTP id t64-20020a0dd143000000b002dbdfa5e376mr13156733ywd.218.1648238070550; Fri, 25 Mar 2022 12:54:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648238070; cv=none; d=google.com; s=arc-20160816; b=QQq1eZCahFsqzjWhr1dOZTvBsECaLl1PbRYHptWy0nvADLSrlr0+RmkMT4IYIkSfza 0ZbYGmlDlDo0H2daDKBSQUw2g2ckZafUhPT05Gmd6HI2rcVQEH7R65UMeod0r6j9pTQr T4Ulj+9wwukAdKJ0IKIsxwAL9HRsFLpFgncOHxpqIfZsuF4CAOaAkiyrSb9y+eUXrNF+ J9zvKJ0m0b5bYkSMfBTP5PBgMy6OmP62Xtoi/H00a/1rw9rkEsXwzj4w14QQrGwZQR2y A5NfyX9gmK7mZ61+/NzqPTn5nSBxGU8wWmqlLVbvEv0qHfQiB1//njUoWeix2WK7xkYL 9qrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=26hq51RiROI5XzJelEXkN2uWQhOSPbaaTZ3h8qaX6EQ=; b=S0ajDVbPwTdiGQpCKxRz2m6SjUA6bu/viQNPuyMBWbSaJX1+nxrG0b7H4eXSCzRkNp BcuUTWMxHd3Q7qZT2XKCedyWj2TORHX5HER/JCOCai8s6VzNLAZDHpnw2LdMiCIsnxVG L5nBfU/O4KY3D8lYfORoc++mI6ZfoP+WF2KEyHcvtvjWGOLqDdMjmRXtAJKD831/i0F1 VZow4CJhWo7uK1cRKjoILAbBj6GUB7vvDwkNQ11wPvoMuRu/90BnvHcoo5wCDwXt04O/ kXIzNLLSVS5Q6zsia6U49vVtAWaVKWPOwGNgoarLJYUvHf1nMypVhOK6v/IoP+T9ey8K UXUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=L5xudmR0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 83-20020a250156000000b006371ee363e0si3793101ybb.517.2022.03.25.12.54.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Mar 2022 12:54:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=L5xudmR0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:43706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXq10-00029s-2o for patch@linaro.org; Fri, 25 Mar 2022 15:54:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXpza-0001uC-DC for qemu-devel@nongnu.org; Fri, 25 Mar 2022 15:53:03 -0400 Received: from [2001:4860:4864:20::29] (port=43468 helo=mail-oa1-x29.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nXpzX-0008O7-Mv for qemu-devel@nongnu.org; Fri, 25 Mar 2022 15:53:00 -0400 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-de2cb87f6aso9098566fac.10 for ; Fri, 25 Mar 2022 12:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=26hq51RiROI5XzJelEXkN2uWQhOSPbaaTZ3h8qaX6EQ=; b=L5xudmR0FjiOaJa4wSjP1tapPrafWWRJ2Y/zLdRsOXhmGPcVVwM3e6WIET4ruMNHZa YmICMkImo2tEY1ljbyndyuvr4DmmxZ++CRsS2hHklm9yKO1J0exPDwt2jSGEoTld2VT+ cCtDyPsceKdROUX5BVSL98PJVvC6dPuHbUHw63XWQmAIJms7MhgLAse5FU/5kpT6FXDd bmVOXSrZSRRkKRyvhpyVfZ3PGh1d2rsoLpitGaRTS4xHLaBLx2vbssqQHs5A9oF52SAE TdYfQF24VngwVHhLDs1g/Oa03eTdn4q0eLrE7iJMcbMo7B2hhsgfLkGh9VRtYvn9bSPx 7WKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=26hq51RiROI5XzJelEXkN2uWQhOSPbaaTZ3h8qaX6EQ=; b=z4uvNITgXCUlTKvJ7iwdfdF9nGSJV+iAExKKwcaUzIA9XFaYH4obSU8aMogecOUqTS dQx+KjhpIdwELMc/9P8JXoJXqdqlytNh+87LeelT8Veom40OfgCQz+HwexH74mcY7ubG riw/OWpYWGhaFdCgWJmCAHEmTjrtbZLGShoAMdLgBUCZAY0nwC5Blh46r0dRha1rfKTu +bHpphSj+iVfgLu9HYI26o4fixlbPe1AikWBnAsLT8fdptcmlj91KTtfTSSvpInDrAaQ w4DTqCVodA6dh0BYD59vHkRJn+twT0UmzskNYvfS2fd+mtylJ50jO7Mw+SJf/fco5Gs4 svIA== X-Gm-Message-State: AOAM533iYdQ4K6LJn79XiZqgC1VUzLPO4238BTjzNUVSYYeX40b45ZbI exObyup2kJiuxqGgJp40FhI63/vlGEQUmuYrHv4= X-Received: by 2002:a05:6870:5a7:b0:d9:b303:38b with SMTP id m39-20020a05687005a700b000d9b303038bmr9805589oap.1.1648237977749; Fri, 25 Mar 2022 12:52:57 -0700 (PDT) Received: from localhost.localdomain (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id ep36-20020a056870a9a400b000de98fe4869sm2153730oab.35.2022.03.25.12.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 12:52:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 4/8] linux-user/nios2: Adjust error return Date: Fri, 25 Mar 2022 13:52:46 -0600 Message-Id: <20220325195250.386071-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220325195250.386071-1-richard.henderson@linaro.org> References: <20220325195250.386071-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4860:4864:20::29 (failed) Received-SPF: pass client-ip=2001:4860:4864:20::29; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x29.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Follow the kernel assembly, which considers all negative return values to be errors. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- linux-user/nios2/cpu_loop.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index a285781fc5..969460df58 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -55,9 +55,14 @@ void cpu_loop(CPUNios2State *env) env->regs[7], env->regs[8], env->regs[9], 0, 0); + /* + * See the code after translate_rc_and_ret: all negative + * values are errors (aided by userspace restricted to 2G), + * errno is returned positive in r2, and error indication + * is a boolean in r7. + */ env->regs[2] = abs(ret); - /* Return value is 0..4096 */ - env->regs[7] = ret > 0xfffff000u; + env->regs[7] = ret < 0; break; case 1: