From patchwork Sun Mar 20 17:11:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 553179 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1248:0:0:0:0 with SMTP id z8csp874219mag; Sun, 20 Mar 2022 10:14:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymfVjJuRQLPtxX6dphLmTL5A5KxED6MrwR4xzUDgJ/eB3JzqMsw3z3x+8+7tKCdIfFh0bv X-Received: by 2002:a05:620a:13ab:b0:67d:4094:ba1f with SMTP id m11-20020a05620a13ab00b0067d4094ba1fmr10798606qki.567.1647796452852; Sun, 20 Mar 2022 10:14:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647796452; cv=none; d=google.com; s=arc-20160816; b=SRCjvhFkKlC98jLW/Mgv+Qig++E7FWi6E23O733uEp18M3gfb8ih50aM4U/9kgFLOv QgMH4lyC62TBoQ88WlGmk0CouJEFjTvBCqi9OCbZXz4GvJe+XworcaTwm3WQYyQ2EeL2 ZYk9DMbfQ+LvhSSrEkoeVINulU+PhKXANnQ/pdHnQGofQY5pNbaLMtf6TTlcHYNk20j2 dhA2edwPIohmmiWlaS3AynusimX/DEtiqPI7QsDO3x3rEIfshXWy7fhWgDqy/f336O/F 0xnBhFQCW0tseGzknVqHUfRvTV4q4Y+KsMonxhbV3ya8VUC9rfOQfl2EFgqZDHbY1SwG /WYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=45VpLy6jFhpJxRzAu/NUCd+ixVE/bvEmVYHxJFdcwEI=; b=G7d50W5O5mw8rD7mykrHh2T2va5E4VTMD3wqyHXi3vuAoW3tN4viOGybEPJtKBM9g1 wTpaZqyYuPSZbQ8hwBBnpcZ4EpK4Uu7r3EjjG3Bn+pIUS3CUit7oWcY5f0HD4jYHrUJ1 ffwEmI0PIx6vKf4vFILUwWoLC5Y85qVkcrBp/iBzq3UOzT09kQXRcbBP5ggxlrqdPY1b SkuVUVrxQCreMo+TUNluSzAdnHUO2kENgQkJFLRaP1KaJl32I2BVHdpvBprsqrPt/gbs TwnCzA0vUyS+tIU51b4GuVQ1zcgjFeCiO2vQ/kK6Z+dJRrMoFVdiVeEU5M7HWKhTmbYl TfvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="AqI/QYvs"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 11-20020a0562140d4b00b00440e46a7c18si1351741qvr.182.2022.03.20.10.14.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Mar 2022 10:14:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="AqI/QYvs"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:53912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVz88-00007e-Ea for patch@linaro.org; Sun, 20 Mar 2022 13:14:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVz5s-0008Qv-Nx for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:53 -0400 Received: from [2607:f8b0:4864:20::632] (port=38695 helo=mail-pl1-x632.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVz5r-0003SE-AV for qemu-devel@nongnu.org; Sun, 20 Mar 2022 13:11:52 -0400 Received: by mail-pl1-x632.google.com with SMTP id n18so10885288plg.5 for ; Sun, 20 Mar 2022 10:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=45VpLy6jFhpJxRzAu/NUCd+ixVE/bvEmVYHxJFdcwEI=; b=AqI/QYvs1iFbSj6GhvU6rcWDKefh9916SfT7qzjRMFTUTGqmxe+lcZX+B6W1+8Mtn5 5IdZhMVGEcLTLG2SHg2SxIubRoJ+cE3/LJ1qG69zl9hy2YBVTpru9fEU9+L2Xqt2kOfk Ut0NiYTvjgZHILqj9QmB1vqwdg8g9X1/KnjQNEFNmABz9JhYJoiCsJQFHRFw5nWWNw64 smcvfzZ9uT1k1WFEtyJLBXAMcJCj0nPL8OMjk5VITNRtVGCQC0y0gOYnoJcG192lhRQm VnDGfg0QhaaVlRUrDLVjRdX5L1KzrQbLVD8hnuBaFy6F+aXcon2x2zEKfOGLu1l5+0Ix HEJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=45VpLy6jFhpJxRzAu/NUCd+ixVE/bvEmVYHxJFdcwEI=; b=nbOopZ5GUk773eUvoQJvBejEhw1Ymrqhj9frvV3A9BJ9ZRVoIyP0z8iddlz2oYX67C xchxDxnuLQBksk26uD04RNWwtPDH/ino00U5P/RWiC2D7KYyChX++IrjFlqKpsVwAjDo lMy0qjY0DfDVwkdz7V00arY7vSthKRE5itHqq+NFeq5itjphVzGikDanEuDJzMI0xo7T GxfCdzJYDb04wK2kY2VeXleGYiBcZxAvrH0UEWILL3aJwvQUNYi8GDci0Ud6T4Vlp1MB SxlD55+ZV2y4Cgt2BMcDJaFVAvaBieQQfgTxQP+Cy9nFiXpMaeSyw14XnnE+gXV2YT1m EBBg== X-Gm-Message-State: AOAM531FHpka/AAAXqushbyWLmGqVa6/bJMztJ2/bf50+3duoD0LuDoK jiq1vOezIKQlJG3LzFh4f5KUEp1K7+UASA== X-Received: by 2002:a17:902:ab10:b0:153:b520:dbbe with SMTP id ik16-20020a170902ab1000b00153b520dbbemr9314935plb.55.1647796308606; Sun, 20 Mar 2022 10:11:48 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id q12-20020a17090aa00c00b001bc6f1baaaesm17149697pjp.39.2022.03.20.10.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 10:11:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-7.1 13/36] accel/tcg: Use cpu_dump_state between qemu_log_lock/unlock Date: Sun, 20 Mar 2022 10:11:12 -0700 Message-Id: <20220320171135.2704502-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220320171135.2704502-1-richard.henderson@linaro.org> References: <20220320171135.2704502-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::632 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Inside log_cpu_state, we perform qemu_log_lock/unlock, which need not be done if we have already performed the lock beforehand. Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 7bc489101f..8b7d6ae9b9 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -225,7 +225,7 @@ static inline void log_cpu_exec(target_ulong pc, CPUState *cpu, #if defined(TARGET_I386) flags |= CPU_DUMP_CCOP; #endif - log_cpu_state(cpu, flags); + cpu_dump_state(cpu, logfile, flags); qemu_log_unlock(logfile); } }