From patchwork Thu Mar 17 05:05:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 552240 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6713:0:0:0:0 with SMTP id u19csp886610mag; Wed, 16 Mar 2022 22:37:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM/YCW/xYHDUqJin9PNYKQiyU+FTRhBf0cRhBk80cuR3l6aat//1V9YkrG4xtN+0cwo7W9 X-Received: by 2002:a05:620a:783:b0:67d:4c9d:d103 with SMTP id 3-20020a05620a078300b0067d4c9dd103mr1828471qka.250.1647495433327; Wed, 16 Mar 2022 22:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647495433; cv=none; d=google.com; s=arc-20160816; b=TWVp0g6eip8vaAr7mRCaqJJbcn2n2ptGQlMNXih6qsuzc9bFDUUGCOMxA5thTVyKzc EUEmYbL45tee00wf2u1UxbhlfSNwDqF4ZmSd+qWkEMQJOsRA4fJGb3ffSD45CI1l2tB3 wYObH+aJkw7NH7rNJrfmkzZWc4RH9Nt8Yzjg3Fdw5Yu0lQ6TtF2Y2CTsNA/FIT2myCzQ H3S+ZcGuGd8ABL3l5D/9CTT/spY+19mtagf/3Jzsu83uNUG6cxyQpGGm00d5W+GKuRsP S+1dLP1VULWSnAbxPNyTipWlcF2iz8a/4WOdG46+1BAI1Ko7Ca06yXvmKaLIDmfFG1np 9/vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=PHMXz9q73HVjYaAorTgnEhJkrDs42cYUdRyVosZEm/k=; b=Aozy7To7Iw73OBHzGrAmO56STz9jxJNYS4WAkNebSd3spZtFdSPz0NeyJSFTZwHc3D cRssdp8n5tDU8x1t3eyhwryCPVKlAnzNuO44bHmy+4qNA2xgjMU2jDJ6yDloUOONdNy0 tgxNCwRYJwgSbkmQbsDNqtL/Tz525fOcKJ6fNI9RbGrCNdkQtwMoYNnrrmwLv8uRD1qh gIIXOHNgKQYxrCneyUPqzNM5gocfYIREi/sFSOqayzFMN7nq93WUjW+r+b4b8EB4PhUU QoPUkRHznmudplaVqfq5/9Pv9yFPIV4TL1tG6X4qs+Ue0PbJvv90u1hZye38k+qGU7Iy 6LLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=yjy7i+vQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e27-20020ac8011b000000b002e0636b9f52si969851qtg.96.2022.03.16.22.37.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Mar 2022 22:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=yjy7i+vQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUioy-0001wn-Sc for patch@linaro.org; Thu, 17 Mar 2022 01:37:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUiL6-0001WI-1a for qemu-devel@nongnu.org; Thu, 17 Mar 2022 01:06:22 -0400 Received: from [2607:f8b0:4864:20::52f] (port=33679 helo=mail-pg1-x52f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUiL4-0002JN-83 for qemu-devel@nongnu.org; Thu, 17 Mar 2022 01:06:19 -0400 Received: by mail-pg1-x52f.google.com with SMTP id 6so1808572pgg.0 for ; Wed, 16 Mar 2022 22:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PHMXz9q73HVjYaAorTgnEhJkrDs42cYUdRyVosZEm/k=; b=yjy7i+vQ8GsJrWz2poT5tUCmVCvrCQGgO/wBKjVJAObrT8qik4qGaoRHYHXiO3U1Wm rp4XtjxX+uAP3An+qV/uuUK8k9rWBy7oCwEIFZdhn9iz+p79otZvwrwsBx/TjiY3vEzh qWnQZOlP+CMCPegFky7gYKMxBXVTfZo1Nqokg9LZumtC1+19a0I6FVdjM8OfO1BjMpFl pv+VL7/6xKnmQjWRacIDTs4HPPcJWdCZeFADIcVAk8aIPdpCsLaXK0wK7mzpiYDj69tq k+1FaGAb9WkjmJuvPbpj7xaSekLh8ciokRZ+EWBTdC4xDJwrWOj6fKTGbvrll0rLUOZ6 80cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PHMXz9q73HVjYaAorTgnEhJkrDs42cYUdRyVosZEm/k=; b=CqvSj78auT6stqlOLcAA8xde3rsgCRummsdj9P0QSg1nFbmHVASSaOdqIbn7Q2pi+D fUpd58o8pvzxG5PM08DFvcbrZi4FLglyHIWxEmU3RD/vpS1IUp9xCVejQ5TYmdRs+2vz 0p1BGlWBxnZ2QSf/LQcA0s0XxBkjp920sxxILeWveGqz4cP/cTIBDVI0/XJGRyg9lJR2 hMKZDmftcGNexhOa2z+VyZQJLUAxY4CtjhW/npaLbOhjJru1QG0o53vYTyuWWlh34v1g F2AsJ4S/uUcZk4F0+L3ydl3jdG0xasWrqP1bGYjIslNABceED5JoBsQhChLUMO/EfoNz iRLg== X-Gm-Message-State: AOAM530zwu3cs7HCowJvWoTWE0w1fh+y6jsSErzddQAnWjtzwoL8Dg9K g53QfmpL7w+GXjVFzRf7YD8nWarNSFHkuQ== X-Received: by 2002:a63:185c:0:b0:381:10:2843 with SMTP id 28-20020a63185c000000b0038100102843mr2227144pgy.433.1647493574811; Wed, 16 Mar 2022 22:06:14 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id h22-20020a056a001a5600b004f7c17b291asm5101357pfv.87.2022.03.16.22.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 22:06:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH for-7.1 v6 36/51] target/nios2: Hoist set of is_jmp into gen_goto_tb Date: Wed, 16 Mar 2022 22:05:23 -0700 Message-Id: <20220317050538.924111-37-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220317050538.924111-1-richard.henderson@linaro.org> References: <20220317050538.924111-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52f (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52f.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marex@denx.de, amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Rather than force all callers to set this, do it within the subroutine. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/nios2/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index f61ba92052..51907586ab 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -165,6 +165,7 @@ static void gen_goto_tb(DisasContext *dc, int n, uint32_t dest) tcg_gen_movi_tl(cpu_pc, dest); tcg_gen_exit_tb(NULL, 0); } + dc->base.is_jmp = DISAS_NORETURN; } static void gen_jumpr(DisasContext *dc, int regno, bool is_call) @@ -208,7 +209,6 @@ static void jmpi(DisasContext *dc, uint32_t code, uint32_t flags) { J_TYPE(instr, code); gen_goto_tb(dc, 0, (dc->pc & 0xF0000000) | (instr.imm26 << 2)); - dc->base.is_jmp = DISAS_NORETURN; } static void call(DisasContext *dc, uint32_t code, uint32_t flags) @@ -251,7 +251,6 @@ static void br(DisasContext *dc, uint32_t code, uint32_t flags) I_TYPE(instr, code); gen_goto_tb(dc, 0, dc->base.pc_next + (instr.imm16.s & -4)); - dc->base.is_jmp = DISAS_NORETURN; } static void gen_bxx(DisasContext *dc, uint32_t code, uint32_t flags) @@ -263,7 +262,6 @@ static void gen_bxx(DisasContext *dc, uint32_t code, uint32_t flags) gen_goto_tb(dc, 0, dc->base.pc_next); gen_set_label(l1); gen_goto_tb(dc, 1, dc->base.pc_next + (instr.imm16.s & -4)); - dc->base.is_jmp = DISAS_NORETURN; } /* Comparison instructions */