From patchwork Wed Mar 16 05:58:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 551817 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6713:0:0:0:0 with SMTP id u19csp1208mag; Tue, 15 Mar 2022 22:59:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRFDnbmt+aZOp9YRrtvlIsF1K2Z+S0JLxyVUtIBQjZ4kYcJ9N6C/wbbjB1MEbNPqeax7G7 X-Received: by 2002:a05:6902:3cc:b0:628:73aa:9c7f with SMTP id g12-20020a05690203cc00b0062873aa9c7fmr28233711ybs.632.1647410369895; Tue, 15 Mar 2022 22:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647410369; cv=none; d=google.com; s=arc-20160816; b=y8klx80iKLq6KAuSSOZojGtRqE/hV6bOzcJUxaAxF+YYvXxL2yAYTsB+9lbZqJvMFv dlJEMKKTYWR3LJvvGH2NbLUl0xWYGHFibsdGeKMQgmTYGX3CCq9QLEeXeV0yqV3Obsxg 76cD9iyQF1fL3XxLFnL0wQf0acA8fcdK1rUnidgnoksdvp/gJs3uAWNTdmiRvtZI6nvP BzfrvvzZWo1zYwhHVKvNbD9360l8zqBbnJKb8PZ9s+H+gDt/BSEMhPVbuazko3FOkry5 zwheTfQkLHyGhtE7CeDazdklQghONyi5c8Mo6wqVZe9b8xmQMtrSXywVTInFVWJu1lZc jsBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=uzx/rQUMOE81+2YuxRoc7gBccURuvdO8lUHsdT2k1Vo=; b=rNjoThTglVDcZbKOXTVJhGSU1K2xOgBHF52vM5xE7HYKVTFQ8sLTLbu1a4AFi1A4/k mTFLnsCXO/gqsaxHyrXaqBq2fRlS/KJDo/v/wStFZsVFf9Mtw68Se7xNSsmgeaCnyhZF bsDlUQU3z1a+cM33VUawyn0l2GfdxIuOF7e/8xXgeEKNav1eZOtzb8ILB2zgC5w0vd0x Agvb3jLsnlnAlbmxLcHBosFWNR9iFIUGhJlmlFo1qp4msDhAkE0kLn3+s+iykkhB1Rml 0w5rKZ1KQYrskHEcpPF7UHNfOYp/HN27/zh/gyLgKGOqGmAufC/kw6ZL7Xu+i6dfJtOf 5cnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="V/Gmw8eJ"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y4-20020a25b9c4000000b0062888f4d6d0si1028060ybj.362.2022.03.15.22.59.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Mar 2022 22:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="V/Gmw8eJ"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUMgy-0002G3-WB for patch@linaro.org; Wed, 16 Mar 2022 01:59:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUMgJ-0002E5-Mp for qemu-devel@nongnu.org; Wed, 16 Mar 2022 01:58:47 -0400 Received: from [2607:f8b0:4864:20::1032] (port=55283 helo=mail-pj1-x1032.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUMgI-0006RV-7j for qemu-devel@nongnu.org; Wed, 16 Mar 2022 01:58:47 -0400 Received: by mail-pj1-x1032.google.com with SMTP id b8so1303028pjb.4 for ; Tue, 15 Mar 2022 22:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uzx/rQUMOE81+2YuxRoc7gBccURuvdO8lUHsdT2k1Vo=; b=V/Gmw8eJiU25V1Kr8BDZ/HZMTGWTucmN9cND5W8m6wfSb5bAG45ovLjgxutXIq88Yt ZZQTvGqKThBIU6JR3NK6YNJ3hOrOqrUBGHGGmPTL7hItoDfwe5u4mnfMeL6MkLDVzQr2 byCCwaK2ImElaf7hZoTkp4KXnNB2eJscdPSJPmBwK6qgqtUhHWhU7EYKu7dKIqag+pv9 kZftYbA6U38yJcl8mhkdqF6ofp1vS+4SMwyciUMlbzsKDqddsXOSl0Q4oQA2ElmtRcbA lOhkCARIWXOfpFYCyuPB+MMinESrAQl15tUiXujfZVhchlSPu64Eo0jnnI/rRRQ4F71V VSPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uzx/rQUMOE81+2YuxRoc7gBccURuvdO8lUHsdT2k1Vo=; b=eBUS91oPPCvDN12uJMrb+tkNhXdlG3m/v2xb+UUhcotdiOzuVbdE9nBnkDO+aV8RsP rmoEeEn9rYCJJVjqqjVcfL6Zmb47B04HiPgnI5JOzleOBFI4Gyl/NfRF6qw1QtmPm5u5 1p3WivnqFkhTY+tijnAre2iLHz3Zzubpo5NXSGdRs/wzPBHRv4LoHb7CTxM22LNOfPbC SBdgRgmw909V8WfPsowyb3KP+nlJAclXuK9UVRmXQ40itpvFcWV3ENreMOwtp08HLj4n /+u+vVrWYZFCsgDrknSPHkZq7eSXd3m31AiNlQswvLgTriC8iAiNcJrq3DlshhvbuL92 MIKQ== X-Gm-Message-State: AOAM533MO0H51Tgb8Y9rQ+3J0krAacHy3JiewZyKdAxe9woI4ZmCGpyP 5soCx1pK7pzrwUPiz9GcLr1qlRE9SUi3ug== X-Received: by 2002:a17:90b:4d0f:b0:1bf:6a2:5637 with SMTP id mw15-20020a17090b4d0f00b001bf06a25637mr8588430pjb.106.1647410325025; Tue, 15 Mar 2022 22:58:45 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id i24-20020a056a00225800b004f6edabc9f4sm1236290pfu.72.2022.03.15.22.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 22:58:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 03/17] target/m68k: Fix coding style in m68k_interrupt_all Date: Tue, 15 Mar 2022 22:58:26 -0700 Message-Id: <20220316055840.727571-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220316055840.727571-1-richard.henderson@linaro.org> References: <20220316055840.727571-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1032 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Add parenthesis around & vs &&. Remove assignment to sr in function call argument -- note that sr is unused after the call, so the assignment was never needed, only the result of the & expression. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/m68k/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 2b94a6ec84..0f41c2dce3 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -408,11 +408,11 @@ static void m68k_interrupt_all(CPUM68KState *env, int is_hw) break; case EXCP_SPURIOUS ... EXCP_INT_LEVEL_7: - if (is_hw && oldsr & SR_M) { + if (is_hw && (oldsr & SR_M)) { do_stack_frame(env, &sp, 0, oldsr, 0, retaddr); oldsr = sr; env->aregs[7] = sp; - cpu_m68k_set_sr(env, sr &= ~SR_M); + cpu_m68k_set_sr(env, sr & ~SR_M); sp = env->aregs[7]; if (!m68k_feature(env, M68K_FEATURE_UNALIGNED_DATA)) { sp &= ~1;