From patchwork Thu Mar 10 20:27:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 550139 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6713:0:0:0:0 with SMTP id u19csp1335570mag; Thu, 10 Mar 2022 12:28:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxsGuuiDTTNHe7S+VOw6m6V8JSEdjj+CILJ1s08Y+Yp2lI3Opi4AGxzcyK9/3iZGzx/w6dt X-Received: by 2002:a25:e750:0:b0:628:983c:f3c4 with SMTP id e77-20020a25e750000000b00628983cf3c4mr5534591ybh.90.1646944136429; Thu, 10 Mar 2022 12:28:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646944136; cv=none; d=google.com; s=arc-20160816; b=hEvf5Uc8BqksQTs66XLqehsCxW9TQB5IcDad/5fznPZdbOZAEDGD/3BBSPK89ChRmK dXe1QHBXK//Hqs4e8Lc//FGTMimj3DD6kRKFeBfBC1MHJPWkpyY6h719K1y2jM8Cutnm 70VT0wgbOJAb0/q2kLO/VZUDI9ira2uz/RpVU9IwxGgQ9izlibhDiHP6C0atcZEs/p25 v7s3oj5Q3gxat08AWsJ4GPftxYtR5ckER3Lt3YcKF7p5jyhRSI2QjyACmMFpm6yAu/BE rKQD63gn7j8Hp2p/L4CiVzxfpLgO2FyaCncUIkyilkgMdG+9FjlwM+899NWpILL2pqYi XxGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=CRD5G+vs7vZC0o8B3zhihVWAZqaa3rFXLUQadebTozqeZ+DbfQzjaIUzvWu/udtU/L HdLUZ/QIxI37JW5hjfhwd803dHU9ZCy5/IG956CT4R/RaQocv+mn/1ChJsD7F15pcg/b VvIx9Ai71Nm7pkMbO1urlQ9YOFAV0ZWG0XSCuSfBZB2k9ZZkAiey8wX3FrSjXK+j07w6 OzQ+FKucYZjHud4XuMAWX5jDk7ZlZSBDcLVxmOlF3X26EMMmY1YQpD7Wq5Z1jabQIjf9 ZucI+XMQpvBgacYt86o4mMFC0qKLKh/uyvYrNYBw6i8bQJyNdXgHEs3s13fobujwoFEn r8Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XADrHLso; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a17-20020a256611000000b00628d079c3fasi3701948ybc.387.2022.03.10.12.28.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Mar 2022 12:28:56 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XADrHLso; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:32788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSPP5-0008Hm-P2 for patch@linaro.org; Thu, 10 Mar 2022 15:28:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSPOA-0008CR-Gg for qemu-devel@nongnu.org; Thu, 10 Mar 2022 15:27:58 -0500 Received: from [2607:f8b0:4864:20::533] (port=38813 helo=mail-pg1-x533.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSPO9-0008F7-27 for qemu-devel@nongnu.org; Thu, 10 Mar 2022 15:27:58 -0500 Received: by mail-pg1-x533.google.com with SMTP id 132so5669280pga.5 for ; Thu, 10 Mar 2022 12:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=XADrHLsowmHz98IKHJNxqQqL/8yVgU837I20LdtVu7rGvRbLo5QR4yBT2Akn5phbLz gJcuk+qFT6DiR5gDu1GllUEFmmJwQ5f9VOWwhcyWw4dFbo+Wv2ZWSY2rJjFme9+5exy9 xDcmC3EYG7ETHBTaBSVWI1F7Eyd+eleEVgG9ljTSy2U/e4JCFuUD35S4IkYIuC3B4cMk QhuB3JggC0tS/GFdktIAn9/RouJ3j1QG6KNoCwx7fcreriTMH2PDrP2gCeVWbBfHSBBG /yhmHxXd4dHpLosyTfRhr9asDbcrziQ0CMRBUlzZhm+QnrPwp9x2qMrPA801/z3zBaDx nw/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DPs3qyT+uZfNbgHJhAl1/at2oy1K0HPub76v6Xk9tE4=; b=DRIm6l3cSNiXmiRQPdK28OAs80FpIGeTIuaPGmgFDU51fEy9XpbspxSZG/0/louJF5 ilExDixQH9aYAwkuu1uXVJvOLfmZztZAfIho9DPPXUsZ7Eb51jpZujej7ujQRWCbd4fA tRyT+F9vICpiue/umzRu4mN0jQlho6IaZvTyQhEHToJ5pFN1LumO77UUnl4XV6RGVoH2 owIWE0XdeBYIup/G9eFdCXAmG9dpma6l+B9CvrKi2VFzaBsqiCIcnZ/LAgsDexpvKzwM CQlQjIV1ffez/s13J9XCrHTo1PV4n/mSWZaibgu0DCs2X0KKjYFCRiPrQRSr6PxlKsaG ZHDQ== X-Gm-Message-State: AOAM5315KAikf7WaKnYKDueZig268zZwk7XqQ+oPmwnjY69CZwkT5HAc UWp4IZ790IWHbbQ8FrQYQjzFEi6IGziDFw== X-Received: by 2002:a05:6a00:ac1:b0:4f1:29e4:b3a1 with SMTP id c1-20020a056a000ac100b004f129e4b3a1mr6822755pfl.63.1646944075789; Thu, 10 Mar 2022 12:27:55 -0800 (PST) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id l9-20020a655609000000b0037589f4337dsm6399938pgs.78.2022.03.10.12.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 12:27:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/3] tcg/s390x: Fix tcg_out_dup_vec vs general registers Date: Thu, 10 Mar 2022 12:27:51 -0800 Message-Id: <20220310202751.594961-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220310202751.594961-1-richard.henderson@linaro.org> References: <20220310202751.594961-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::533 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We copied the data from the general register input to the vector register output, but have not yet replicated it. We intended to fall through into the vector-vector case, but failed to redirect the input register. This is caught by an assertion failure in tcg_out_insn_VRIc, which diagnosed the incorrect register class. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 3b185b3c96..33becd7694 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -2675,6 +2675,7 @@ static bool tcg_out_dup_vec(TCGContext *s, TCGType type, unsigned vece, if (vece == MO_64) { return true; } + src = dst; } /*