From patchwork Thu Mar 10 20:27:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 550141 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6713:0:0:0:0 with SMTP id u19csp1337527mag; Thu, 10 Mar 2022 12:31:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0tJ1wnHQ3+OOPYDGikYc7fv9ihjmCCs3G+ztuVxZGoqzDY0Mr+WstXyN8QSe8GnOFnMUm X-Received: by 2002:a25:2308:0:b0:628:9a66:7327 with SMTP id j8-20020a252308000000b006289a667327mr5313378ybj.626.1646944285428; Thu, 10 Mar 2022 12:31:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646944285; cv=none; d=google.com; s=arc-20160816; b=oC+tJlwJeK6e+Z9lgDrDz2cB5KsprEg5laSgb1sNMSmFML4Y4az78mtgx2xyZ2xMBZ W8TZgN6OTgVyPnlUbLIRie/Qc5rC8L64mVxLrPOTQiNWskAkAxi2svkp8gidEZDss4RB 6VL5yOh/op17mr3sRNEBG8Nfkud+FhX+cqSMsTg6iYrajQdAKWZ1Kx+SN5E5RQM8nfIO /RVW1vtrCE7BZXTI8xz1DQ+P0txEwHRQLNM/7JCR/GEvsoi9Z3j+AcGmphope6lM+9HH Y2RVT0JgPYS8ir5WJpbo6j2h2kcarHsazMxFkisdaBr9jNCWi8H1iUA7c5kVMz8Nt5oX 5KgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=B3xcTA+wkvrIgpyo95I1q6jiSwwgZ6r49IcgTrclRMY=; b=p+efk0CUlR3mAQyf9uJpi8iVBHqYSEyDdlLpDqde2YZZKNr1QsdIdIhKlyDXiGsEd8 wuqRP7q1LWqDU1Wz4Spo1m4VlJO+4zJMGgoohZUV6cgLBRTHf6Mr+AvzxqZTsSzfGutE wPrrV/IUcg19oLC5/VmFS98ZUJsyVqUwU6nw/zlPKoH65GKP+j8nAvIpVmvQfd9BL+21 a3pcTEP7BDbznK5MvzP8A2j7Uqy0IsxjsRN0PnPZoVge9xyDJiJjNB2fzRhmG9EYehGL 2SF/I4Ds/W92jv8QTrOmgMXEDdwZIuIFQMumOfm3UC5HHGvcwogNoxAtCEDR1k9D8+cm vmSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I5Th7J3R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n193-20020a0dcbca000000b002dc5589a381si4169442ywd.188.2022.03.10.12.31.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Mar 2022 12:31:25 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I5Th7J3R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSPRU-0004Dr-Ug for patch@linaro.org; Thu, 10 Mar 2022 15:31:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSPO9-00089E-G3 for qemu-devel@nongnu.org; Thu, 10 Mar 2022 15:27:57 -0500 Received: from [2607:f8b0:4864:20::102e] (port=41639 helo=mail-pj1-x102e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSPO7-0008Em-UO for qemu-devel@nongnu.org; Thu, 10 Mar 2022 15:27:57 -0500 Received: by mail-pj1-x102e.google.com with SMTP id fs4-20020a17090af28400b001bf5624c0aaso6310287pjb.0 for ; Thu, 10 Mar 2022 12:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B3xcTA+wkvrIgpyo95I1q6jiSwwgZ6r49IcgTrclRMY=; b=I5Th7J3RW8Ztk1SpZaMiJ43ac0JIXrLjDTgASYIvs5LWTlVr+zWW/D1N2lTYJoegmm 77RpTsW+WH2H4kVffcwgLWcwTpePvU/Bq1SPTIKYQuFaC0L2hNmGcGu5NWX8vPCl5UoY WE5U6oinZOHoGPZRKfLmgAtvsQ6ncTzoFzbjBhVMcK/93HOd/9NtTkHgSgohOMqCmMWD 8RWluwXa9/brkFaEmGBAlTCxLaEJamMS+Y0r/nZl9DT+jUyG5uLt8LBD/cwgGxuHcvel +0cvmci57vhveivocFtiq7XpGj0XMjpUXbP8kiNx8HafERUvf69p9fXGdmib//SLngkP Hfcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B3xcTA+wkvrIgpyo95I1q6jiSwwgZ6r49IcgTrclRMY=; b=f7fgQxthbQGd/DiTE/2QSjqfDtjuq0yJvaqjeh7lUk7Ay7V+2e0ysX0SuHjEY4FswG zRN9Oy5krCSfKjXTxdt/vX6ZVa5Wdt/O30Og6tqf9CRgWwzFO8REzx/b3ESyL/Ok/t6C nMn8BlE+gBSpHO3VuiBH/N2i9jEjyiIcXLNRxHoFE/GxzK3a30u28NAq4T1uOhlcoVYa inYePy66SJndgdEG5nENOIcD6qLvzm3u0hakiS3Br1/U+fsif5YrDSSU3/MHK2apxFmB SlxNMOx4XwyuUcetztXF8BwAn3lFym1HmT1SgqtyTy3kgJSo++vk1MYuS8nhKG9bWRo7 vwJA== X-Gm-Message-State: AOAM530e7ceu0L20UIEDYPmXhmfc6IjQ1coCm4oVKQSSK/w3V9wVF1yh qZ1gWMOqiS7hs8bxWILaqgOA8iMb22EvZQ== X-Received: by 2002:a17:902:c9d5:b0:153:2161:dff6 with SMTP id q21-20020a170902c9d500b001532161dff6mr4309817pld.95.1646944074698; Thu, 10 Mar 2022 12:27:54 -0800 (PST) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id l9-20020a655609000000b0037589f4337dsm6399938pgs.78.2022.03.10.12.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 12:27:54 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 2/3] tcg/s390x: Fix INDEX_op_bitsel_vec vs VSEL Date: Thu, 10 Mar 2022 12:27:50 -0800 Message-Id: <20220310202751.594961-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220310202751.594961-1-richard.henderson@linaro.org> References: <20220310202751.594961-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102e (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The operands are output in the wrong order: the tcg selector argument is first, whereas the s390x selector argument is last. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/898 Fixes: 9bca986df88 ("tcg/s390x: Implement TCG_TARGET_HAS_bitsel_vec") Signed-off-by: Richard Henderson Tested-by: Thomas Huth --- tcg/s390x/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 508f1bccc7..3b185b3c96 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -2868,7 +2868,7 @@ static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc, break; case INDEX_op_bitsel_vec: - tcg_out_insn(s, VRRe, VSEL, a0, a1, a2, args[3]); + tcg_out_insn(s, VRRe, VSEL, a0, a2, args[3], a1); break; case INDEX_op_cmp_vec: