From patchwork Thu Mar 10 11:26:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 550095 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6713:0:0:0:0 with SMTP id u19csp908772mag; Thu, 10 Mar 2022 03:42:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+c5VKCNZ16Bd/pNdDdsscf3x7DwjGbRfBhj2Vy6YhhxzDBdiMlme9IMsuXLXXDFrvKz1U X-Received: by 2002:a25:3bcf:0:b0:628:c396:67c7 with SMTP id i198-20020a253bcf000000b00628c39667c7mr3495669yba.46.1646912541527; Thu, 10 Mar 2022 03:42:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646912541; cv=none; d=google.com; s=arc-20160816; b=JwUilxcFWTiCnkRtcwJQDof1id/1igi3MsNzGn/IrJxPIZ+6LyTdGHabDAe8nEWJs/ RZq7VtGqCZ/mcDLK5RdXp82DGdHx8WVXiCjdfLBBKOq/0VIlgqlgC7SHQReoaHpfrCVN smZNw6D83HTINv/8KEDl+OGueD13kdfdWx93DV3eZZz+uhyT+k4nV6otWuuSg/tmrn/p JJill9pu4vFZ4f49twsmk4+v7Elp8vD1L+iNWH0rgvyHFRVSjyJ3PZB8HbTYEr13R58w C4xOuM6v5x/ZqO2YRRt55IklFyXyjQwNOAs/hfeLPp+jyzW19hDnvPpRvfrLk94IeOfE b5DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=FucOuRxzk9AY38GO4hr3Q5xePPb7ussh8W5FYQ6tFWc=; b=LN9DF+Rp3XPHjt+X+Bm4mZ38zQIfLbSjKX6gWwH225oIRD/SHHNEsCMjK5AmRLsZka SuQzCtTZ0LbL+mEsuINJGf8gq2sjEOS5lKGX+VrgSswhx/YKlidSlpbnD1+hbqGNODsS nP6QWKBxQu0kK0LLRzTrhbQsroLsI8uAgM90wf5z/PzqP/pn5ymh3WVYalujhjJbLnEx DCr7ZDxAljKVPmGsPVnabkgJDBElBHLyeqILt4nvvccl5XZ7/D58HuV/guGZanvK0xhG JG6kzYnxCvRDiIBrd+iY76zwhJhMhrim2D5YQBkyMvUSZaU5o0jo2ORjUdgBMW/LWqcg hRgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=zxPuKA7H; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z30-20020a25a121000000b0062487d43b06si2947557ybh.212.2022.03.10.03.42.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Mar 2022 03:42:21 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=zxPuKA7H; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSHBU-0005lm-Dh for patch@linaro.org; Thu, 10 Mar 2022 06:42:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSGxJ-0005E6-Qd for qemu-devel@nongnu.org; Thu, 10 Mar 2022 06:27:41 -0500 Received: from [2607:f8b0:4864:20::434] (port=45825 helo=mail-pf1-x434.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSGxI-0007wj-BT for qemu-devel@nongnu.org; Thu, 10 Mar 2022 06:27:41 -0500 Received: by mail-pf1-x434.google.com with SMTP id s8so4819018pfk.12 for ; Thu, 10 Mar 2022 03:27:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FucOuRxzk9AY38GO4hr3Q5xePPb7ussh8W5FYQ6tFWc=; b=zxPuKA7Hj06xHJ9eBovLJbCbsSSPPteW3CWWNEGxJ1MFPYRQ15Up0u0mCBdHZHGvtO DciqIydZWgrmWTGcihDoJchF1tcbSqvo1dIivGv0lUIWOgRVYMdKnRVlNdAerCi34J9G tsak0K0J7G4FWSONXN2c0NwGsINxFyoOVK1MOk2EFYWWyOmVCBcEMBfxAENo6K/lB/to GlWI0YQUT/YDAO9oOiPvAvC+6ok+9z0xXUQxdUK2spQB1lJa2fAf8cMBA3QinF4rpkAr g1ZKhW0UtEYJNxzOIXvVg0YPe+5iAbkOWnsdBb1KByLHTqDDH607YwabpdbGEdXCfcT0 MO+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FucOuRxzk9AY38GO4hr3Q5xePPb7ussh8W5FYQ6tFWc=; b=gTWKYaUS4cRWwRrPCtSQvNr+Cq9jg3FV8wQxmGnoDXe4rcRlY7I+akKzo3cQPp6VnI NRnbiMGJb48B4tXLd5JeKU2FhshueyOMTk/kbYqRuAoj7yAseuDmzfF0vPS5vVArDebW d2AeMxObrwH26gQggsvBXE6kcWsQx2wANebkL41oprfhNDaG+yKdpvL68LLgn43TNr0/ ye5p6jph9cj6l4GTX/i58J0gkUbyku2V57uMk/DI7OrJONIOpqaIpuY19FQLeXNW/M76 +ldz4yz0FFYyJPO2IVcymo6RPl+tS7ogiez9MVZMNO6jH5MU7snp9kKjezT3xKafbSfd 4+lQ== X-Gm-Message-State: AOAM5318OI6SF9bjnv105NzXsphI8e6EqG+D02aFORobqC/RODzXMBFe X6D6nf/8GZePg1BZCC8x53zxlwVPMQPZ6g== X-Received: by 2002:a63:34c1:0:b0:380:c330:64c6 with SMTP id b184-20020a6334c1000000b00380c33064c6mr3700460pga.442.1646911659089; Thu, 10 Mar 2022 03:27:39 -0800 (PST) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id js15-20020a17090b148f00b001bfc8614b93sm3114977pjb.1.2022.03.10.03.27.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 03:27:38 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v5 11/48] target/nios2: Do not zero the general registers on reset Date: Thu, 10 Mar 2022 03:26:48 -0800 Message-Id: <20220310112725.570053-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220310112725.570053-1-richard.henderson@linaro.org> References: <20220310112725.570053-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::434 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marex@denx.de, peter.maydell@linaro.org, amir.gonnen@neuroblade.ai Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The bulk of the general register set is undefined on reset. The zero register is for the most part special-cased in translate, but the slot is still exposed to gdbstub and nios2_cpu_dump_state, so continue to make sure that's zeroed. Signed-off-by: Richard Henderson --- target/nios2/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index 182ddcc18f..97bdc0a61b 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -53,16 +53,16 @@ static void nios2_cpu_reset(DeviceState *dev) ncc->parent_reset(dev); - memset(env->regs, 0, sizeof(env->regs)); memset(env->ctrl, 0, sizeof(env->ctrl)); - env->pc = cpu->reset_addr; - #if defined(CONFIG_USER_ONLY) /* Start in user mode with interrupts enabled. */ env->ctrl[CR_STATUS] = CR_STATUS_U | CR_STATUS_PIE; #else env->ctrl[CR_STATUS] = 0; #endif + + env->regs[R_ZERO] = 0; + env->pc = cpu->reset_addr; } #ifndef CONFIG_USER_ONLY