From patchwork Tue Mar 8 01:53:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 549224 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6713:0:0:0:0 with SMTP id u19csp2218142mag; Mon, 7 Mar 2022 18:03:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJyeqK20iL9crPuLg65bEOHJu2o0PZIZvE1GIjdQ26Sy6kpimouMbO6OlIASPM5V2ubS0/LG X-Received: by 2002:a0d:c283:0:b0:2db:c5f9:b519 with SMTP id e125-20020a0dc283000000b002dbc5f9b519mr11043936ywd.171.1646705015802; Mon, 07 Mar 2022 18:03:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646705015; cv=none; d=google.com; s=arc-20160816; b=OveBfIKoyxnfM11bNyMjzrbQJsu15e+9NGASpBUCqWSTrUAypJ2qoNzP/icdwV5Na9 thyY0oRgQWJe2t+UVctBHKeTMvttJdc+iubMfRJ81znjelbPX+6A3o+o8XhA6X52yfef gvXIMnwuLuQ2JzQ5cBlij92Ef2utGzkpYmyuLZoqCBKl75xyTYdQDqoYwJoxP7pK5nG0 ZIa7lMY6MEKVFRaMmNMTrmBfEvmnCxqgYhlJ4KS7T+VyDGhWoV9/p9CaIPMO7bFpxN6N /wQyFnsgxoIEBxrEE4arPmyeo4+wqJY8AI3CfN9uPdsNwCqYMgdefHC3KCWUaLI6NTxz OSSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=pGFeTXonQy0rWrVtOsYjIVO+LsR7JRQAF9mj6S5D/+U=; b=Xcvrm7/9in8ynmjm5wNgtYr6q7igV6dxahBsBKMWjAvoYBzZo9wHy8KBLDWPg9xUkR vRZ7AyYihnEFwh+IFvp2GaCTfjSFyZAc2YfwKxz6kgtsoB/5u/RYDyPkOAooULq0n5NP o8z5ZeKfXfgWdhtCksboFKbwqvF7m9rse9f22v6ebcHJM8F4wX4POwHJPnRIAKswWJJd QVOnb6Hbe99w/NjpMRPLpqDXWBtJXsj1c9rMwR7UA3lTfql7vlCpRnG4gT9J/fiHgRNy Rir0zNT6BHrVK9MjDYgojhZm9wyxqalVput+LhngWr7Yi1j9VTVHNQf+QJLQW7CvAtpH WOiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=q+qhzH3a; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w17-20020a81e111000000b002d0a91b7f81si9772796ywh.432.2022.03.07.18.03.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Mar 2022 18:03:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=q+qhzH3a; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRPCJ-00055A-A7 for patch@linaro.org; Mon, 07 Mar 2022 21:03:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRP3M-0006s0-5d for qemu-devel@nongnu.org; Mon, 07 Mar 2022 20:54:20 -0500 Received: from [2607:f8b0:4864:20::102e] (port=56190 helo=mail-pj1-x102e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRP3K-0007zM-AK for qemu-devel@nongnu.org; Mon, 07 Mar 2022 20:54:19 -0500 Received: by mail-pj1-x102e.google.com with SMTP id k92so6649794pjh.5 for ; Mon, 07 Mar 2022 17:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pGFeTXonQy0rWrVtOsYjIVO+LsR7JRQAF9mj6S5D/+U=; b=q+qhzH3a4WZrLlJxxBsELFVMnfCK8i3qw1FHUhgXJKfk8Hez6AAnrS54mzWBZDGO3k DCDiAk/A/e+MI4GAV/tXqBWMaAXzE2y8zIBcVxwiqFiR6xkUrlz/U7JPxO0pRlSPigmB opxjY0KzftyNpO1bMycRemPC0WFs4hEob4PxCJEaCCzg3ptoIQ+KqGuuePQOCHVbo30X NgxIP+IbMibbIhQF+DtobcrXzkLlaMpYqShuCrJ9g/Ao1l5KfgG92P3vblJNGvsSewZx wnwQbtpRNY+bo0OA50zcH2nz/x4/p9i+aG+FV8ElMFOJyq9KhUEm5W2fsieNGI8mVjQ3 Y3XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pGFeTXonQy0rWrVtOsYjIVO+LsR7JRQAF9mj6S5D/+U=; b=a2H2iVzoqvkZMenrBCDL4wm3DLkaYyiW6cX5Hwlkqlt62r4y9/J/HUPfE5zQmugUXZ ssjwyAShIKgqaiXxU8ieGr10Bp0BJZpuQ4QSvzIn1vzFm8N3lM9cCJ7MxlDurHSgHif3 YRFErA/DDgnxbRTaVfq3+xml3/W/t5Z1yyTLm1K4fOWID3LfrxN+LWzQOh1coNMR8UEw 8gHYZYztZhSrtBx5o6PLm6XgRo/N03DB0qrah4gHk5Sq1I5URbfX3O3Md2CiX8Dkqf9D B6lOat2KPahABNysmnAs/IFPZe4cHaW4RPCJNCyh7YydQVJGZtCdYMn52gbqngQRKR59 G6cA== X-Gm-Message-State: AOAM531AEfqLg+iIzi2vHlmmAfQlz3xrgbEltays5ojMk1JGZh8v1FAR k2fMdTxW4Q4Z7u+PrQO26Z1fN3SbE7JKnw== X-Received: by 2002:a17:90a:ab17:b0:1b9:b61a:aadb with SMTP id m23-20020a17090aab1700b001b9b61aaadbmr2070713pjq.77.1646704457002; Mon, 07 Mar 2022 17:54:17 -0800 (PST) Received: from localhost.localdomain (cpe-50-113-46-110.hawaii.res.rr.com. [50.113.46.110]) by smtp.gmail.com with ESMTPSA id bh3-20020a056a02020300b00378b62df320sm12775221pgb.73.2022.03.07.17.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 17:54:16 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 11/11] target/s390x: Fix writeback to v1 in helper_vstl Date: Mon, 7 Mar 2022 15:53:58 -1000 Message-Id: <20220308015358.188499-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220308015358.188499-1-richard.henderson@linaro.org> References: <20220308015358.188499-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102e (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, dmiller423@gmail.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Copy-paste error from vector load length -- do not write zeros back to v1 after storing from v1. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/tcg/vec_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/s390x/tcg/vec_helper.c b/target/s390x/tcg/vec_helper.c index ededf13cf0..48d86722b2 100644 --- a/target/s390x/tcg/vec_helper.c +++ b/target/s390x/tcg/vec_helper.c @@ -200,7 +200,6 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1, uint64_t addr, addr = wrap_address(env, addr + 8); cpu_stq_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETPC()); } else { - S390Vector tmp = {}; int i; for (i = 0; i < bytes; i++) { @@ -209,6 +208,5 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1, uint64_t addr, cpu_stb_data_ra(env, addr, byte, GETPC()); addr = wrap_address(env, addr + 1); } - *(S390Vector *)v1 = tmp; } }