From patchwork Mon Feb 21 09:27:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 544428 Delivered-To: patch@linaro.org Received: by 2002:ac0:e142:0:0:0:0:0 with SMTP id r2csp3114384imn; Mon, 21 Feb 2022 02:03:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxk4b/L58dAWaU4YGWa1F2fdUIXN0+wtWI/LA/x7bmkpRcQHR9qZIucouJcURe1pr9D208 X-Received: by 2002:ac8:5742:0:b0:2cb:96f2:a4da with SMTP id 2-20020ac85742000000b002cb96f2a4damr16796115qtx.634.1645437804417; Mon, 21 Feb 2022 02:03:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645437804; cv=none; d=google.com; s=arc-20160816; b=jaEJ57Zl+kiX+dGxTv29vmpojOjsb/BX5uU44sHKOavi+ErhxRUzfF3QokgkSK1Gly sk7fXYDoVNOPFc4rcuMg5Mxg9jip5DwIhJUxenB5JnbjaUSacf9WGTJpg7kIHMZwnwFN yYWaQR1+VI2iyPyrYg2kDS3+ejf4XANtCYL3e1rHSqSfu7NlpCvrIF/y8AuMG4DUdTAr mk2TtCtwg41/zYKdVDGeB52Uqyn9NVJHIc8Annnv/YtIGsi92XxKn35znuSa1mhJMOph fWdiwQ3r/YJzLCzb+lnKnZrGk99xqgtDb2EWoCdNd0TxdJF62KxK7bUo8rKi/QoOCEji rolA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=shiikXU0x3kJ4rRPp+Q84tEp6CxEG3V5LoAvTu9ia4Y=; b=TDwFOD8tNA+EnMz40MbwZD6K9tPpLJi3AivIMo4WD4EAGBy2wKWm6BywKKp/Maw73d uCf4jFWIr/zKjRZC6Ogm6rliqWcWJlF2eo1US4x7TufFpidfE9vz2+tR4uiSxVXdTCiq vPWMurqa0E39Lg5UqRSo9v60p9wkIamaN85uk+e+vAhFFPqGS0+QDQXQAXOn2KxeHbiX pZTEGBAy3LCkBXsCRnjvw8nDV4xtyUwkUS+91RriaRSbIH3BQudJlKgdUpO/YT4wl5KS blmXK5mkFqUwy4Bgo7Q6oiYBHo46fNtL0B9FlanfbadDDeCyfVCELFH4wgF2XsHzybkc hJBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ktOsIhpQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h9si69882qkn.632.2022.02.21.02.03.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Feb 2022 02:03:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ktOsIhpQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nM5XP-0005wo-VG for patch@linaro.org; Mon, 21 Feb 2022 05:03:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nM4zq-0000ES-Ub for qemu-devel@nongnu.org; Mon, 21 Feb 2022 04:28:47 -0500 Received: from [2a00:1450:4864:20::430] (port=38514 helo=mail-wr1-x430.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nM4zZ-00013f-9M for qemu-devel@nongnu.org; Mon, 21 Feb 2022 04:28:42 -0500 Received: by mail-wr1-x430.google.com with SMTP id d27so25926572wrb.5 for ; Mon, 21 Feb 2022 01:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=shiikXU0x3kJ4rRPp+Q84tEp6CxEG3V5LoAvTu9ia4Y=; b=ktOsIhpQ4i6S/PqMh8IrilValkUrZX+aTHowsw7YT8FiM5TmmhhlNBJLnQceiuUBJa oA9+6nXp3FvDhHx+vyDw9fPl60jcdXQo/7ZKKpWxrgPR4to6GIbODXN84QGEMZLNoiki l/RLNllRGrX1WVW54/TvbnF4qwoeEiaNErCdXEqYJjNbE7whPiphlMowBhTiJCF3iTdo HRHXxB8KFalU7Z168sbDoYfAzoHgiBBa/iZRQTmtlRHUSEHhJhwLFLtARY/Ko2/Yx7/3 5e/CYCm9D+n0tg2pCPNkI0vYSHPH6w0k6NTpoDzMXvIxWMyx6H/Z7TkS6Qkt8E82dKny o38A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=shiikXU0x3kJ4rRPp+Q84tEp6CxEG3V5LoAvTu9ia4Y=; b=LTIIu3nm3M5uWDvDpfurr4eWw4aAn6cKrrUpihiX9mBLYWpFzPCjPTvT5ey8IsYN47 sorGS3Jy1NICweV6M7WKy0F6EtyBQ7V8cks7/84FI21yyRaS5pK08YFBLWQFTOzDszvk wimg5s6z3Ebgieqt7zyYBx1iQqlTpo5E9/j08f4Sz/qpe4xjaxIROitCWgSHpFr8bEj2 cV2KYrTjwEnCDyHInUj0h6ZpmGlqQvd6v1zNwAwGeu77xmAJ1hjH85Fz/6afm5b3RRcO YeS+c4h2PXRDrItrqKfoTkKkJi8D5Bg9PYbKEmBrBHb8YDXT7tFfWJr9a/llSkw4nJoc CvAA== X-Gm-Message-State: AOAM532GLiGD0+qC4tz7lfA5FMvHs+P3aj+noyAYvZSj/nQ4ewjqPAnd 8fCOVNJQFcb/sggCSPOTI0kQIXpt/qkEVw== X-Received: by 2002:a05:6000:18ad:b0:1e8:cbe1:afd with SMTP id b13-20020a05600018ad00b001e8cbe10afdmr14676674wri.352.1645435702404; Mon, 21 Feb 2022 01:28:22 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id q76sm7555778wme.1.2022.02.21.01.28.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 01:28:22 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 25/26] ui/cocoa: Do not alert even without block devices Date: Mon, 21 Feb 2022 09:27:59 +0000 Message-Id: <20220221092800.404870-26-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220221092800.404870-1-peter.maydell@linaro.org> References: <20220221092800.404870-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::430 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-id: 20220215080307.69550-13-f4bug@amsat.org Message-Id: <20220213021418.2155-1-akihiko.odaki@gmail.com> Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- ui/cocoa.m | 5 ----- 1 file changed, 5 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 7a1ddd4075f..f585a5c177d 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1709,11 +1709,6 @@ static void addRemovableDevicesMenuItems(void) currentDevice = qmp_query_block(NULL); pointerToFree = currentDevice; - if(currentDevice == NULL) { - NSBeep(); - QEMU_Alert(@"Failed to query for block devices!"); - return; - } menu = [[[NSApp mainMenu] itemWithTitle:@"Machine"] submenu];