From patchwork Thu Jan 20 12:36:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 533557 Delivered-To: patch@linaro.org Received: by 2002:ac0:f7d2:0:0:0:0:0 with SMTP id i18csp34096imr; Thu, 20 Jan 2022 08:44:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNYdN0VvA1p+w4kcAuP/lPB83RSYHwKXWhM3u+/gx5NuI3dKba4v98dYTu/MnD+Eus565W X-Received: by 2002:a25:ba8b:: with SMTP id s11mr22800081ybg.287.1642697042636; Thu, 20 Jan 2022 08:44:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642697042; cv=none; d=google.com; s=arc-20160816; b=MJKzIz3pkF+G88ap/JxbE3/APVv24Ub1Md77Gy9ZylOe1/pQmmdlu4cevwgVwNNu/P XQwFxNeGIGWzVuM5GTPm4Bb+smWVlrFklXbjxEbuWeRyZhTP6W5HqEzQiZGloIOf2SZL hFeYsqTeYFr4loVA1g5OVWia1+/UabIwoOGZwCYtNyY7cAErYiOJMcZOXU/yS9FmwBOQ 0vPLY2Ix7zN46DLQJKUQxniIdjpALtzSzBKR+ahK1uAQ7LJWBzVE6hp6/zK15Ee5v3iw jsmJSRFmwOMxscYl0DIe5Uvo1UYNGH7l4unAPs7XNVM/lL6Tpy8NjIbJ8VvcSG7mvhN7 Wx7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=wdLUqpPXIVhIxJn/y0Ry8LmHLdVQEvWxzFrl/eWpdGs=; b=0esxHia7tRPxqVfn4lFlNCCoKtC0bfUg1J67eI6poJoiB/cVXbO3HJuALQI+i1qnhI YVn4k4lInqE2Z8rrk9cqB44w+P3TVJ2wveDTsyEPfifRvQEj5LQcuZADQVhLr9uP4X6x RSsezopBkqmmv/Tqf6vIZnndfiRN+aBI9W5sAtr2lTXtc1T3NjNFeSHQox0lKFHV413P yDoifNQ0sQpOvLXjxKtirWY1DP3rToLKCR7bDaBnQob+Ve07aedlvlZNAiKzfhmkGFXF 1I3B/eID92XA2mzGkllVrfkKeQkZS2hwp638+NcDppcoSSS/dTzjEKxW3OgpWrTLcn8s PqCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p0SLMOU0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u64si3762880yba.527.2022.01.20.08.44.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jan 2022 08:44:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p0SLMOU0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAaXZ-00022G-8w for patch@linaro.org; Thu, 20 Jan 2022 11:44:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAWgi-0004JF-Lm for qemu-devel@nongnu.org; Thu, 20 Jan 2022 07:37:14 -0500 Received: from [2a00:1450:4864:20::32f] (port=42949 helo=mail-wm1-x32f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAWgb-0003J8-Ie for qemu-devel@nongnu.org; Thu, 20 Jan 2022 07:37:06 -0500 Received: by mail-wm1-x32f.google.com with SMTP id f202-20020a1c1fd3000000b0034dd403f4fbso10085036wmf.1 for ; Thu, 20 Jan 2022 04:37:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=wdLUqpPXIVhIxJn/y0Ry8LmHLdVQEvWxzFrl/eWpdGs=; b=p0SLMOU0NDGYsPLinD0fQo5lKh5DfQsMqTLCy2OCuJF0mewuc38y6sihEm59kRxXbi 8NF7py5s9Ge40QwLRqyys7WAFABsQl54yLDorJFMiFSyVGxwCMpBh6bmY4nz8CP5Gx6U Mjc2xgfjArUx7VyCcV+Mn0xIa//u2oGiQZ+92E8h9lNRcvCNwMYxr2Loc/5JaH2yXxwM rdhOoihmYH3JMah7dQyMppSupSpO8Y5Vujkh4CF8pBDGTBXS43cvDQUbpLEV4C99WCqw cIj3bMxNjwE8pR6VHK7WWNifTC82OMO1PfWAFrElAPoXr5/iFNQHZQEspy61UYE8OabT Sz8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wdLUqpPXIVhIxJn/y0Ry8LmHLdVQEvWxzFrl/eWpdGs=; b=cGpf6OpRW9fmXHOdwKXhgUlCY3TG2r7eFq6IQ8YGGiRnApVUwxhKsE9UZ+is4gytb8 XnLSOpNQzhVFmXYGQaE486lFVAFYiGPQHnFJk+wklBk9A2aCu9T9GgiNqmeAP3uFdU5P VeVPNnhJoSlB0YuMdyfRdLZEHfkc5+8LFUZKUen+R3xVQF+sL1s9kNUbZ+k65h5PlyLE gBL3iATwIR5Scr+4FHmqN1g2LOjR7R3FzbR17HgAxKcJUl6QMywX9aFg9ls/kJ6N6KJ6 n0AMK+Bvg2bjEHp0RoqePeFL/c0tncyIdygGW0K09AUa8RPnpOidQs1TA7IWZY9IhlUb Sd5w== X-Gm-Message-State: AOAM532leHiahNXFcBtcoKhKsnKGNDFjH3c6kSLj5ZVSWHtVRsd2Lrfr PEWrkHICUZOWWLkw06GLQtztgxeMl1P3xQ== X-Received: by 2002:a5d:598c:: with SMTP id n12mr20053923wri.386.1642682223294; Thu, 20 Jan 2022 04:37:03 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id t8sm7993324wmq.43.2022.01.20.04.37.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 04:37:02 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 27/38] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value Date: Thu, 20 Jan 2022 12:36:19 +0000 Message-Id: <20220120123630.267975-28-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220120123630.267975-1-peter.maydell@linaro.org> References: <20220120123630.267975-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32f (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" process_its_cmd() returns a bool, like all the other process_ functions. However we were putting its return value into 'res', not 'result', which meant we would ignore it when deciding whether to continue or stall the command queue. Fix the typo. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20220111171048.3545974-4-peter.maydell@linaro.org --- hw/intc/arm_gicv3_its.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index 5919b1a3b7f..a6c2299a091 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -678,10 +678,10 @@ static void process_cmdq(GICv3ITSState *s) switch (cmd) { case GITS_CMD_INT: - res = process_its_cmd(s, data, cq_offset, INTERRUPT); + result = process_its_cmd(s, data, cq_offset, INTERRUPT); break; case GITS_CMD_CLEAR: - res = process_its_cmd(s, data, cq_offset, CLEAR); + result = process_its_cmd(s, data, cq_offset, CLEAR); break; case GITS_CMD_SYNC: /*