From patchwork Tue Jan 11 17:10:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 531127 Delivered-To: patch@linaro.org Received: by 2002:ad5:544f:0:0:0:0:0 with SMTP id a15csp3683719imp; Tue, 11 Jan 2022 09:32:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxsy6OsbHzKpvDIpPCYHewbUQ8tpEoee+SsAX54efqRDObyBZokYdeqZI15eaT+C4iC1+gX X-Received: by 2002:a67:846:: with SMTP id 67mr2589803vsi.7.1641922355829; Tue, 11 Jan 2022 09:32:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641922355; cv=none; d=google.com; s=arc-20160816; b=ej4tzYpVUVhiebrcxlFK6QiQwN0IjhDmDfFOeCMK9SL+eHhpLOtlxPC+I1LbsSmNC/ /KpqECH/JOA2cdCybxrcTPg5nPsb8oZ+rhpV63CJ6LHUW3D0e/PpniqOs98U2EMln2RU NxsBLTfJsfDGIknyQK9fv2R9AqIti6vVrhjQz0WitD5/xQ13f0o0fPpdQtKzm9sqPfrf Jq4lTYfEgXyHyIwJxqEYeVpZXPFGvXhNzyaPRA56j5xMoC0s0DCkqIRAHYpM5zw5PJDk yrDLseWF5xsDwcEpFunr+2J8oG6Obz1jfE9X2bB+2m+BqexZrUZncMUiXYYyDh5tR5QP bQLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=JYYFGFnkCFT6+fa4EaAq6TzfkXiIkABdM4xMZSz4G4w=; b=eZcUk2hX+CR/391c20TQosk0fBDQBkkEq4BGjsHQuZ05yeLIqUukhBcBrv2nNN5yuP CnWerAAa3sBmlVy4qdCBK3lWrTpAJckyi19Usc/eC36ZEcS9CFUsFh6tN3mC3u3KCu0n z7U1jZnNj0LI4e36MsCeC5NgvO3NTXXN9Z7S1n0muZK0niv5DWJJzTkkuup1iTU+qVb/ V+PAICN3O7eCmA/jdXRVlwbmii+qQpRN5MUIgnyb5IPV6LmtzrrONiFjCzbKItNoUsiu ktwYlMhhV+7dbtAf0m7cppvJ6dNf8NUzWMVIBGwJUiov/+kxYXJmxwd0gstCGegwCO+b ECLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=yDCdAjWs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a27si1438811vsl.13.2022.01.11.09.32.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jan 2022 09:32:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=yDCdAjWs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7L0d-0004t6-99 for patch@linaro.org; Tue, 11 Jan 2022 12:32:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7Kfi-0005Au-M4 for qemu-devel@nongnu.org; Tue, 11 Jan 2022 12:11:01 -0500 Received: from [2a00:1450:4864:20::32c] (port=41489 helo=mail-wm1-x32c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7Kfe-0007I5-6Z for qemu-devel@nongnu.org; Tue, 11 Jan 2022 12:10:56 -0500 Received: by mail-wm1-x32c.google.com with SMTP id q141-20020a1ca793000000b00347b48dfb53so13664wme.0 for ; Tue, 11 Jan 2022 09:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JYYFGFnkCFT6+fa4EaAq6TzfkXiIkABdM4xMZSz4G4w=; b=yDCdAjWsHofW7aXSfx2hOBhoDBo6vW8AltwWXoe+9zEI6gepGK5xZBVbP/XK58hGMv 26YrTLZQsxGGFjYLFEdRpbZQg68p3rlxI2N9DHRGY9VQ/aCaWQfyKVhv2WdMB7VfSrpy MMnJQB2C3W71ALNxT8Jrf5G23hxVs7ecR1vRXn7Oe5lQUVdqGs4cAg9gnZwsONpAUCoD 05Y0Cm2jkGnes1R3hiDNrzgxPJ+NxIBG4RTEbjsTeMpOMD9lvbKALalnkPaWwdEVXBOJ wagTEmRMOnvxmxcDqfxOaQBp9zUav5t0r8xxwhLgLHAWGL6onivzWn+oL/hJaPOr+Ja4 V4aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JYYFGFnkCFT6+fa4EaAq6TzfkXiIkABdM4xMZSz4G4w=; b=0PeIjbIWKviIG8jxDosqvqxI1bK215zFcPVOOSzirivLEOWCIzvnH01/Zn9XPhBpxL SW/gT/hmc5mAuCis2rOovDfYhNDZuCIssq2+SP4WiaWkOGFxTzrD66tELJyJ+7x12sD7 /z6po8UQDF0Gaq0lo1duHnHYXfudn4kc4kL21M8yEy3FV0y0bUTMzUpSrKPB4nPwZEjh TpqEdJYeU5y/Unb3wsdrin6lminYZ1BWGkG4ts/jm5eQU43UqocdX5uJ1i1PDmFle+9k 21SUeDp/90CUIm6xjQPOgxRDYkJTyTJV9vHZUAws1rsu31XWUeo/Kk1TxgHmGZWkHKsQ baWQ== X-Gm-Message-State: AOAM533KwzkHEUKk2K7BOhRfEswfxkxJB7u+qBip4nhHQR8nFe3fiEsW MOfGbn+S8QEnhicfyEJnxm9baQ== X-Received: by 2002:a1c:7415:: with SMTP id p21mr3389055wmc.114.1641921052948; Tue, 11 Jan 2022 09:10:52 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id c7sm11157941wri.21.2022.01.11.09.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 09:10:52 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 03/13] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value Date: Tue, 11 Jan 2022 17:10:38 +0000 Message-Id: <20220111171048.3545974-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220111171048.3545974-1-peter.maydell@linaro.org> References: <20220111171048.3545974-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32c (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shashi Mallela , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" process_its_cmd() returns a bool, like all the other process_ functions. However we were putting its return value into 'res', not 'result', which meant we would ignore it when deciding whether to continue or stall the command queue. Fix the typo. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- hw/intc/arm_gicv3_its.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index 5919b1a3b7f..a6c2299a091 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -678,10 +678,10 @@ static void process_cmdq(GICv3ITSState *s) switch (cmd) { case GITS_CMD_INT: - res = process_its_cmd(s, data, cq_offset, INTERRUPT); + result = process_its_cmd(s, data, cq_offset, INTERRUPT); break; case GITS_CMD_CLEAR: - res = process_its_cmd(s, data, cq_offset, CLEAR); + result = process_its_cmd(s, data, cq_offset, CLEAR); break; case GITS_CMD_SYNC: /*