From patchwork Fri Jan 7 17:21:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 530477 Delivered-To: patch@linaro.org Received: by 2002:ad5:544f:0:0:0:0:0 with SMTP id a15csp563801imp; Fri, 7 Jan 2022 09:27:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWi6gRV8ZsCvnj9UspHsJTwb0bKunotRoVYd7m0J6hS5dfzTLsTbKr218rQIfQW0MRpSEt X-Received: by 2002:a25:9205:: with SMTP id b5mr63589358ybo.2.1641576468723; Fri, 07 Jan 2022 09:27:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641576468; cv=none; d=google.com; s=arc-20160816; b=pznrHuvMFMCl3o46KaIoki4RUDNphidHo6WSlIjp4a4ZelNSF80ixYIXJdegG79VLU iEYxF5PNpjrV2m6blBqUh2//zGLFtMlwqusS/6Y+m0jw0OzxPHccY5behLy2cU8SP8kI suIGR5nc+wNOz5PSNxZfrzv/ZBIvdA9pcfXlylalc9fQoKm68amF4z9xWWp6i0rxxqIe gUHwo6wXdCf+U1ZwuOt7KgtQjEnMYhL1Y3joermBAS1YmcWDG7WDge1zCuxhK7ZKUl8T YoCPLGFT+BhlGbZKfqhcZ84WsPcadBfgg6ehb0b8IqqCJy+XkFUpBzYKWraWISXeWywv B5gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=u3ij0VU4vY4kMQen5OzCseC136vxmVv0PB7jvlGBDEY=; b=DIPfQF9pNusn0rQeQ49gI1lCmgzPqy4nX73dzJp9n9gnQwA8LYQumMpAlJ+O9S6+zx wVLkJWG80G+KJF71h73fG1JlUomZteXD0U73Rx87NTzXdxz+Ugs565P2jYDE/xLdPNNo X8wkPAKtQgytkPgIYpDs9RpVuDR+oYZM5xEhvxffu7u5ZqgXZIkE09GgcZg/EWDYwuo1 mZtnhHSp1kUmwrwa+M5tICAgKFmfPtuLlaySNhJJB1kJGxjkKOXxLPRDDOVrSlFmqOFe CHW27IWhAz1p1tgsgz3i7Gdeyhv6RB+kJfAAjr+4ClgmPrirCGr8ZlsQQzp55Hq00I79 qbnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oK292yma; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c3si4023017ybn.313.2022.01.07.09.27.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jan 2022 09:27:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oK292yma; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5t1n-0002vh-EJ for patch@linaro.org; Fri, 07 Jan 2022 12:27:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5sw6-00057i-3b for qemu-devel@nongnu.org; Fri, 07 Jan 2022 12:21:55 -0500 Received: from [2a00:1450:4864:20::433] (port=43586 helo=mail-wr1-x433.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5sw4-0007u5-NZ for qemu-devel@nongnu.org; Fri, 07 Jan 2022 12:21:53 -0500 Received: by mail-wr1-x433.google.com with SMTP id o3so12307160wrh.10 for ; Fri, 07 Jan 2022 09:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=u3ij0VU4vY4kMQen5OzCseC136vxmVv0PB7jvlGBDEY=; b=oK292ymaBd424tZYEzCz6iSNOJBJD3gFM4YAWtuSWThPVDHhuSl8hUfZlgQjjEwD8f DVAAGGrF29cYzvunDAtPhXvWCW+Ph/xk60vTrAq+fo4B4jI2NYVbLz1T0IVfco7Ej6yv F0zxguK/koS9zeGsPh/NiVVXnXq12v9V78MPZS1+hzDWPuxWlAnfSOC+qJ9x2aCg9b6s UdMfgI2s3yf541nC/HhzrrdVBXnIIyGxT8gzMiqHUP4CUNHV/lkyASDXENlCW9ZQsX9Y 6Sdrb3GwrJepbo3AIEETmexjkMAbnghddNACsuFVvBnv+E+GGXq1qH9EP+FLp0J8kJo5 8tew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u3ij0VU4vY4kMQen5OzCseC136vxmVv0PB7jvlGBDEY=; b=peyqBw9OR4RDcihyWb7N6zcd8J7opLp265NLfJhX5XMTs4Uv3oi+Xtdz8xSJOHwxAw jNVOHNdUzk591lsmUXBGhcsdo8GGbEORIfmJMfM730Ay/yQ+VzXAKcjk2UUT/DQggD0s hA/UsynSWKU5DP3wEvb1wwCNQ/bYkwCBdnhEpg9rm0CqtUj223Eciyi5poWHMgAnffLD mWAbr+RgdhUm46aneTv+xaPaXSCgt3K7bY/jTh7PLE9oj4wLZOYjvHCcTy6q5e+nY2gX G4kmhfr5f53wQJvLVTsOwiQO/BlXj0uwvoqPCKKzLDDxDttqz88YRHySSWupaVvefwEU 6A/w== X-Gm-Message-State: AOAM531U1PGvG+sLK9Z91H1GC37laHSKcvDR3n/ZI5aEmhIbHs1Tk9Xz Ye0E9Y/CdU0kmmWEV9REYx49QIXxhVa5kA== X-Received: by 2002:adf:fb4f:: with SMTP id c15mr9727979wrs.509.1641576111408; Fri, 07 Jan 2022 09:21:51 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id i6sm6060219wrf.79.2022.01.07.09.21.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 09:21:51 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 12/19] hw/intc/arm_gicv3_its: Correct comment about CTE RDBase field size Date: Fri, 7 Jan 2022 17:21:35 +0000 Message-Id: <20220107172142.2651911-13-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220107172142.2651911-1-peter.maydell@linaro.org> References: <20220107172142.2651911-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::433 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The comment says that in our CTE format the RDBase field is 36 bits; in fact for us it is only 16 bits, because we use the RDBase format where it specifies a 16-bit CPU number. The code already uses RDBASE_PROCNUM_LENGTH (16) as the field width, so fix the comment to match it. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- hw/intc/gicv3_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h index 6a3b145f377..14e8ef68e02 100644 --- a/hw/intc/gicv3_internal.h +++ b/hw/intc/gicv3_internal.h @@ -400,7 +400,7 @@ FIELD(DTE, ITTADDR, 6, 44) /* * 8 bytes Collection Table Entry size - * Valid = 1 bit,RDBase = 36 bits(considering max RDBASE) + * Valid = 1 bit, RDBase = 16 bits */ #define GITS_CTE_SIZE (0x8ULL) #define GITS_CTE_RDBASE_PROCNUM_MASK MAKE_64BIT_MASK(1, RDBASE_PROCNUM_LENGTH)