From patchwork Mon Jan 3 22:47:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 529642 Delivered-To: patch@linaro.org Received: by 2002:ac0:9f5c:0:0:0:0:0 with SMTP id l28csp1189857imf; Mon, 3 Jan 2022 14:48:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpgoCvJFlhk56iRGv5uCBnLSZRuBhvOGeXZpWCb5ctmKaZGa0zSurhLUNJ5TVZuICgBETM X-Received: by 2002:a25:328a:: with SMTP id y132mr17242621yby.241.1641250128231; Mon, 03 Jan 2022 14:48:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641250128; cv=none; d=google.com; s=arc-20160816; b=H0aK1sfF3dNvL8F2UugrD6QmNxvrEPF3v9mC8LNmvZnwNOc2YSjsbiMwtCZECZ5xoH 2DucLlnN6KLlv2QrJP3JR1CRXe+wxR3gMtNePgWP/S0XgzJpsxy/RnivpUt2nM0EDERm c09SZhg8ULpvK9t0C0MA0dG1QgA6pz/M9zCCE6t02xXOnlALPwc+OSZaMYbbuTeQxTUu Kq9EVmxcwwqBe6d+Yv8x3kjwdbv9UsYf152GSCTVoq947MtL4XCLHUyzJkzEw69Lzhdd epj02bFszlziKDD6ULnKEX04jwUUPPQtKlgsNrfMJU7XwRxPnFY/S8bDWBxIoTmv5DCF JkCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=449UboRzNBRlO0QgF+0wNY9uCg79UdVy1rrOX7CEFyY=; b=hkvpyNqEfRRpL79jL1Jmx+WBcYdnG94HylztE1Kpm1bOWj/Y8yIZF4T+YM5aL54bPp 2iPUmczyPBgZZOCBNTu4C1ZVVvCdX35qmaGlG7UaXZXbi95UehuazVs0A4KyhcMttZXH H1hUJWrOtx89dqQPPTwO3HugvgPapQt9UXLQo/ubysO+QtaqmOzkvRYKfAMOQ07u/6yj CHQ3vcrs+9bbzviRfDFGBaP48V6B0D10T6eMWqGYYHAa9qpPuYIJn9kkW5cjwDLJ5YB9 sNqWI3DaLfkQ02t6pzQU2+nq20z+idFQLHqbNNC4u/u1IkliApIuJJqRCbHFvZ95FNAu Y9jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=IoI13n0Q; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d13si20144367ybc.192.2022.01.03.14.48.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jan 2022 14:48:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=IoI13n0Q; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1]:43898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4W8F-0004JQ-Mu for patch@linaro.org; Mon, 03 Jan 2022 17:48:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4W7a-0004Cz-O6; Mon, 03 Jan 2022 17:48:06 -0500 Received: from [2607:f8b0:4864:20::72e] (port=37434 helo=mail-qk1-x72e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4W7Z-0001Gy-1a; Mon, 03 Jan 2022 17:48:06 -0500 Received: by mail-qk1-x72e.google.com with SMTP id t66so21716027qkb.4; Mon, 03 Jan 2022 14:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=449UboRzNBRlO0QgF+0wNY9uCg79UdVy1rrOX7CEFyY=; b=IoI13n0QWnUaMyBfMdyotoUBg9NYnJkO0krrYAi/prQ6tbXsJ9z7/z9qwRDk3mQPmp OtP5uCO6nT2y8r5R+Q8cvyS0isTKIGlZj5HKoxycnBLlLJcuAzRYGyMyxXG3ZZPKx8wD UdTkqX3lYOptrSEpwNiMRTZoOe4e3svHvwZ+L2D3VfjJLRAqoe/0RVI2SikERfZTR5g+ sDJEuwzXmyCfI4IkYU6kdMugeSR9uhDqbbNGzwZAR4jbTDmtsy9VqqY/Z5IMbO8Zmdy/ KxqttL+wuVPgVHnpF1I85w4Tz9iAGDvPw5k95NXIDxDFWHD0HAEXa4uBVopkQB+oFwd2 yV/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=449UboRzNBRlO0QgF+0wNY9uCg79UdVy1rrOX7CEFyY=; b=k1pcV5ZYD36U/gicjr5QIChRalVRIZhoo3PY3Yvlivq/bs7efADE4ZcHfwFHUULvz+ 9lZQO4eP5TUwnsNUULIoJZMEow1GdX5NyUJ+ePTv6wdnfWiGNj1yJby/ZeSRBH1m/sso OtRj7ALkCyQbZNkz3Wq5IMnodPwCQtXYHYG8/tiCne3swbfWlSZRzI9gNHSReo64pnxz v9U+COd7TW4ipDUlDPX2x1GoNHg321vLr045prNnWjRfcsSbZoMKyfGl68yweARkoLp6 ypw+bEtH6JAC+UI9B1rviBRRpD0NCU5kKgT44ry+3pYYL5EvM0DJiZl7LA1fRRXHDgwE KPPQ== X-Gm-Message-State: AOAM532KMgjy2+ouykdv3yI9RKBkmWN+r7qUv5p2/8Lj2hx/CsFh4hiA 8W42QBSJHJ0e26BeBIpGxkDY3R9S/vY= X-Received: by 2002:a05:620a:1708:: with SMTP id az8mr34293557qkb.142.1641250083871; Mon, 03 Jan 2022 14:48:03 -0800 (PST) Received: from rekt.ibmuc.com ([2804:431:c7c7:f4d8:aa07:335f:99e0:a6e7]) by smtp.gmail.com with ESMTPSA id t123sm22917176qkb.135.2022.01.03.14.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jan 2022 14:48:03 -0800 (PST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v3 3/4] target/ppc: Use env->pnc_cyc_cnt Date: Mon, 3 Jan 2022 19:47:45 -0300 Message-Id: <20220103224746.167831-4-danielhb413@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220103224746.167831-1-danielhb413@gmail.com> References: <20220103224746.167831-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::72e (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=danielhb413@gmail.com; helo=mail-qk1-x72e.google.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard.henderson@linaro.org, danielhb413@gmail.com, qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Use the cached pmc_cyc_cnt value in pmu_update_cycles and pmc_update_overflow_timer. This leaves pmc_get_event and pmc_is_inactive unused, so remove them. Signed-off-by: Richard Henderson --- target/ppc/power8-pmu.c | 107 ++++------------------------------------ 1 file changed, 9 insertions(+), 98 deletions(-) diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c index 27c4c7915b..73713ca2a3 100644 --- a/target/ppc/power8-pmu.c +++ b/target/ppc/power8-pmu.c @@ -24,19 +24,6 @@ #define PMC_COUNTER_NEGATIVE_VAL 0x80000000UL -static bool pmc_is_inactive(CPUPPCState *env, int sprn) -{ - if (env->spr[SPR_POWER_MMCR0] & MMCR0_FC) { - return true; - } - - if (sprn < SPR_POWER_PMC5) { - return env->spr[SPR_POWER_MMCR0] & MMCR0_FC14; - } - - return env->spr[SPR_POWER_MMCR0] & MMCR0_FC56; -} - static bool pmc_has_overflow_enabled(CPUPPCState *env, int sprn) { if (sprn == SPR_POWER_PMC1) { @@ -46,80 +33,6 @@ static bool pmc_has_overflow_enabled(CPUPPCState *env, int sprn) return env->spr[SPR_POWER_MMCR0] & MMCR0_PMCjCE; } -/* - * For PMCs 1-4, IBM POWER chips has support for an implementation - * dependent event, 0x1E, that enables cycle counting. The Linux kernel - * makes extensive use of 0x1E, so let's also support it. - * - * Likewise, event 0x2 is an implementation-dependent event that IBM - * POWER chips implement (at least since POWER8) that is equivalent to - * PM_INST_CMPL. Let's support this event on PMCs 1-4 as well. - */ -static PMUEventType pmc_get_event(CPUPPCState *env, int sprn) -{ - uint8_t mmcr1_evt_extr[] = { MMCR1_PMC1EVT_EXTR, MMCR1_PMC2EVT_EXTR, - MMCR1_PMC3EVT_EXTR, MMCR1_PMC4EVT_EXTR }; - PMUEventType evt_type = PMU_EVENT_INVALID; - uint8_t pmcsel; - int i; - - if (pmc_is_inactive(env, sprn)) { - return PMU_EVENT_INACTIVE; - } - - if (sprn == SPR_POWER_PMC5) { - return PMU_EVENT_INSTRUCTIONS; - } - - if (sprn == SPR_POWER_PMC6) { - return PMU_EVENT_CYCLES; - } - - i = sprn - SPR_POWER_PMC1; - pmcsel = extract64(env->spr[SPR_POWER_MMCR1], mmcr1_evt_extr[i], - MMCR1_EVT_SIZE); - - switch (pmcsel) { - case 0x2: - evt_type = PMU_EVENT_INSTRUCTIONS; - break; - case 0x1E: - evt_type = PMU_EVENT_CYCLES; - break; - case 0xF0: - /* - * PMC1SEL = 0xF0 is the architected PowerISA v3.1 - * event that counts cycles using PMC1. - */ - if (sprn == SPR_POWER_PMC1) { - evt_type = PMU_EVENT_CYCLES; - } - break; - case 0xFA: - /* - * PMC4SEL = 0xFA is the "instructions completed - * with run latch set" event. - */ - if (sprn == SPR_POWER_PMC4) { - evt_type = PMU_EVENT_INSN_RUN_LATCH; - } - break; - case 0xFE: - /* - * PMC1SEL = 0xFE is the architected PowerISA v3.1 - * event to sample instructions using PMC1. - */ - if (sprn == SPR_POWER_PMC1) { - evt_type = PMU_EVENT_INSTRUCTIONS; - } - break; - default: - break; - } - - return evt_type; -} - void pmu_update_summaries(CPUPPCState *env) { target_ulong mmcr0 = env->spr[SPR_POWER_MMCR0]; @@ -238,18 +151,16 @@ static void pmu_update_cycles(CPUPPCState *env) { uint64_t now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); uint64_t time_delta = now - env->pmu_base_time; - int sprn; + int sprn, cyc_cnt = env->pmc_cyc_cnt; for (sprn = SPR_POWER_PMC1; sprn <= SPR_POWER_PMC6; sprn++) { - if (pmc_get_event(env, sprn) != PMU_EVENT_CYCLES) { - continue; + if (cyc_cnt & (1 << (sprn - SPR_POWER_PMC1 + 1))) { + /* + * The pseries and powernv clock runs at 1Ghz, meaning + * that 1 nanosec equals 1 cycle. + */ + env->spr[sprn] += time_delta; } - - /* - * The pseries and powernv clock runs at 1Ghz, meaning - * that 1 nanosec equals 1 cycle. - */ - env->spr[sprn] += time_delta; } /* Update base_time for future calculations */ @@ -278,7 +189,7 @@ static void pmc_update_overflow_timer(CPUPPCState *env, int sprn) return; } - if (pmc_get_event(env, sprn) != PMU_EVENT_CYCLES || + if (!(env->pmc_cyc_cnt & (1 << (sprn - SPR_POWER_PMC1 + 1))) || !pmc_has_overflow_enabled(env, sprn)) { /* Overflow timer is not needed for this counter */ timer_del(pmc_overflow_timer); @@ -286,7 +197,7 @@ static void pmc_update_overflow_timer(CPUPPCState *env, int sprn) } if (env->spr[sprn] >= PMC_COUNTER_NEGATIVE_VAL) { - timeout = 0; + timeout = 0; } else { timeout = PMC_COUNTER_NEGATIVE_VAL - env->spr[sprn]; }