From patchwork Sat Dec 11 19:11:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 523082 Delivered-To: patch@linaro.org Received: by 2002:a05:6e04:2287:0:0:0:0 with SMTP id bl7csp4108077imb; Sat, 11 Dec 2021 11:31:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwKfznO2n5ucBOHHWPJGCZBSn8MTIRn7LfJxGHDMtAIkcRdFWl6y+uuw+ZMaYgA/E5raqLn X-Received: by 2002:a37:68d3:: with SMTP id d202mr26478184qkc.70.1639251073052; Sat, 11 Dec 2021 11:31:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1639251073; cv=none; d=google.com; s=arc-20160816; b=bL4ZohVQ2rOcYKMRViCYNwDrGBkJ2HnfPUgsv4aNRMLJEWz6q2PCCwh2hbvZOIbMZU CRMDfcmWTJAAsBpktvBTe0uJBjYgmx5+lFHj2oHnNHBTRdLmFMTVqxqqDWCpzVnX7MoC dEUvI7Vao6CMOqWmIxSUkNk8cv9KGJpZBg8+tpMa4QqjPZhNES5Ewzt0P57a5WgVeF/h vKZx0CnU+HvoHDyQLdb9KeiFZnMSDCpVF6fvV8YH6KakErVPpm/GqtygTQhiXUb/OvIw eCtxr3NCK/RA3TCTYOMSE75IsSZucB4/CE+u/72dX0HFNs3rfup1nE8YHtKmkJyYCeXf 4QWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=svyDuO08plqqfke9+oyDo+51L/6esQWi/ZoR3/dgCe0=; b=HEMvAVPWkxhAIuexd2ByoyfYRxK9l6DCPr11xrfllPCYvwj99+Jo2buIONZDNHSFnR lM2WEyEKcIPIiF+UndXYWT6vUX4TbG8V9poLQPiRfDI/yC0XGzI5I5rtCPZysX56/Ukt VNYMtcFbExBz5zbLGTUasiE8ixnkVc0W+og+5KjRWBXOkooxBADVBNoFOqaEJ1bEYaEm v1bYmHz+060wLXqDRkb3vbeNHZMEHyPYATojcm82gNJPvPFBQ5fP5B9RnSBzL0TQirtm fDClnr4/eH18kgWI0rIyH2loeq0ziFJ8rF7fCGfL+FgS3gGpsbN714pR5ZMlqCUknjw7 mRCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=a3k3KJWu; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l63si6329375qke.539.2021.12.11.11.31.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Dec 2021 11:31:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=a3k3KJWu; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mw85Q-0006AC-Hs for patch@linaro.org; Sat, 11 Dec 2021 14:31:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mw7mo-00050l-Vv for qemu-devel@nongnu.org; Sat, 11 Dec 2021 14:12:00 -0500 Received: from [2a00:1450:4864:20::32b] (port=47025 helo=mail-wm1-x32b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mw7mi-0006GL-PC for qemu-devel@nongnu.org; Sat, 11 Dec 2021 14:11:58 -0500 Received: by mail-wm1-x32b.google.com with SMTP id c6-20020a05600c0ac600b0033c3aedd30aso8944598wmr.5 for ; Sat, 11 Dec 2021 11:11:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=svyDuO08plqqfke9+oyDo+51L/6esQWi/ZoR3/dgCe0=; b=a3k3KJWuEzvy1ztXgvlmCp4M6VN0cT4u0EzIb7X7ypAZ/kazvYKVN6Iea4o4C47BSe O8BP86150gTusj9Y2rITLpBKph03k7B+W9oorGVVyTPHjN0JdTIz2SC4AhVvkXrVfg7v FKj7eXin6J5URrNIUTagcXV0aAUZlqk3tnrl39xoR/obH1RchlqlAQVj7+Buo8UiFyWF kyXnJy7IbiDkILdAa74DK1rIqoqkqNylrUWqnZ+gtfS9OzGmTofY4l5P4mzT/sXexhNE BaFa1QkdqamgeBRtWN+IJAefhnb1qQcjkm2ASsfe+BkM3O5N5arQkhE0fq7UA6km5m91 GXqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=svyDuO08plqqfke9+oyDo+51L/6esQWi/ZoR3/dgCe0=; b=5z7xB4AwE1kLd1GCnyzECUjYIs7WB65G+eyhZPWuBJNCLw0HJpc4tVY5/vekORkzBx Xh/a9zZLYy2/as8nru0DirnnuNnPoPuCw39yX6FmEsDDWDU345Yj5qRHw1l5w2EnfAiD c/IbHbllgbn2DajOBvy7CKuERStCfQKmrdfjzvFnQ+bX/9gqwA+MwHFb0Nfhr9mIz1eh z/Dn/SpY3nPA3g5t1dxyjDZ0CHVvY2vzmUyRfQdq4fqcDcfI5VNRfaTLF8g4D0vc+yEv Pwj9/tqixMnwu2fL+fYChz9wGuBL2J2Zycar4ELe5Ps2AbAf2PH8xICUHfMge4JQbELd hrsQ== X-Gm-Message-State: AOAM532qKS9g9GDmLyIAPz7XsKK5+lBlgUeKS/iS2QVUu1oFQkhVxzfd YY6qpuA6E8dOYcIpgojIa1DTgA== X-Received: by 2002:a1c:a982:: with SMTP id s124mr20854494wme.191.1639249911294; Sat, 11 Dec 2021 11:11:51 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id m20sm2205300wmq.11.2021.12.11.11.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Dec 2021 11:11:51 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 18/26] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value Date: Sat, 11 Dec 2021 19:11:27 +0000 Message-Id: <20211211191135.1764649-19-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211211191135.1764649-1-peter.maydell@linaro.org> References: <20211211191135.1764649-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32b (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shashi Mallela , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" process_its_cmd() returns a bool, like all the other process_ functions. However we were putting its return value into 'res', not 'result', which meant we would ignore it when deciding whether to continue or stall the command queue. Fix the typo. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- hw/intc/arm_gicv3_its.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index e6b380f663c..32cf18c10af 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -676,10 +676,10 @@ static void process_cmdq(GICv3ITSState *s) switch (cmd) { case GITS_CMD_INT: - res = process_its_cmd(s, data, cq_offset, INTERRUPT); + result = process_its_cmd(s, data, cq_offset, INTERRUPT); break; case GITS_CMD_CLEAR: - res = process_its_cmd(s, data, cq_offset, CLEAR); + result = process_its_cmd(s, data, cq_offset, CLEAR); break; case GITS_CMD_SYNC: /*