From patchwork Sat Dec 11 19:11:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 523079 Delivered-To: patch@linaro.org Received: by 2002:a05:6e04:2287:0:0:0:0 with SMTP id bl7csp4105021imb; Sat, 11 Dec 2021 11:27:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHWOi2lmE3tD4rftpTZHXRNY3S2e8B3WCYuM2YOL53gPcigTTdF1vm9BvubpuPl9HJSTLI X-Received: by 2002:a05:620a:94c:: with SMTP id w12mr26337912qkw.190.1639250830386; Sat, 11 Dec 2021 11:27:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1639250830; cv=none; d=google.com; s=arc-20160816; b=zIZcwmY+7xsGeBq1ojGW4oX0xGo/20aqQMMWGsTBN8uCtSloTdC4R/OKnKG55fT30Y GNslj7x0NUP4kFuBj7qxOdce+8Pk3k/L+RhZrK12QEIWqEwqV5kPH5AW+XApYn/2rTvn 8pn5iCo4iQ5HZnHY38/sNVUMjjdqa8lP9f1LK1KZ8078KzjjWoL4dvdFoe8Z+UEKRxX6 c3+7oJAXoKX/OXHFuPlcSImvDUrfhTBUajhQb7zB4b7GVK/5Wm3x2VJeimXhW9FQeZmn BQ9Ci1pKYYP9grjN5cMCKmK3AjQagojCyXNdPjuY34tShN5376HJY9KiCvc7ZntqSDuw usBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=+/b7SIR6GyfeO3Rjl24BM+AWJSlXd6uCCkfVTpffz54=; b=J3vLoqsw/SbRdrWT9gWgAzEguJn8XiHLT2sGxyLG/Fca+PkB0QkREXdMpR9Ou2U/aS KXF32TSghHSMXOPWuQTV4WFaPzBCGq4y0OtvMTsvYncCo05eagJmeEHxernCNznbE3JW oA3T28RhwHHD/x1rhG63mq6/34zdwupu4Td7RB4SNgiBn6a8hZ+Qvx3lNJ808bRiS2s0 ww+DBrzm/qaJiJFmOAy/rOg3rlvRN8Ruga4W1iNwaJkzNZ29AGKORhPBT/1n0vOJLXn9 GHclD2TaAuBGzaqmxNW73K1dvODk4vheI6oxVl2lTJRkySX175crU4YQBxIQotOR7IPv yWew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XV3D5SLF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ke27si6208143qvb.260.2021.12.11.11.27.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Dec 2021 11:27:10 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XV3D5SLF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mw81V-00015f-SM for patch@linaro.org; Sat, 11 Dec 2021 14:27:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mw7mj-00050W-5L for qemu-devel@nongnu.org; Sat, 11 Dec 2021 14:11:58 -0500 Received: from [2a00:1450:4864:20::32d] (port=33791 helo=mail-wm1-x32d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mw7me-0006Ez-Q6 for qemu-devel@nongnu.org; Sat, 11 Dec 2021 14:11:52 -0500 Received: by mail-wm1-x32d.google.com with SMTP id r9-20020a7bc089000000b00332f4abf43fso8979159wmh.0 for ; Sat, 11 Dec 2021 11:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+/b7SIR6GyfeO3Rjl24BM+AWJSlXd6uCCkfVTpffz54=; b=XV3D5SLFtPCRovaseJujyrjBxNIEQNROmwdh2PDwaCLfv9yuug8va7qoIUN98c5EMo D102IERkyVofJzK2uFFGTniwU2CvI7abBmSJvIdAZGuNw/brbF6zOxZ7DcsCdzSHN7PG /yuENdUFDefspKCOO9RRbWYJ9fVRikILLT94NRs5/uAXD/zh6U614W9rCupzJheyETl1 Q91G5NU7jocEs71q08jUsAodx4Ad4GBqfqgpEwYW79j0ZEWnTX8Kh5AOecV2hubP5TZj 22lcHxq8q9Q2Ik/N9CwzPGo8ada7tXpepLwvBzt4curvh6G04mwHspGKIHbPhL8/S2vd g8XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+/b7SIR6GyfeO3Rjl24BM+AWJSlXd6uCCkfVTpffz54=; b=X4yFjkwep6JKvyAaIE1qhSlKdtlHp0/yv1K16e/s4Hc7yD/NHlxLYYkrMqghUcbG+M 5vzTeh91jTSr+XrBS1TpL1AzPal1g+6ebXjy61Yj47BS7gMK7XV3V+ytwIWXE/gzcUn0 9SMRyICIVGhyr3iOIAmyYYY6d1m+/o3nLD76uDarhYq+b/+EAam4wT5kVXI1q5a+eu4u hB8pLZYrgnGwJ45BYQAvGc1+VZPz+97AerOT9pp00UDPueYTVBix87aomiO3UR+arsSS F57U9bvT1HbPKnnU+WxnQC07fcDIZnENcGr+om4HWrmlzG4kzzwf3etOuBp1ro6iLKYU BRIQ== X-Gm-Message-State: AOAM530zISvFQEDOeZTTzPWJKt4SJaGV8H9YPZO27v5XjnVGwVgHmKK/ 7qBJR5bUjJIB0xZLMnP8dNqUIto0FGFXiA== X-Received: by 2002:a1c:770e:: with SMTP id t14mr25198845wmi.173.1639249907587; Sat, 11 Dec 2021 11:11:47 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id m20sm2205300wmq.11.2021.12.11.11.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Dec 2021 11:11:47 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 12/26] hw/intc/arm_gicv3_its: Correct comment about CTE RDBase field size Date: Sat, 11 Dec 2021 19:11:21 +0000 Message-Id: <20211211191135.1764649-13-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211211191135.1764649-1-peter.maydell@linaro.org> References: <20211211191135.1764649-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32d (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shashi Mallela , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The comment says that in our CTE format the RDBase field is 36 bits; in fact for us it is only 16 bits, because we use the RDBase format where it specifies a 16-bit CPU number. The code already uses RDBASE_PROCNUM_LENGTH (16) as the field width, so fix the comment to match it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée --- hw/intc/gicv3_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h index 6a3b145f377..14e8ef68e02 100644 --- a/hw/intc/gicv3_internal.h +++ b/hw/intc/gicv3_internal.h @@ -400,7 +400,7 @@ FIELD(DTE, ITTADDR, 6, 44) /* * 8 bytes Collection Table Entry size - * Valid = 1 bit,RDBase = 36 bits(considering max RDBASE) + * Valid = 1 bit, RDBase = 16 bits */ #define GITS_CTE_SIZE (0x8ULL) #define GITS_CTE_RDBASE_PROCNUM_MASK MAKE_64BIT_MASK(1, RDBASE_PROCNUM_LENGTH)