From patchwork Tue Nov 2 18:25:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 516702 Delivered-To: patch@linaro.org Received: by 2002:ad5:5208:0:0:0:0:0 with SMTP id p8csp4877390iml; Tue, 2 Nov 2021 11:42:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyW4W6Pm7RbR2uuwmyEEKgE0uQoQvRyQRzrLUf1xlfZyhagoOZg0pq5hyIexjlTuXy5BUjT X-Received: by 2002:a9d:3634:: with SMTP id w49mr21185043otb.84.1635878536178; Tue, 02 Nov 2021 11:42:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635878536; cv=none; d=google.com; s=arc-20160816; b=BGVJeMeHMEAfWJhjOALOTFnh8JOYuygETwMWeEp4VxDYmx+6pS6vDNrs/qU83rt2ei KNEtkTh5Z1c8SFsDc4pqG6svykmvC6Lpuh9vQ88d/xih7hUIAgPL/MiEkSf2Lj6/Bv5N WC3Wcmu7GOO1h9y8g3Y8o1BWYd4IJeWG308KO+6oYplAgR5mqkN64qS+LzW9Cb98Vu7T YxBw6V/FMau7Z8RFhYV+rwoPqvTpr8lr6VEKDqu1v5fuWxXV7Ym11mY4fDJBztAao/lm cRY6o0G1DTmVrYlIsOAeyJp3oBnB4bTOpSnqxoBRGotEPcCAuYk3DT4bAaocnHCMSVEn Imaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=GgIC/L4O3idafA92xVJBzxSWcbdJlwK/CFRWNxE3FH0=; b=fP2k9zRTtv9MmVpJaN8VGqlP2blG44UgPr7ObCjIkjMcmCF8hVkl8O4rAvyfnOfkvA YCdEROOkCWgyhDw9+sN7XJenWrywxKA9wrDCEFWLJ8seXrXn9PI+6NVvc6BvnjPyqnXp 1KIXfDLFqUyJS4nwuIri23Guh14G8OX4guhyV7cDPaQO05Jp3aDZNrzz1sPMRL4U2GpB VjezBlA+SS/i5q4li0HE4NRduLo2aOksjjkaEDbqtU1mvhmBFCd4rbQA7Br6CZJImUiZ 1nmqqB1uoTYjjBkFk7Q6f3JEa4BeOR8Df7x3+h7Ssxy15YANOkS/JM/RU+kOt6umifYW XdNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LZsccg3X; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m5si17383150ote.293.2021.11.02.11.42.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Nov 2021 11:42:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LZsccg3X; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhyjf-0006dd-MR for patch@linaro.org; Tue, 02 Nov 2021 14:42:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhyTS-0005nk-CT for qemu-devel@nongnu.org; Tue, 02 Nov 2021 14:25:30 -0400 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:38406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhyTP-0004EP-TZ for qemu-devel@nongnu.org; Tue, 02 Nov 2021 14:25:30 -0400 Received: by mail-qk1-x729.google.com with SMTP id bi29so20509552qkb.5 for ; Tue, 02 Nov 2021 11:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GgIC/L4O3idafA92xVJBzxSWcbdJlwK/CFRWNxE3FH0=; b=LZsccg3Xc7wmOm3sdWUkKJSa5jgdicBF5AuuOODmBXXxwi8KpZD8eMCuOZAM8jB/3Y 9mySbsr9fKI7cngLYOWn3RHRLch58rOu4aDruI4w4IE+8ydIhCIQHbMfZ6r3eh/Eqj2p VVz6VU4YVJoDsk59rxbiDamv6RtGdGdjbgTWP1qGhPeVKyHtK24uN34Q9dI7qx/XP8eZ /8kMiuQVi8uqOxKcOWrgosXekakKwckxcE4nrtxxrnH3PRjgpd/9LrklTwZMuNjvc00D 5ON1StSpoNazuOTAXm4tVHq2qNbLrD6oGhe0CB4QatNWMjEfBeP6Bbjv1a05ckrXeVzV V5Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GgIC/L4O3idafA92xVJBzxSWcbdJlwK/CFRWNxE3FH0=; b=AzK0aE9EnNOmHB9Hg7H1ywZ04UHmRmU3iyV2tuw/mgEOiG4WvMafZihTPWUk901exM fzaGFFixmlrMAhVExlhBfa7Oy/0IJIWDyiN6tNmydcRkKnKAQ+A6OaHiFZGhZOueM9vO /FYN/IDzquWdJWHEK7lhSTjBpvJ9YAUtvQmv6yt0tIKVr3vt5P0l93tnPAFfkaswruRp AqlCMBN4YG49tg0MRGpDF1fal+8Gz/AZJLh0mT6/RHPRI+Q3gFvCzMxRB2nVlUXh8v1l VRs58GrJbh/ganGraCvwPayBxXAsuEo72TayWAM3hyi3JPbcxOSJYSc5v8EdS5MMdDEx kMpA== X-Gm-Message-State: AOAM5315dHXei9yzqoIMMBboBjA8x5b16lVDdRnUp167ua4g3QB4LvXG qHX4huNA06lO95YESi6MVnP83ZMpe7RXcA== X-Received: by 2002:a37:44ca:: with SMTP id r193mr31134365qka.190.1635877526996; Tue, 02 Nov 2021 11:25:26 -0700 (PDT) Received: from localhost.localdomain (rrcs-172-254-253-57.nyc.biz.rr.com. [172.254.253.57]) by smtp.gmail.com with ESMTPSA id y9sm13701081qko.74.2021.11.02.11.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 11:25:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL v2 10/12] target/arm: Use tcg_constant_i32() in gen_rev16() Date: Tue, 2 Nov 2021 14:25:17 -0400 Message-Id: <20211102182519.320319-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211102182519.320319-1-richard.henderson@linaro.org> References: <20211102182519.320319-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::729; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x729.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Since the mask is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211029231834.2476117-6-f4bug@amsat.org> Signed-off-by: Richard Henderson --- target/arm/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index 52ba562c96..98f5925928 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -388,13 +388,12 @@ static void gen_smul_dual(TCGv_i32 a, TCGv_i32 b) void gen_rev16(TCGv_i32 dest, TCGv_i32 var) { TCGv_i32 tmp = tcg_temp_new_i32(); - TCGv_i32 mask = tcg_const_i32(0x00ff00ff); + TCGv_i32 mask = tcg_constant_i32(0x00ff00ff); tcg_gen_shri_i32(tmp, var, 8); tcg_gen_and_i32(tmp, tmp, mask); tcg_gen_and_i32(var, var, mask); tcg_gen_shli_i32(var, var, 8); tcg_gen_or_i32(dest, var, tmp); - tcg_temp_free_i32(mask); tcg_temp_free_i32(tmp); }