From patchwork Tue Nov 2 11:07:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 516668 Delivered-To: patch@linaro.org Received: by 2002:ad5:5208:0:0:0:0:0 with SMTP id p8csp4433685iml; Tue, 2 Nov 2021 04:51:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7Y5hlHJ0+lFOoYGWkuP5Yonf14UvY3K2N8q8qnkuDXywGpXVt8QwxJoXftH71p9fOOISa X-Received: by 2002:aca:674a:: with SMTP id b10mr4699659oiy.60.1635853889549; Tue, 02 Nov 2021 04:51:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635853889; cv=none; d=google.com; s=arc-20160816; b=DVfe1isGeG7rk5nELXQ7ESwnE8BRAW4DIDFSa7wepdHLWCvnKRWiuy3f1h53klpS4f IqqMgA32Kr1aVb4FMGC9HD/NSG3oSoYW3wYk9GSySiUpnv8g1hdgI/E7QcOk6stOz388 WAS3IrBWofurmdqiusaqODMDs8v3AfrUjnF3NtdtuJeFN1XJVFfEm4FuMi4BucTIzHuZ /dGheEy29ER+I5lD7exQMcjECVPftn0CIC2aCefNctG5CUwQ8Rx0ooMlA+/33iRFb6ma DE0JDNGkNKX3Vu9bsdAb3UVZ1o5UGocmqpJ90UiU24ICwUzSRybDi6kpZ8nQPNdPPSgj fEOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=fst8PPiKYis4JToQFX+5Qan5hw+M0FHWjD02ED067j0InfbFC/mu0PjU1fWF0BsY6p zoGNdyX/YME8CfRYzg+Z9BLNlRN4E07MDXpKp98/cSdPytaGwmjxoY4ZAzZ7lPpdqwfw B5LpzDCvZRuPbxM7ylXrVkOc/ljVlpwokvuv6yiLcvqnCfk1PBwD/hSdmLfuk3GOjnns B3Pk+VeQwCwoxj3RuxAcSSjJ2KxmEl6CXOBWVgkF3oTeIsjOBXPOFwWu0hXNQhi4/Fh7 KMJH6SGP+XvWUzrl55sEeVtyf8q15JNt56dFu2CDCOEQJGigRZb2bY+/xJr95wYS6iC2 zW4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Usx/HpVA"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o5si2378407oib.96.2021.11.02.04.51.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Nov 2021 04:51:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Usx/HpVA"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhsK8-00008i-UX for patch@linaro.org; Tue, 02 Nov 2021 07:51:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhrhD-0001cb-Uk for qemu-devel@nongnu.org; Tue, 02 Nov 2021 07:11:19 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:44756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhrhC-00020Q-Dw for qemu-devel@nongnu.org; Tue, 02 Nov 2021 07:11:15 -0400 Received: by mail-qt1-x82f.google.com with SMTP id j1so11238106qtq.11 for ; Tue, 02 Nov 2021 04:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=Usx/HpVAgrQX+OlK893iSPRF+0iol38QPXU3Hy/cSAXJKSBhhpYf0L+mzNS1/CugTV AAqvjPIN9SfJd8k9MqrHPzp06BOnZ+PyWMiEQ3HtUGZ3S7Tz7T1cHBTdaea0nQ+0ghgT p3Mrdj6todbzIq9G8qVLVeUclTeksXRY9BNscMZuOPFrnMvoAnNKjkA7haDl8VZAhH4E gCyLvKMWgmYFV+9WZDqrGncN++YCdAEIfxw9ogTFm5Iso5YUb+yJEBJzlyn4s1rDFwQm NFYNCmsEzlYmRorr38xJYHrihEqUym5UKgQxlRZI46/Y+8r3fu+/2do4DuNuDegtyDTT SBzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=imZq+Ut3Ty8IG76N94iOrmEr4zLbc3Z+iv615tl2m0znlA0Vi+dABnNr+QzxsmU7ZX cWMLLkzoX11WN+jNstV2VBQeNeNBQWKsFR5+NurKMfIFgJO7i/60QJywmLwyIx0d1pDT w7Obarq1KRsFJ/QZsVy6oAcowfRXeFuRWgdGhzoJIcYMsFrVhbnN1n5oYsTAvpO+54p+ Ku/V2r019osSVblE8GZ405E6/itIGZHDypRIjdmNWDuvkDUw8GaaBfxjAR5C0kR8xsGI iIi8dP8L5s4D/jc4HBRfTWORlBc+Bxu1l8Poseo+TFVzuwXPqjeYb+2ZOhTcS9S/j6C6 8BPQ== X-Gm-Message-State: AOAM533g54jXSHZHyU1Cix37dwZTvVwyy5QUDkpb/MtPllBROsdzNTGe d1FyQ9m+135adIRJ8hPYR0u7Y91ihQhd3Q== X-Received: by 2002:ac8:7a82:: with SMTP id x2mr36678971qtr.260.1635851473569; Tue, 02 Nov 2021 04:11:13 -0700 (PDT) Received: from localhost.localdomain (rrcs-172-254-253-57.nyc.biz.rr.com. [172.254.253.57]) by smtp.gmail.com with ESMTPSA id bm25sm12730854qkb.4.2021.11.02.04.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 04:11:13 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 54/60] target/sparc: Remove DEBUG_UNALIGNED Date: Tue, 2 Nov 2021 07:07:34 -0400 Message-Id: <20211102110740.215699-55-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211102110740.215699-1-richard.henderson@linaro.org> References: <20211102110740.215699-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=richard.henderson@linaro.org; helo=mail-qt1-x82f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The printf should have been qemu_log_mask, the parameters themselves no longer compile, and because this is placed before unwinding the PC is actively wrong. We get better (and correct) logging on the other side of raising the exception, in sparc_cpu_do_interrupt. Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.25.1 diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index bbf3601cb1..0549b6adf1 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -27,7 +27,6 @@ //#define DEBUG_MMU //#define DEBUG_MXCC -//#define DEBUG_UNALIGNED //#define DEBUG_UNASSIGNED //#define DEBUG_ASI //#define DEBUG_CACHE_CONTROL @@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env, target_ulong addr, uint32_t align, uintptr_t ra) { if (addr & align) { -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, ra); } } @@ -1968,10 +1963,6 @@ void QEMU_NORETURN sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr, SPARCCPU *cpu = SPARC_CPU(cs); CPUSPARCState *env = &cpu->env; -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr); } #endif