From patchwork Tue Nov 2 10:59:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 516623 Delivered-To: patch@linaro.org Received: by 2002:ad5:5208:0:0:0:0:0 with SMTP id p8csp4393211iml; Tue, 2 Nov 2021 04:09:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLBkBmSa1gU4eanRCThsk071U3lJbsVVvrnV7BXBWtc81SafZ3wial+iY3PBD2hTWVZioe X-Received: by 2002:a05:6808:30a3:: with SMTP id bl35mr4401119oib.77.1635851376185; Tue, 02 Nov 2021 04:09:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635851376; cv=none; d=google.com; s=arc-20160816; b=lAN5PkKu7Sodz5PZFe+6AGyR0adXg9j/KCCiEgTOTlSuhj1J/sWs6k43O8OBbh0qx3 uE5tbNiPxxWJfutHUBod7GFTKBZdZKAVc1lED5bZn0Axwqf5UVukUeVcMzjb+Cr0QaDt Bg69+C1lF6u2L174YcjQ9+P6v5NxoaWgEIsKEHQ25kxa+bBGploSBmZDtR+uO8W9ootO MO+gvPtda5aj6VSCHGuTfzyxsueZ2itl/723WhREL9JKADYth25aZtkeTeF7Vxk5QrhL 9CV0JOfJAymJeuEriKnoE11V/eAojWfqeXNGZ7ga4/11Z9IltM2PMiarNf9hx9d6esN7 PR0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=5cdNvFSJ5wR7JnuiQcjHWFGJQar8vceYVcWEUN+hvfs=; b=ViR9x7jOuoMgYDhTnF283fQSLfjnShlLdnXpoHGXzKL5MdrxfyNY5KS56kg9gzh4Vo 1M3y/6roxMdKApHrS/IfW/zie3J1V9gchNHjupnMq3vf2agS7Km3DnBzCZbksSElCAsz 1/yVuRuGZWzC0GcA9/0Yc2YyzqkHgVJNF2ivh++YxwDiTb1AaCGIMQ2BxDaRbH+ioN/z WjJO5KHt9m5PgMxcz0tMpU8M8GQh4uqdZCqEd5OYlucBY7uhVmcM1FapwwMVpHg5fD7G CdeewcvreNOiTg9IA3Sp1k7rU80gXd2djLEoF7TXU3ESDkt8oATaNlsiYRYnLk1TlD3B Tr7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=R0N4J02A; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q8si11300282ott.157.2021.11.02.04.09.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Nov 2021 04:09:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=R0N4J02A; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhrfb-0003aS-Bt for patch@linaro.org; Tue, 02 Nov 2021 07:09:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhrW3-0007RL-5Y for qemu-devel@nongnu.org; Tue, 02 Nov 2021 06:59:43 -0400 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:36501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhrW1-0006ra-Pq for qemu-devel@nongnu.org; Tue, 02 Nov 2021 06:59:42 -0400 Received: by mail-qk1-x72f.google.com with SMTP id i9so18667574qki.3 for ; Tue, 02 Nov 2021 03:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5cdNvFSJ5wR7JnuiQcjHWFGJQar8vceYVcWEUN+hvfs=; b=R0N4J02AVwpi3erHg6YVQNU7idMdJURf9oPGwOVBoRYJkR7ib0fRaMv3Jxm/S3btl2 08J2ck3z39XEG9IedTqo11liSEbYNfAM5gGuQvbf0NiH42LVXlBOGt5wWESzOGAbD9KC ZlboyfRnueLfqQz7JWYb9CUllw09lHr5N15jR2gEvvQcKkYZiNeIlWfiNmYZrBeKRPSB wTmXrF2XkJt0WqsGgAZOgoNf6mwoLGMqYP7PWUW3Jn97w4FV5lzxCLcOy0fPfFGL//9t is1muJFCq7osFjoKB7xIT8MVb5SvktQ/R/HXhmUFy3PEw7LySBE2DUH+JKTRvk/WA8lP zN1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5cdNvFSJ5wR7JnuiQcjHWFGJQar8vceYVcWEUN+hvfs=; b=ctegOxrQcDhmoAfwJnY/rUkwYEruxh+HoYWOu8yvmHJxyRkdynbih2falxU7tZhoc6 yD0p7rqnrSIvgkFWOzoLrtTO+VCn2lWQIHCbiA4vn8/emp7BTGPY9BrVtlYKf8eppFsB nxxlAPHbebRPBX2jVHiEs5AsoVLp60fh6JHfdla2ANdTkqafWHaLTtBauN6vK91BTXti Pr6XxYhSmjhvsnm3lKHpgz5BKWTYnnjSgGSbmH1qEvs9kLFc1ejJDtPiUw7WXYuWVkcK CMbYNt7FzP0trLJvrfs4w0KWLF8PPAqlRB+3zHOqux/uKgQri0tFqaYEXfEJ0ZHcZrul ogDA== X-Gm-Message-State: AOAM533BIfZesg2q6qtMWeMud5cG3646Frs9XFTrfkGLMYF8Jy/1brwH 6PdSGG7VVQtx2L2559SAmhZAzUxwbhI0Hg== X-Received: by 2002:a05:620a:318e:: with SMTP id bi14mr17284924qkb.439.1635850780883; Tue, 02 Nov 2021 03:59:40 -0700 (PDT) Received: from localhost.localdomain (rrcs-172-254-253-57.nyc.biz.rr.com. [172.254.253.57]) by smtp.gmail.com with ESMTPSA id z26sm11789510qko.13.2021.11.02.03.59.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 03:59:40 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 07/12] target/arm: Use tcg_constant_i32() in op_smlad() Date: Tue, 2 Nov 2021 06:59:29 -0400 Message-Id: <20211102105934.214596-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211102105934.214596-1-richard.henderson@linaro.org> References: <20211102105934.214596-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::72f; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x72f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Avoid using a TCG temporary for a read-only constant. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211029231834.2476117-2-f4bug@amsat.org> Signed-off-by: Richard Henderson --- target/arm/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index d6af5b1b03..083a6d6ed7 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7849,10 +7849,9 @@ static bool op_smlad(DisasContext *s, arg_rrrr *a, bool m_swap, bool sub) t3 = tcg_temp_new_i32(); tcg_gen_sari_i32(t3, t1, 31); qf = load_cpu_field(QF); - one = tcg_const_i32(1); + one = tcg_constant_i32(1); tcg_gen_movcond_i32(TCG_COND_NE, qf, t2, t3, one, qf); store_cpu_field(qf, QF); - tcg_temp_free_i32(one); tcg_temp_free_i32(t3); tcg_temp_free_i32(t2); }