From patchwork Fri Oct 29 04:33:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 516410 Delivered-To: patch@linaro.org Received: by 2002:ad5:5208:0:0:0:0:0 with SMTP id p8csp410345iml; Thu, 28 Oct 2021 22:06:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6SVz53IhvA3NcVMhDaglOpRCkHzLWKjsSm5DmtqtKMq5aLrLE4Pz9oehwL7khme6Qtsz1 X-Received: by 2002:a9d:4e9a:: with SMTP id v26mr1367429otk.336.1635483994713; Thu, 28 Oct 2021 22:06:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635483994; cv=none; d=google.com; s=arc-20160816; b=QqJrGYyQLdLxegiFOW10yTbd+J3EIVThkL4HSaWdk3xZQwDKBDxKLNSgImeC8XbdiV KeY0rwtooMziebKjZrz+sLiFo3UMc778Hm4M2mfFJVFs9rzbvJ9ta1lzNKXKFDJ2SC0/ PHg7EIiG0TWMlxKOUrE89k9aEf7pM50JbYSCcToEK2CqJ9/8F4PFZVPOVkV2GMbvFnRQ aNvR2aD8/6HwcEmo6awENO0QKKpst1lKc0UYjwTsABiFvpUgrqTYbBttFYdo06JdrAZD s6AOLKF5+vj2gLbCTcVSv37dzJ29xhbgFenj4606MbPXhGJrXVZf/VLtbpGbeeephUr8 INDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=p9nAuHbLddeYpLBlIUYDAM/D6SQqxNNj6qaNtq7Jlaw=; b=qrh4oefiqSEwMLuI34Qh3nVcqEMSaos6evBJUPzcCiL9i/LKmLGDiL3Ja7k/NDitLB NhdGUKeS/wabbWFDYF/VF/9zGDrW7Cb3NukosYVfpLTJAbH3byODRq9GGGdLi3lfr4Hp ncvit2gLcCDwz33weADFUiMeXKIQqaDf5H57Gu1caiXnqfkodm+sm4L37ylMvRDyIFs8 e67ZDmrKrlOCBKcBTYC6zjDwFWEBOIyquyPTy1lXveCkdPDCJVTcgcGIL0mytjzYy1g4 0yRMQh+BgndIYN1bkxGETgFoCWQ1seu8rjTBozFklYW9NSF1qTW1INrHrgnQb3MHwnuL mM4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hiWXlvSr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w11si6963676oiv.112.2021.10.28.22.06.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Oct 2021 22:06:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hiWXlvSr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:55626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgK66-00010Y-0b for patch@linaro.org; Fri, 29 Oct 2021 01:06:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgJdl-0002X8-SI for qemu-devel@nongnu.org; Fri, 29 Oct 2021 00:37:17 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:45726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgJdf-0000MV-S0 for qemu-devel@nongnu.org; Fri, 29 Oct 2021 00:37:17 -0400 Received: by mail-pf1-x42d.google.com with SMTP id p20so2845608pfo.12 for ; Thu, 28 Oct 2021 21:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p9nAuHbLddeYpLBlIUYDAM/D6SQqxNNj6qaNtq7Jlaw=; b=hiWXlvSrk7KxCaKwklWj+mlvZNNCAu5Ur5NdKK8rNCmddPMomGmCiIoBHQRH/ti4CT +hd5Sv0afVtiIHvscLxQXqxY5iGg7dXxL4Lh9EEwK5KT/xsVcpFUqFPVFgyo3RDm/0jc b2ceKTVj/3ODCgurm3KI8mIkz6GmvSDuddUqeYci+ce4wDAcM8I8LyD4oH1rGlu+wCrD ksUJ4rjp6A2J982RLIWVww0aDQD4D/1gR9IusQ/ARODVhgUW1brHZDsMk0QTqyv24/LJ jWDTpTnZZJUY1ljy+Ub4rAEdYMWu8xcfa6tl0XP/rsg0BwITr+k9XHaXSmeIA9xWQ86I IjKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p9nAuHbLddeYpLBlIUYDAM/D6SQqxNNj6qaNtq7Jlaw=; b=Bnjk37HP+SvFYOmK25AXgWZ9GuL7CiPrraZDKmFG/Jvt+DZWswgDBs+y+4sWdhJ6Zy 5+7VseMcXaL1R86+1YFnxwicUTP3Ux+Sq7DfNJKHYWVEPqMG6J0CIFksomjDk0slmSwL HZgoHXdTv9LgNIXor6P4986uGw36ZTuhyJa85A4vzxXev6VKnJRjk3lDBxcRKtpl9y38 y1FmOhRmHXAPzm1pg9+r6MolTpq/0/u35SmkAwz6yGx985/Z1wWJhQHtJwxi3Pd0quEW WqzxoTYiVpWhsM9vsfDYv1cTtCV5fBkVr+GazTWXJqpruJh7MN7V+RYvvL0lfXQvsGSx VJqg== X-Gm-Message-State: AOAM533sEsE8iX6Rp3JeETqwe8V6cV2/Q+sk4sY9D8xuAzK2pEPhLb8y W15N7QL/OhTev0WqSaCZJeu4Bsg0FgOXkg== X-Received: by 2002:a63:18b:: with SMTP id 133mr6344166pgb.156.1635482229054; Thu, 28 Oct 2021 21:37:09 -0700 (PDT) Received: from localhost.localdomain (174-21-75-75.tukw.qwest.net. [174.21.75.75]) by smtp.gmail.com with ESMTPSA id b8sm5228232pfv.56.2021.10.28.21.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 21:37:08 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL v2 47/60] tcg: Extend call args using the correct opcodes Date: Thu, 28 Oct 2021 21:33:16 -0700 Message-Id: <20211029043329.1518029-48-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211029043329.1518029-1-richard.henderson@linaro.org> References: <20211029043329.1518029-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Luis Pires , =?utf-8?q?Philippe_Mathieu-Da?= =?utf-8?q?ud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Pretending that the source is i64 when it is in fact i32 is incorrect; we have type-changing opcodes that must be used. This bug trips up the subsequent change to the optimizer. Fixes: 4f2331e5b67a Reviewed-by: Luis Pires Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/tcg/tcg.c b/tcg/tcg.c index 024a22cf39..6332cdceca 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1508,11 +1508,11 @@ void tcg_gen_callN(void *func, TCGTemp *ret, int nargs, TCGTemp **args) if (is_32bit) { TCGv_i64 temp = tcg_temp_new_i64(); - TCGv_i64 orig = temp_tcgv_i64(args[i]); + TCGv_i32 orig = temp_tcgv_i32(args[i]); if (is_signed) { - tcg_gen_ext32s_i64(temp, orig); + tcg_gen_ext_i32_i64(temp, orig); } else { - tcg_gen_ext32u_i64(temp, orig); + tcg_gen_extu_i32_i64(temp, orig); } args[i] = tcgv_i64_temp(temp); }