From patchwork Tue Oct 19 15:24:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 515973 Delivered-To: patch@linaro.org Received: by 2002:ac0:cd8c:0:0:0:0:0 with SMTP id d12csp843742imp; Tue, 19 Oct 2021 09:44:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyt+H0a3nT3DVIEd6k6Hz4C6z4e0MLfY9e51hCmP05reBGV2TYGgG222B4op5F/kTf3SvPm X-Received: by 2002:a9d:6159:: with SMTP id c25mr6114533otk.286.1634661868748; Tue, 19 Oct 2021 09:44:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634661868; cv=none; d=google.com; s=arc-20160816; b=WGS4AVZ5fMFaxdvSNcpdmkFk5/6BPU20coVgo3P0DTYTMwsKKxx8IOjxoRzT36mcUs 7gCFeBtiiML1Dra5TXltgTFKXKs438AKXqsnJrz47mVQLAHG7YC3qNvyk6EzJh0b9gvb CSQ50BcSJ+HTnyfa/6lTbo5aJXi0HQRWN+rYo2v0PKxQN9BO8ovxb1ONc+BHazqPGofC vw00aypcYsZ6Qpx0L6IgCJCrU1pwBfnVZRAg+xDWOJdD+GmvHcfJXQPH1J7WKJyNed2n tVWTTNF3satK8rst1iKnYzidUB1R1UPrKvalzgmRXc+6HP6bQDDQOeh/Sw6ZduatoXZq xKHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=VHU6Zq495CGWvucF4SFdns/LDCGAVtayMjBnfRKFC6c=; b=TzIGIxxy5pxR6XaDDf+2WGUufgw6gT5cfTBOZ1pK21lHiWnGT+gTbyeXqDI/6b/fSz w2v1DBSrxyvQUtf324dsw9fYygFefcmX6xlbF9LXKMSj4UG2vNXH94ru8dN9ga4yUOnm xJbmztSaffJz9vWNVLII2RK2kSUyqDQ4sCWR9ilZ62sJRDVOGA8CYZrv66gH1nRD90UE mpuJC4HCkWWALgY2veFXytlr7wtEcCKBq+OghYiZCK1xe6XvhqnRMlgiTGZeg6PZF0dO Gq9+4BZzkCjO0N10y6jENK2aBPMYR2ib6Qhz6aKYs/YiBUuTSjojR0rflMrOH0EHPHSX ShGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LHWFzxp4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c130si17532739oia.285.2021.10.19.09.44.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Oct 2021 09:44:28 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LHWFzxp4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcsE0-0005BP-3M for patch@linaro.org; Tue, 19 Oct 2021 12:44:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcqz1-0005BC-Vf for qemu-devel@nongnu.org; Tue, 19 Oct 2021 11:24:56 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:40783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcqyu-0007az-Pd for qemu-devel@nongnu.org; Tue, 19 Oct 2021 11:24:55 -0400 Received: by mail-pl1-x62c.google.com with SMTP id v20so13893785plo.7 for ; Tue, 19 Oct 2021 08:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VHU6Zq495CGWvucF4SFdns/LDCGAVtayMjBnfRKFC6c=; b=LHWFzxp4yLzmUteDIi1yQFWLmsDtrasHrtgw8oFYMeJMoNUCWK7waiWhe+MvD37lqr v0Dir3kqP5qK97qB1x6QJkeeZLzBVWZkLaoDP6G5aGCObs7IsenuDhIGXrCSx5GLIctk dFx82qN9K5Q8u7vKpz53rV2lPPD4pbiILqmxt27JkFIqV2TS98AjSj6FIJcaTfz2INE+ lvazd3roLgqm9fJqkwG1t5zSllK5pZVSIwXKCorCkFfiivF2BMJO2XrPUCRIHAUElfRZ plIT/SjzOYjod7HEthqy0Yx9igSLlwSVN3/kQbgFIxluosxAFiX/l2BRaUqN/4N+jBng T8QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VHU6Zq495CGWvucF4SFdns/LDCGAVtayMjBnfRKFC6c=; b=rJNoK9bueDAjO4mXKckPg3TZgEivS/t3btxQVsEl25k49VMdOTCKn0Wtlp5myk8kWT paZCEZ9VuaO0xzzO+vAnfCnbO40/au7mzGQ99xoBvpZC+mzNLBs/XODPH95A9puaw5w0 hPGC3kFRT4Yrc057G6iMYf3xSdCbqD9Rt0t1q8eL7ZM95kNAYAz3pq/N6CfTVbVe9mFe 7qBwjCKvxAF9YxJChR4K8o2hrcP+fY37jPCL3vyb/DH5u6XHFlrL8vv3CCNgr7nGKAT+ J1jawMTKJ6+O1FFi/4mh4UKJYyPPFrJEXhgRgC0rxtINx0XpCD5af0nEIhBHcEO2VBjb uCBA== X-Gm-Message-State: AOAM530zLnVtbTLiKvHa5OoCiXLr3Dvq6kCJZMbUzje3fgNqj7Bk8WEF Ik3HV6mw+w1194S6VuHKgbyFKKdkX/I= X-Received: by 2002:a17:90a:7e90:: with SMTP id j16mr448683pjl.139.1634657087519; Tue, 19 Oct 2021 08:24:47 -0700 (PDT) Received: from localhost.localdomain ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id i2sm3293814pjt.19.2021.10.19.08.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 08:24:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v5 11/16] target/riscv: Adjust trans_rev8_32 for riscv64 Date: Tue, 19 Oct 2021 08:24:33 -0700 Message-Id: <20211019152438.269077-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019152438.269077-1-richard.henderson@linaro.org> References: <20211019152438.269077-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair.francis@wdc.com, qemu-riscv@nongnu.org, zhiwei_liu@c-sky.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" When target_long is 64-bit, we still want a 32-bit bswap for rev8. Since this opcode is specific to RV32, we need not conditionalize. Acked-by: Alistair Francis Reviewed-by: LIU Zhiwei Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvb.c.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c.inc index 66dd51de49..c62eea433a 100644 --- a/target/riscv/insn_trans/trans_rvb.c.inc +++ b/target/riscv/insn_trans/trans_rvb.c.inc @@ -232,11 +232,16 @@ static bool trans_rol(DisasContext *ctx, arg_rol *a) return gen_shift(ctx, a, EXT_NONE, tcg_gen_rotl_tl); } +static void gen_rev8_32(TCGv ret, TCGv src1) +{ + tcg_gen_bswap32_tl(ret, src1, TCG_BSWAP_OS); +} + static bool trans_rev8_32(DisasContext *ctx, arg_rev8_32 *a) { REQUIRE_32BIT(ctx); REQUIRE_ZBB(ctx); - return gen_unary(ctx, a, EXT_NONE, tcg_gen_bswap_tl); + return gen_unary(ctx, a, EXT_NONE, gen_rev8_32); } static bool trans_rev8_64(DisasContext *ctx, arg_rev8_64 *a)