From patchwork Sat Oct 16 18:14:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 515883 Delivered-To: patch@linaro.org Received: by 2002:ac0:cd8c:0:0:0:0:0 with SMTP id d12csp134622imp; Sat, 16 Oct 2021 11:23:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxriEjUsxil07MjDUqverACdFiZFSMNm8Xt4Wpaw2NwDdK8VbMLzviDTOozqVVQMct6U4f4 X-Received: by 2002:a25:5f46:: with SMTP id h6mr20512402ybm.209.1634408620281; Sat, 16 Oct 2021 11:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634408620; cv=none; d=google.com; s=arc-20160816; b=xUT/LqXHq5OSVh8JXuwSyrjPI9/NGYrKPt6e+783GU/vBbrqW9b6McoegPxv0QWZyx hREFJUQFA0sWUmhrWiqznnU242qSyGKL67igLsiHx7awTEFmXEiWQLQWtbxB/Vs7joWa PzRhR7Drg2+9mlFYnenCqNOuLBmZ/HJqPLR7qsAcGz+KUWD56S3p8UghkpcV9O1UpUkj Oz5PcfOsL8eR7v8b/rSh5DLevDgoSsVnb+0+RH9c0w0+sgqwldydLHEGn3Qe2+OjfClB hfyXDCQ8OnQTTximTwuqwb7T+A8OROrXo7/CJhAGuQlApUFTSvNW5HhGP4/1Uxgq6JHi gvnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=l8F0yKfEV2474L4Ct30BbTSDAfxIN/YXChfrODh7eN4=; b=x65O9SMd3DTYfXDdkfktMsD1n9U2/o7Equcn16d14+GayIw27GLIb7a5VFlkS/WxLM 8tk7OHiqMeCoXJdujJROS2HLUsY5HWQJkp5EZAPxLFRHYdtKFefxQMLia75MZ9my9iGB t5oXDx6wI/H2E8WPeiaMjSpFU3nlGJc3Xai9dU91ookQPYfPgNNouH2FiO1OQE79tHjk EsJOZG6jk+q90kx303HAz06gcs/SwEpyw1UpO5rqvZGrFdfMdFzun034DG/pwrsKjcoQ 7JCF5W5dTptFD2VrkrZyYsSp7eHbCCxrBcagSyDH0F1OPxsBWlkA7JyJdW+IWQy1s9+W 8Mhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZHTAsCbf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l22si13186752ybj.387.2021.10.16.11.23.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Oct 2021 11:23:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZHTAsCbf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mboLL-0003G7-No for patch@linaro.org; Sat, 16 Oct 2021 14:23:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mboDT-0008Kc-CD for qemu-devel@nongnu.org; Sat, 16 Oct 2021 14:15:31 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:47041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mboDO-0001vN-Cb for qemu-devel@nongnu.org; Sat, 16 Oct 2021 14:15:30 -0400 Received: by mail-pf1-x42f.google.com with SMTP id i76so9121253pfe.13 for ; Sat, 16 Oct 2021 11:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l8F0yKfEV2474L4Ct30BbTSDAfxIN/YXChfrODh7eN4=; b=ZHTAsCbf9K9kTYJJNR9Cbexq581ns+5OMuaykQZFeHCGPoYMOs30yADt7SmD6e6ZaF gNo42PY7IgT93YXh0yJc6VivTS4dotGo0vpxyHSsYvGcTpRVGPVUwlbEWhnCfAl3N6ql u8adFPDOCXDesslnjul4VT4IjE9yFuNdjgZEkFGNXhUSDDM6tPPgJoqCBoX6Rswxgwmn IQS1QlUj4xTjZibBENZsmXHmCp+CHlqCxDAJnW+fVjAsjAHkx9pelsNPGNaNybc4r4Y1 fJOmfswCtkhovsAzPv28HX/x7GHFoDdChXj34WxRF5k2aBsHuLfkRkci7J7bHfgpKWnf LfYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l8F0yKfEV2474L4Ct30BbTSDAfxIN/YXChfrODh7eN4=; b=JBZYdZrLzxqCk9h4ifH6qVV7iN/4pPNgpxy3suMdA9aBsYx2qcei5h/phmWsmmIMtg tn8P7drU46Vfb2Dolt5GF2F6JWiOPyMQiVlPYp3t6fHNgqVL3j/pR50s5ApkkZCUCNCD lbeMFyVYemDayXrtzTd0cwQt2HghvTKNsQS/evia2O9ufXKYowanmSyamZfrWbGtSHy+ WXnmX1ghfK09LawsmAZUN9XSJvmAyfprwD2ZyBDmmJ90DPaBuFveQZlekHi+kLjWStBS yQdcZAumSOnwy5VjhJlVgSIainCkTPmxp1i82V2nYRc2cIH9TaRzYcjxmSD7l6Dfqf3a v7RA== X-Gm-Message-State: AOAM532Tq0+A40NtTvlIvAPajMsmBPpkDlkGHvze/gduCvW2+HvNqH/r NQwao4DVZenaMSQ1h7T76O7hFUu4emPgkQ== X-Received: by 2002:a63:5914:: with SMTP id n20mr14725639pgb.164.1634408123230; Sat, 16 Oct 2021 11:15:23 -0700 (PDT) Received: from localhost.localdomain ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id ob5sm5075097pjb.2.2021.10.16.11.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Oct 2021 11:15:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 07/24] target/hppa: Drop checks for singlestep_enabled Date: Sat, 16 Oct 2021 11:14:57 -0700 Message-Id: <20211016181514.3165661-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211016181514.3165661-1-richard.henderson@linaro.org> References: <20211016181514.3165661-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" GDB single-stepping is now handled generically. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/hppa/translate.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) -- 2.25.1 diff --git a/target/hppa/translate.c b/target/hppa/translate.c index c3698cf067..3b9744deb4 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -814,11 +814,7 @@ static void gen_goto_tb(DisasContext *ctx, int which, } else { copy_iaoq_entry(cpu_iaoq_f, f, cpu_iaoq_b); copy_iaoq_entry(cpu_iaoq_b, b, ctx->iaoq_n_var); - if (ctx->base.singlestep_enabled) { - gen_excp_1(EXCP_DEBUG); - } else { - tcg_gen_lookup_and_goto_ptr(); - } + tcg_gen_lookup_and_goto_ptr(); } } @@ -2346,11 +2342,7 @@ static bool do_rfi(DisasContext *ctx, bool rfi_r) gen_helper_rfi(cpu_env); } /* Exit the TB to recognize new interrupts. */ - if (ctx->base.singlestep_enabled) { - gen_excp_1(EXCP_DEBUG); - } else { - tcg_gen_exit_tb(NULL, 0); - } + tcg_gen_exit_tb(NULL, 0); ctx->base.is_jmp = DISAS_NORETURN; return nullify_end(ctx); @@ -4274,10 +4266,9 @@ static void hppa_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) nullify_save(ctx); /* FALLTHRU */ case DISAS_IAQ_N_UPDATED: - if (ctx->base.singlestep_enabled) { - gen_excp_1(EXCP_DEBUG); - } else if (is_jmp != DISAS_IAQ_N_STALE_EXIT) { + if (is_jmp != DISAS_IAQ_N_STALE_EXIT) { tcg_gen_lookup_and_goto_ptr(); + break; } /* FALLTHRU */ case DISAS_EXIT: