From patchwork Sat Oct 16 18:15:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 515881 Delivered-To: patch@linaro.org Received: by 2002:ac0:cd8c:0:0:0:0:0 with SMTP id d12csp132919imp; Sat, 16 Oct 2021 11:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJNMgoMAcN36Qa1AYvlO8wkPOHOpJRJYOZy/Wm5oafHz5InnqyTaclO++pLZ11d2S3En+E X-Received: by 2002:a37:a5c1:: with SMTP id o184mr15472926qke.9.1634408488418; Sat, 16 Oct 2021 11:21:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634408488; cv=none; d=google.com; s=arc-20160816; b=hDeRGES0Ob4AFxhSI06Ajak/nyaVlQqTQ4Ijr+FffblY9TCotk4/QlDhNSSN4nyAgJ LfTqWJHVklOYITFxudVPYMwd/stcUlkluSjCUoEYpAd7w0DsbTViytwwsbNCMF9z0rG6 FIiNI2vwUNBMwSxrp9KHdEhbsu9rgccjrbIux9xEMQ5vPrsL4wBZ0PFZmAHoV8r6brw7 mDLi2477bzSAYOMIVeXrktAHSEtfI6VnMidCBjkXQUNqBiM0XYfLj7W4hAe+IxLc0IOW z5mGzHNbfghGwZL+M379hTy01fHeRlED0FK4hG4OwQHR28PHANCAU9aSrcTF7+lJ6rlr z+dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=RDO2b1TAF4ztgLUbPUMoAMU1yhwWU0vJ3YMD4i8Z5ck=; b=nJgze7mbtA0bETBzPNJXZ3717LU140kNH8m7woNor3UOcaH5KFJC3sQHpamWCm8Wza BI7c2XQPUTEsVLSDXSC80c8cWPrBzf47RHiML1Lv7ZvMzBqKjAoNN0qXPqiYB0HiFVqF mXg941ex2HX22TNZc77LCwvRI5YXDt1d1kfivwq+WJui1j5hMqs3MDGhVHMpzYqUrffl LdPLRXcnj5jtpaShSQZcHZiQxHzKxplhqf78PijWGWERD/M2Qq52WvqyPqyKx+fELxjv GC0h0TJEdh5ZKRO3q+GvrVOeNU+lHgJLj/jYiK9ltJgASOIgC+KHojn+wNwW2Op3bouk b7qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=doB1pcZ0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y3si6313218qky.130.2021.10.16.11.21.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Oct 2021 11:21:28 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=doB1pcZ0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mboJD-0007PK-OU for patch@linaro.org; Sat, 16 Oct 2021 14:21:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mboDW-0008LX-3s for qemu-devel@nongnu.org; Sat, 16 Oct 2021 14:15:35 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:51798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mboDR-0001yb-0N for qemu-devel@nongnu.org; Sat, 16 Oct 2021 14:15:31 -0400 Received: by mail-pj1-x102f.google.com with SMTP id kk10so9497995pjb.1 for ; Sat, 16 Oct 2021 11:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=RDO2b1TAF4ztgLUbPUMoAMU1yhwWU0vJ3YMD4i8Z5ck=; b=doB1pcZ0Q73Zg6NG0M8ks0CKrVw3bXNX10FWNGjPB+aEQaan10OrjHcvSrqlu8musq zzOUUv0P/zXTzOdtHO9L9VVmaaGMSxMtFnd1Eae8g9gv15DBMN8vXCHg/BNrCGUBVRQ1 Omk3WLBoiskGu1OsVDeX37geuLmiqk733T1b7/pvIZii+wkuAj9+KsiZiIqJk/tDfopB y5r5iMTGCFkmtUkZmrZXr57J0UhP9tYLdUwVZWM67VjywonLNa1q1mH4w8nRWYP8aHyc /N4C0AkVPenaZi0gRabTq6PLbjPGCU8VJdntCUfTKvZAPmkDzpwq7n1TEJvhj4G7A4j1 hY0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RDO2b1TAF4ztgLUbPUMoAMU1yhwWU0vJ3YMD4i8Z5ck=; b=IIJOjNdpsKMI3G6nhUiUnFtOoPfMmRwwQ+qH1sKt+rUlIVSd15XnTtrRNozYIomtnl 0VQuhkf7JK2ENiOtFMDXAiFBkBqxYIaHPO1t/EphXuwtCNtoMlfRpDyEOlZWFV6g/ej6 XpUbLsYJejRI6QgkoJpBwcw1eqdzh49UTwMuBPKbeir7ZD39kH7pMePfcFnsQ6Fu6ftS jxg25CPMw7PhDseHQwRfQTJV+VOdZjml4EyjiqYeeoP7wstDuM7NCXdeD7Imm3ykXq72 krn9ZyIr5zDXX6vGprDoENuXDEbAGUAoBgyvyo+olv34fLkRlTMLW4aojG+so0UQ0xRU AEKg== X-Gm-Message-State: AOAM533HqJi9aZbKY2/JsT7XaDkcea7DBqn1I3ymWl5kK69i3aMGsym2 eZUODTWugaqsLMY/yx98vTmlxPvoCMhDxQ== X-Received: by 2002:a17:90b:1d8e:: with SMTP id pf14mr21696301pjb.125.1634408127429; Sat, 16 Oct 2021 11:15:27 -0700 (PDT) Received: from localhost.localdomain ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id ob5sm5075097pjb.2.2021.10.16.11.15.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Oct 2021 11:15:27 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 12/24] target/microblaze: Drop checks for singlestep_enabled Date: Sat, 16 Oct 2021 11:15:02 -0700 Message-Id: <20211016181514.3165661-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211016181514.3165661-1-richard.henderson@linaro.org> References: <20211016181514.3165661-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) -- 2.25.1 diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 7e465b629a..437bbed6d6 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -126,12 +126,7 @@ static void gen_raise_hw_excp(DisasContext *dc, uint32_t esr_ec) static void gen_goto_tb(DisasContext *dc, int n, target_ulong dest) { - if (dc->base.singlestep_enabled) { - TCGv_i32 tmp = tcg_const_i32(EXCP_DEBUG); - tcg_gen_movi_i32(cpu_pc, dest); - gen_helper_raise_exception(cpu_env, tmp); - tcg_temp_free_i32(tmp); - } else if (translator_use_goto_tb(&dc->base, dest)) { + if (translator_use_goto_tb(&dc->base, dest)) { tcg_gen_goto_tb(n); tcg_gen_movi_i32(cpu_pc, dest); tcg_gen_exit_tb(dc->base.tb, n); @@ -1807,12 +1802,7 @@ static void mb_tr_tb_stop(DisasContextBase *dcb, CPUState *cs) /* Indirect jump (or direct jump w/ goto_tb disabled) */ tcg_gen_mov_i32(cpu_pc, cpu_btarget); tcg_gen_discard_i32(cpu_btarget); - - if (unlikely(cs->singlestep_enabled)) { - gen_raise_exception(dc, EXCP_DEBUG); - } else { - tcg_gen_lookup_and_goto_ptr(); - } + tcg_gen_lookup_and_goto_ptr(); return; default: