From patchwork Wed Oct 13 16:06:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Philippe Brucker X-Patchwork-Id: 515728 Delivered-To: patch@linaro.org Received: by 2002:adf:fbc8:0:0:0:0:0 with SMTP id d8csp8171809wrs; Wed, 13 Oct 2021 09:14:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzhZN4oGuBoZJQDhF/8V59qMdxMCIa5BlAbdla0zyi8b4cztHpdGjcxxBGfiqPcpjynNPp X-Received: by 2002:ac8:53da:: with SMTP id c26mr203001qtq.402.1634141699742; Wed, 13 Oct 2021 09:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634141699; cv=none; d=google.com; s=arc-20160816; b=S5FbD0qE2y6PPMWjazZTl0O3xM0pAB9dIt2Bs9SsxOb/r6/nRaCXcLkTkj2EgUng6y hjh+tTA1iM7IehRGLboZaHAuHUh8Ym1JZUvnvYRk+FqPPxXbiqZR/poQA6RW5tTYRlJJ vBbJvRYA++N3OnCxZcc/vk5kiqLb4LQV9EzOpJjYeTlX/QNqBg6sDPI4hpButG+wD5/H F5YALUAYBGRd0LTRZlyjIcqdPHdFGV5wPNLYJQE//5x2sczrc75Lbz8Ym+GegbZRjZKY 8B9LPJVu8/dKbKDiRxgmkFlVsriV1DksmQV0Trh8wuGVmq8W5h2HPIA+tYeDioqlXelw k6zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Sivj80yDIiOP5VpyG1S6/rDmp/L3z3yozBqSD5N66KA=; b=kuslc0CAYbEU1JaLqOyhs90JzAzepwjv7W+WfaqHECc1G+jsc+gqFMAsqILtNgyf82 4arhKt4n2NtbzfjKzf8omHk5iTLU+1Q6qCnxYxxgTzkiyQBGfFDMbBMv7cu23mkNvupK lUeVfv98c9oI+ULV3Y523JFwxIIcB/MCcY1JyOKrFpgh21cheXEIJL+Au76vurqb+R0N LQ37ghTG0hkYM3xA4FsBtYbKiHOW7g9WDeziJg77awz7YrWUk3A8oKwjS4g9FlrWBaj3 AUw5ADtZgdJcMSP20Vw5yA1KNoU8XAqTV/oltC3Svu/C8JvR2M3sm6/Qa1wXkcxmqWiW aYew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PzKhDYbY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h2si44097qtb.353.2021.10.13.09.14.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Oct 2021 09:14:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PzKhDYbY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maguB-0006cw-78 for patch@linaro.org; Wed, 13 Oct 2021 12:14:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1magpG-0000sQ-Nb for qemu-devel@nongnu.org; Wed, 13 Oct 2021 12:09:54 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:39744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1magpC-00026q-ML for qemu-devel@nongnu.org; Wed, 13 Oct 2021 12:09:53 -0400 Received: by mail-wr1-x436.google.com with SMTP id r18so10124558wrg.6 for ; Wed, 13 Oct 2021 09:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Sivj80yDIiOP5VpyG1S6/rDmp/L3z3yozBqSD5N66KA=; b=PzKhDYbYevofByY3ICIlK+du3i/exCYeCRYYQpjaxRW7OGIU+KTXJfj9gHwgs/Utbw p8peivcca/HTvFlFDHKNs5+T7iEWvf11CLAvr67YW+XiSW3mA1TMhHsXIEdbC9i71Je9 9W3BLUIV0abFh3kOM06RIBGzAh8Gcjhk9RkSPBFWqqJeemrCmNR6Whd21wsp5fDo/WG/ VmuOJAFnO5RVkk5Z2F4xCoiagXk23Q4SX6mbNjYPu5v1Ul41c++G3jeOWl4iB3eUopmF hdixWYbiwdazMf5/wrFf1RwFe5VKtSDap3zlulxBOnl+AcjpHbMlXPJvZghQ8iKxiy0W i8dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sivj80yDIiOP5VpyG1S6/rDmp/L3z3yozBqSD5N66KA=; b=hQn6yNmoZ0qFE1+9AtwrOeT9CxuQFGNOo8e9/Lbgeb84f8sSUwYL28Gan/QoNI5aP5 pJSa6+NXq9odnRFUix8ZoN7LzHMK86B2f2bfhqTWB3IasDUaifY7PYrfT9jmkTA/Cl/v kDsZLS+DRoO5SQOHtVLDGz9UJf2b5B5SA/QN2Uac3A3nbJsyizic+DsTgudJIX7/yxSr K3srg/oCFixBet5BhXXASe5Qw63Oa0aZ1LVMBaKa1F2rPwBd8wAQEIgqHGvsqauu8Ei+ o820Xr34n1zutLRVVVuHTEELptMqNA3hKN5eGdUc5btCZdxxzv1nGQIQbT4uGWk8BAFu sm1A== X-Gm-Message-State: AOAM533V74fDOd1laRMfH/qX2TFhWul79bK3nBVuZHN+jilFBBqq2Ry+ Q0HwEJ4/S9mdtpRy+YyN+xPxDg== X-Received: by 2002:adf:bc14:: with SMTP id s20mr95171wrg.8.1634141389277; Wed, 13 Oct 2021 09:09:49 -0700 (PDT) Received: from localhost.localdomain (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id v18sm10482wrm.63.2021.10.13.09.09.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 09:09:48 -0700 (PDT) From: Jean-Philippe Brucker To: pbonzini@redhat.com, peter.maydell@linaro.org Subject: [RESEND PATCH 2/2] hw/i386: Rename default_bus_bypass_iommu Date: Wed, 13 Oct 2021 17:06:08 +0100 Message-Id: <20211013160607.649990-3-jean-philippe@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211013160607.649990-1-jean-philippe@linaro.org> References: <20211013160607.649990-1-jean-philippe@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=jean-philippe@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, richard.henderson@linaro.org, armbru@redhat.com, qemu-stable@nongnu.org, Eric Auger , eauger@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine parameter definitions cannot use underscores, because keyval_dashify() transforms them to dashes and the parser doesn't find the parameter. This affects option default_bus_bypass_iommu which was introduced in the same release: $ qemu-system-x86_64 -M q35,default_bus_bypass_iommu=on qemu-system-x86_64: Property 'pc-q35-6.1-machine.default-bus-bypass-iommu' not found Rename the parameter to "default-bus-bypass-iommu". Passing "default_bus_bypass_iommu" is still valid since the underscore are transformed automatically. Fixes: c9e96b04fc19 ("hw/i386: Add a default_bus_bypass_iommu pc machine option") Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Jean-Philippe Brucker --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.33.0 diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 86223acfd3..54e4c00dce 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1718,7 +1718,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data) object_class_property_add_bool(oc, "hpet", pc_machine_get_hpet, pc_machine_set_hpet); - object_class_property_add_bool(oc, "default_bus_bypass_iommu", + object_class_property_add_bool(oc, "default-bus-bypass-iommu", pc_machine_get_default_bus_bypass_iommu, pc_machine_set_default_bus_bypass_iommu);