From patchwork Wed Oct 13 16:06:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Philippe Brucker X-Patchwork-Id: 515726 Delivered-To: patch@linaro.org Received: by 2002:adf:fbc8:0:0:0:0:0 with SMTP id d8csp8167983wrs; Wed, 13 Oct 2021 09:11:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzXf78tnmy33BLncdvrO8ZuxmHKd3abFBoJMCxV5HvaS0xv/XkvXCBh+aSFe8kLBAgoDko X-Received: by 2002:a05:620a:4247:: with SMTP id w7mr90088qko.381.1634141475088; Wed, 13 Oct 2021 09:11:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634141475; cv=none; d=google.com; s=arc-20160816; b=vhmCQEP0U5pvaNaUkoNiBLYeFHbedK445cH+262jiUG6pyk5mXfyh8WWL06yBZvolG RWWilHnFp9tz+G1Fc3XUeXPviIodzybdKPl+YSfjYJII+OnYqATCFS/bHs9HO9T256CB GfvnMn04RHMGfnlxbr+fP2jsPJfNprtd50FIWtnbdHYmTbAZvFak6mdqtnaVGJLPM4W4 fGsJaBozyPv1aoBe8y4M8TjO8IdHvTS6b3BRyx7b1z8tCudZT9CWolEk/j2m5JBeC9Jj hNGgKDI712sqyFv6h9iDVkNkhu74fG6htnJfvjTeCLjRAfDWPyh1Eb8tGtGzRGXgMi1K eBsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=z51t1fm0QsaKEHQ5rRMvH9Hl6mH6z+8WE2S3J3iChmU=; b=tzdhXbJVXvwqbMWVVrHdy0BlQ2hKG1nBnIS4S3m0OmF0AiN0CeipHYrJniddPjwrVv I4ABIcnb0nowqxYLfHwMeFKqA5yQ+MDRhubz0gc0MMo9ei5fN3d7lCwH1+Ue3L9UFIww QONtRNGQbrJMktRmOeOmmGGLDGyzd5asdjilmwpQ/wQ+phcoy4jzw6eUgkal78MXuRCM +pEBHuaSeksbcU5BwfVOome25W3lgn7jfGSf7hNwgD+OMbPyR+6huyed9mb3y3LNUKJO 3v+Wr/dNtOJ0V21SzZfpc1R1Gif9cktp08Ni1YzbgpgQWW8VQBibODaqEP3wxRMq4C0w rseA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=tSBlQqCm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s8si11484757qko.143.2021.10.13.09.11.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Oct 2021 09:11:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=tSBlQqCm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1magqY-0001Qo-GM for patch@linaro.org; Wed, 13 Oct 2021 12:11:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1magpE-0000pC-Av for qemu-devel@nongnu.org; Wed, 13 Oct 2021 12:09:52 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:43573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1magpB-00026c-Nt for qemu-devel@nongnu.org; Wed, 13 Oct 2021 12:09:52 -0400 Received: by mail-wr1-x435.google.com with SMTP id r7so10113878wrc.10 for ; Wed, 13 Oct 2021 09:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z51t1fm0QsaKEHQ5rRMvH9Hl6mH6z+8WE2S3J3iChmU=; b=tSBlQqCmtW3+tNkD7++WE0hGCZYdcvpBFnnCAad08v6Gu7mEOmmV2XpiOb0R2tfx0n yVzNxDNbPtagQ/1G/VOzF8nXAZlqTaUPK+A23Alo07eA9EjhdzRRw+cujoSGmyTQugfu Ervj/EZxN3ai7R6+K0UlOQ1XXtrrchUCmPwzJ7ifSh+zcKFnGKXzDywzvWrdyhwj/bIq VeM99t4N6ZnfRhKZuxkXzEn0MnXgAdmPBT0Ww7c5lfClKb5VsJNVK1BwOzxIU9maoaDd QLq7CKDW3LefU7sYcm1RUlmwL6ZPM1PYcgPqkl+hVeFo4wB74QkR2jp+kw+7KDlOtlKB 5Z9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z51t1fm0QsaKEHQ5rRMvH9Hl6mH6z+8WE2S3J3iChmU=; b=5HVeM1O3JqKDSQZ9njTSu3tY3hCkq2GtQptAfcq4kaY0JSij+gR4fo8lC0rRztHQvn 9S8FVjw1+j9ZuHwEreWLwWMjCRfFAFsOLy+uB1XAmuQOt0qSVUITUhjiuOMQgjEe2Ihp nVTcm/M+UAPpnKjLtuf+n8SpY6nM4A2NSJaFOCyIoCQ8fmwjKTW895uJ1CklVGzKrzTc H5ywTYd4KtcH76cpMreGpXzbVsZ414ocweTlv35scnf7gz9503KXkbwzwb7AVDPE4rA/ VOkwKyPbIaUuzYMUktmekL5o7Z3A3JbMHcfCH+iISHsBjhKYb6YLpsUunYkJTVysG80d U5Vw== X-Gm-Message-State: AOAM5309u/rwquw17+Vy/6YE+k3gvxiB9pyA6coCX9dxMFJUn/7CVx2z PDHM+Ji7RkOPZyRNRdz5G5h8kQ== X-Received: by 2002:adf:b1d7:: with SMTP id r23mr20474wra.145.1634141388328; Wed, 13 Oct 2021 09:09:48 -0700 (PDT) Received: from localhost.localdomain (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id v18sm10482wrm.63.2021.10.13.09.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 09:09:47 -0700 (PDT) From: Jean-Philippe Brucker To: pbonzini@redhat.com, peter.maydell@linaro.org Subject: [RESEND PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu Date: Wed, 13 Oct 2021 17:06:07 +0100 Message-Id: <20211013160607.649990-2-jean-philippe@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211013160607.649990-1-jean-philippe@linaro.org> References: <20211013160607.649990-1-jean-philippe@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=jean-philippe@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, richard.henderson@linaro.org, armbru@redhat.com, qemu-stable@nongnu.org, Eric Auger , eauger@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine parameter definitions cannot use underscores, because keyval_dashify() transforms them to dashes and the parser doesn't find the parameter. This affects option default_bus_bypass_iommu which was introduced in the same release: $ qemu-system-aarch64 -M virt,default_bus_bypass_iommu=on qemu-system-aarch64: Property 'virt-6.1-machine.default-bus-bypass-iommu' not found Rename the parameter to "default-bus-bypass-iommu". Passing "default_bus_bypass_iommu" is still valid since the underscore are transformed automatically. Fixes: 6d7a85483a06 ("hw/arm/virt: Add default_bus_bypass_iommu machine option") Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Jean-Philippe Brucker --- hw/arm/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.33.0 diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7170aaacd5..5fdd5aa888 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2687,10 +2687,10 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) "Set the IOMMU type. " "Valid values are none and smmuv3"); - object_class_property_add_bool(oc, "default_bus_bypass_iommu", + object_class_property_add_bool(oc, "default-bus-bypass-iommu", virt_get_default_bus_bypass_iommu, virt_set_default_bus_bypass_iommu); - object_class_property_set_description(oc, "default_bus_bypass_iommu", + object_class_property_set_description(oc, "default-bus-bypass-iommu", "Set on/off to enable/disable " "bypass_iommu for default root bus");