From patchwork Wed Oct 13 02:45:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 515676 Delivered-To: patch@linaro.org Received: by 2002:ac0:b5cc:0:0:0:0:0 with SMTP id x12csp6080458ime; Tue, 12 Oct 2021 19:49:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6Pdo12M7Qd2ziPZDBYix19XMXThBhyHhtGi/prT6pvx6J99RaSG8iW2Vfhd3dBfQRXqS2 X-Received: by 2002:ac8:12:: with SMTP id a18mr26072211qtg.157.1634093377482; Tue, 12 Oct 2021 19:49:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634093377; cv=none; d=google.com; s=arc-20160816; b=zKCx1HkQGKNxQ8TCj6PtL6GPhtRPc7wHuQyQ63RLFwfjY2836Gpd83vrEitQm8ZmfJ RsLhEKJcjR5IiYh0UJ5GRsvKjoMghPav27v/ZF2Jrvz2QeubyohzI5LAjYFeU5QdBIuP unO3OdbwfhXeLU1iL3bdMJ5jAgknLgXbqUwabbquHt4XUedmqo/MlvyZ/ISmMePufO5r W+fgsUsMkpEMBIK7r4qIzOAVKqs5yReOZeAhVs+H9Ghv8oAJyKkcBPS8rrn9zuAGt4+4 YrcIzALfBesL6mmVK4VqmJsvRfgkTnsweFF9UlE8CeKyb9g1RrJ9NYl/qWdTtstWlOIE Xm/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=xZtb0PPzu6cBb+iC7eRYJW+bmlWER7T8m0GFx24utaE=; b=cf5rbNKu73OkuGc4JLJLGv89vdtKXdnGy3kQeoBvyW0qMi7Pr7o97HRNmtSZV54LSG ZAauvwFPQqLiSEO1n8/i6nEuYtAWQtjF31UpeQ0SXW/OUoWzWXP1CKSKBdMm4R/eThFL +b6seKlu9540slR0fJ5khujuJcGM8tFbOkTAMlgjBFvunWas5WQnlC1zIKmr4DYj+9If W8NCXDjB5teJfd119QSlNADiuHP81twx+rvjTF7lOpMRLe2/08XwyFpQy3s1CmhHFjeK BVa8j03kVFCzRwlNfIZK9/warsudZuJv1OjTf/fXJqG4ddq9MwaKUSNAQdy2PynOW3Vp ty9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yLNsAHDU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u2si9159323qkb.85.2021.10.12.19.49.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Oct 2021 19:49:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yLNsAHDU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maUKn-0001pk-1M for patch@linaro.org; Tue, 12 Oct 2021 22:49:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maUHh-0004U5-LL for qemu-devel@nongnu.org; Tue, 12 Oct 2021 22:46:25 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:40821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maUHg-0004tE-01 for qemu-devel@nongnu.org; Tue, 12 Oct 2021 22:46:25 -0400 Received: by mail-pg1-x52a.google.com with SMTP id q5so880405pgr.7 for ; Tue, 12 Oct 2021 19:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xZtb0PPzu6cBb+iC7eRYJW+bmlWER7T8m0GFx24utaE=; b=yLNsAHDUYOEHlKr8d8bwavKTYKbnMTWTmewqMijoNTgoG1lnUrrXPE0Wv0438Qst3O hTJS1q9bhk93rs6CZOgAKLEy9isOwYbTdQuUxkY22QoSH/IvK1kY/Lzvru3nut2vNvTq gXEPWczFT+EkjJQNjIPLM/0EBTJYXpLWSPvGn9frjozcyKAldOxJRNF9wJnoTiMuKXqP qqN+TOl0KzuSSHDCnv2yzT5yAhw4xgRO81sdtwUEEv3rFg9Hv4H8lBfAVsqSsTDTv32K 6zA6r0Oqs+EKC5TkiBercE5d+BI9DGUd3ERFeQYkPGb3IL5zn5irAO58gRqNTt+WFEVm kZuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xZtb0PPzu6cBb+iC7eRYJW+bmlWER7T8m0GFx24utaE=; b=GUF0/1AxE/yF7oBZ9uv6b9plGkQaVyJdq7XhVOOfFMLCSnkNqBrsOkGUU9QIKcwgih hz9yw3NykSzW1bNQYPD2Bq4XvRruKkQQoLC09M6DPYgqRnz8KoXie7u6HnGlRyQTkpt4 7hGvXqdczwOGoJbtkawdCBJeWrzZ6mSphQhpCnbjj/kh5NWJNxhs4g1UzMnSfqtovbdi 1L+5lgRDGfrEEs55fQx+1FDPnai5ZpMEL7lMzf/BMyYB67jvlvAxD63b6pAcG55+FYRt HOKygrbSSzTAwctW9nTkdyjv95tIlQlXL/uIsWUkx48KkMNWQSaX/dpy/MDH9gLrRAUa jvKg== X-Gm-Message-State: AOAM532SOAHxS/73KTrdVaGNKyoB9p5y/AufCyQSuScHucxvehlkapRh X0HTSto1DTOj7RDv9VTVknwhkuQeIefoFQ== X-Received: by 2002:a05:6a00:1707:b0:44d:47e1:9ffe with SMTP id h7-20020a056a00170700b0044d47e19ffemr4712868pfc.53.1634093182616; Tue, 12 Oct 2021 19:46:22 -0700 (PDT) Received: from localhost.localdomain ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id qe17sm4855014pjb.39.2021.10.12.19.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 19:46:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 13/48] target/sparc: Remove DEBUG_UNALIGNED Date: Tue, 12 Oct 2021 19:45:32 -0700 Message-Id: <20211013024607.731881-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211013024607.731881-1-richard.henderson@linaro.org> References: <20211013024607.731881-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The printf should have been qemu_log_mask, the parameters themselves no longer compile, and because this is placed before unwinding the PC is actively wrong. We get better (and correct) logging on the other side of raising the exception, in sparc_cpu_do_interrupt. Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.25.1 diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index abe2889d27..2d0d180ea6 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -27,7 +27,6 @@ //#define DEBUG_MMU //#define DEBUG_MXCC -//#define DEBUG_UNALIGNED //#define DEBUG_UNASSIGNED //#define DEBUG_ASI //#define DEBUG_CACHE_CONTROL @@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env, target_ulong addr, uint32_t align, uintptr_t ra) { if (addr & align) { -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, ra); } } @@ -1968,10 +1963,6 @@ void QEMU_NORETURN sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr, SPARCCPU *cpu = SPARC_CPU(cs); CPUSPARCState *env = &cpu->env; -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr); } #endif