From patchwork Fri Oct 1 17:11:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 515072 Delivered-To: patch@linaro.org Received: by 2002:a02:606e:0:0:0:0:0 with SMTP id d46csp1011139jaf; Fri, 1 Oct 2021 10:30:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyn3WonAWFPvoXQ+EOp/AKdF9mdZtEsZhZuV8jRmUWYhLNIozv1J/I+ctn6x/Q1NU4wQo9W X-Received: by 2002:a05:6102:4b0:: with SMTP id r16mr5151897vsa.7.1633109456504; Fri, 01 Oct 2021 10:30:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633109456; cv=none; d=google.com; s=arc-20160816; b=JDAbhDkXB1CFpa/ED8rNZ9iRJqXtLyApL+YNkaK6PYFyQjPqSvNaYElZAv6J9BAvuu D1MMz6cjIehk1S9KSz7SUFTfUpp7Y26876wKvG6nDykCjpKXvs0VKyEnTmsgoIdQSgED qAXHOjTtat/2bl69aHSV8iKfKg40kQWb+k2d8fruiNTike17nf5UPM4A5NMQmx9I9vTH 6mSk0MCUSi0kMVEoKJDSW3ROiQ4QCdKV59Sgc5nRxgz+cD5+uJ783a13yG3BTRhzUVht TvZGYURA4bK2iOn2KN3TUnrxSC4Xv3b3CZsgIpjdez3mLT9kNxF1k1Zv3fHFpeE0OYuV itYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=nMBhe6wRyQJffJfKqR3e4B4BjhzuFHvBY7lYZ6XbL2k=; b=mYxjKmNMvJzuoAtFNE1+AZOpy+t8lz/jIpFmaIvz97+iLC7+h0PABUtXczE+Z398jI 2Xa2usR/EQucsehPJgMEimJylsI8gXgKRIYNsALM5N9IA85KvMVNs2q8TgkOY7+0/qbw 24cmb5KdAH8C7e3sKH2qncNayTjVwStjbEMj/oY6fTc++8DPKbVSkq/OfX4TPtkXzN1N CM6gAMQmwRftjq2r+hom7cFaID1q7OHh16Am8QQa6dp8aEj2RM5Z7SeIPVzL7h1EdTeg JyWwXZiJpbPylPRBVeHrvR5z40O5vPxrVzhhZB/VAGQLlTaXDLh9vQM7vnQc3iD+viUD rZew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hiXQ3mmw; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 92si4510792uab.110.2021.10.01.10.30.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Oct 2021 10:30:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hiXQ3mmw; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWMN3-0000Ju-8M for patch@linaro.org; Fri, 01 Oct 2021 13:30:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWM51-0004rY-2J for qemu-devel@nongnu.org; Fri, 01 Oct 2021 13:12:15 -0400 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]:43602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWM4u-000567-Mx for qemu-devel@nongnu.org; Fri, 01 Oct 2021 13:12:14 -0400 Received: by mail-qk1-x736.google.com with SMTP id 138so9803051qko.10 for ; Fri, 01 Oct 2021 10:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nMBhe6wRyQJffJfKqR3e4B4BjhzuFHvBY7lYZ6XbL2k=; b=hiXQ3mmw5CBhTiIe+H0zJFUOd8tQlCu6I7USJ9pr7fUw9L66NMmICsOqxlPs8R3Gho llCdRf3wWjVoI138TAgVv4z65YGzmQHm3v/jEOPQE0Y8xOes4knIgigu/pbacllm25m/ urZQGqYjvyFYSNJQ1yWzXpPNT9GhgxHTTE6tVuhkj1eqW/eN5McrYX9WyyHue8JekTBH pueo29vmGAM/b0VAcmg/XGr2OOTgqkn5YmSvaoneuDxmoOR0Nxob3nuoBQmO0hA6tnXK VZq57jP6FUnA3prwlFdPi2ai3LUlwMpV7Q0aJvWbEK933n9cOsGr+jcrbTDTc0w73tMM zenA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nMBhe6wRyQJffJfKqR3e4B4BjhzuFHvBY7lYZ6XbL2k=; b=5DzzG1YWWdPShZwzBNEtzwvxHsZ5n0wtMY8Wz72523t2uaJDCUt1lKpt2kIq8UrWK9 7RDuNPiQH511WX5Ho9m7cfIQJlJOyfNKmZXinL0givoplRY18fE7r9ZJg9J6tEPNwvTs a312WYX+GNJmvnJv6pp5WujsSquthcD5i/NeQ0UsNjez5s+PJyWZw2zV+TlJGtRESLU6 +9jyk4VPLpiSJneqqkKVuZC8LaJbvJFG2xE2nnLBO2KKMBMV/lMfw7gDxzDn8dY15lJn AGHkcpTlvSD/qi8+w6GUuFaob2dbHUQZGG0+TINoppitBXOYxn1h7EbOXsQRl/a6/+49 9DEg== X-Gm-Message-State: AOAM532u7TqwLOxRktCUo8iPw+CDWTjLJRl/GjZ5phNcF57RXGSKzxNM KOPYZWVCzhMAq95X3MT0jWMl/KmsJJ5ygg== X-Received: by 2002:a37:67cb:: with SMTP id b194mr10154077qkc.379.1633108327799; Fri, 01 Oct 2021 10:12:07 -0700 (PDT) Received: from localhost.localdomain (c-67-174-166-185.hsd1.ga.comcast.net. [67.174.166.185]) by smtp.gmail.com with ESMTPSA id y15sm3557250qko.78.2021.10.01.10.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 10:12:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 17/41] linux-user/host/riscv: Improve host_signal_write Date: Fri, 1 Oct 2021 13:11:27 -0400 Message-Id: <20211001171151.1739472-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211001171151.1739472-1-richard.henderson@linaro.org> References: <20211001171151.1739472-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::736; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x736.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Do not read 4 bytes before we determine the size of the insn. Simplify triple switches in favor of checking major opcodes. Include the missing cases of compact fsd and fsdsp. Signed-off-by: Richard Henderson --- linux-user/host/riscv/host-signal.h | 83 ++++++++++------------------- 1 file changed, 28 insertions(+), 55 deletions(-) -- 2.25.1 diff --git a/linux-user/host/riscv/host-signal.h b/linux-user/host/riscv/host-signal.h index 5860dce7d7..ab06d70964 100644 --- a/linux-user/host/riscv/host-signal.h +++ b/linux-user/host/riscv/host-signal.h @@ -17,65 +17,38 @@ static inline uintptr_t host_signal_pc(ucontext_t *uc) static inline bool host_signal_write(siginfo_t *info, ucontext_t *uc) { - uint32_t insn = *(uint32_t *)host_signal_pc(uc); - /* - * Detect store by reading the instruction at the program - * counter. Note: we currently only generate 32-bit - * instructions so we thus only detect 32-bit stores + * Detect store by reading the instruction at the program counter. + * Do not read more than 16 bits, because we have not yet determined + * the size of the instruction. */ - switch (((insn >> 0) & 0b11)) { - case 3: - switch (((insn >> 2) & 0b11111)) { - case 8: - switch (((insn >> 12) & 0b111)) { - case 0: /* sb */ - case 1: /* sh */ - case 2: /* sw */ - case 3: /* sd */ - case 4: /* sq */ - return true; - default: - break; - } - break; - case 9: - switch (((insn >> 12) & 0b111)) { - case 2: /* fsw */ - case 3: /* fsd */ - case 4: /* fsq */ - return true; - default: - break; - } - break; - default: - break; - } + const uint16_t *pinsn = (const uint16_t *)host_signal_pc(uc); + uint16_t insn = pinsn[0]; + + /* 16-bit instructions */ + switch (insn & 0xe003) { + case 0xa000: /* c.fsd */ + case 0xc000: /* c.sw */ + case 0xe000: /* c.sd (rv64) / c.fsw (rv32) */ + case 0xa002: /* c.fsdsp */ + case 0xc002: /* c.swsp */ + case 0xe002: /* c.sdsp (rv64) / c.fswsp (rv32) */ + return true; } - /* Check for compressed instructions */ - switch (((insn >> 13) & 0b111)) { - case 7: - switch (insn & 0b11) { - case 0: /*c.sd */ - case 2: /* c.sdsp */ - return true; - default: - break; - } - break; - case 6: - switch (insn & 0b11) { - case 0: /* c.sw */ - case 3: /* c.swsp */ - return true; - default: - break; - } - break; - default: - break; + /* 32-bit instructions, major opcodes */ + switch (insn & 0x7f) { + case 0x23: /* store */ + case 0x27: /* store-fp */ + return true; + case 0x2f: /* amo */ + /* + * The AMO function code is in bits 25-31, unread as yet. + * The AMO functions are LR (read), SC (write), and the + * rest are all read-modify-write. + */ + insn = pinsn[1]; + return (insn >> 11) != 2; /* LR */ } return false;