| Message ID | 20210803110237.1051032-3-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | check-tcg hacks for BSD | expand |
On Tue, Aug 3, 2021, 5:02 AM Alex Bennée <alex.bennee@linaro.org> wrote: > This doesn't exist in BSD world and doesn't seem to be needed by > either. > Sys/endian.h is common. FreeBSD has endian.h, but others don't. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Warner Losh <imp@bsdimp.com> > Acked by: Warner Losh <imp@bsdimp.com> > --- > tests/tcg/multiarch/sha1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c > index 87bfbcdf52..0081bd7657 100644 > --- a/tests/tcg/multiarch/sha1.c > +++ b/tests/tcg/multiarch/sha1.c > @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context); > void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t > len); > void SHA1Final(unsigned char digest[20], SHA1_CTX* context); > /* ================ end of sha1.h ================ */ > -#include <endian.h> > > #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - > (bits)))) > > -- > 2.30.2 > > <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 3, 2021, 5:02 AM Alex Bennée <<a href="mailto:alex.bennee@linaro.org">alex.bennee@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This doesn't exist in BSD world and doesn't seem to be needed by<br> either.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Sys/endian.h is common. FreeBSD has endian.h, but others don't. </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Signed-off-by: Alex Bennée <<a href="mailto:alex.bennee@linaro.org" target="_blank" rel="noreferrer">alex.bennee@linaro.org</a>><br> Cc: Warner Losh <<a href="mailto:imp@bsdimp.com" target="_blank" rel="noreferrer">imp@bsdimp.com</a>><br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Acked by: Warner Losh <<a href="mailto:imp@bsdimp.com">imp@bsdimp.com</a>></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> ---<br> tests/tcg/multiarch/sha1.c | 1 -<br> 1 file changed, 1 deletion(-)<br> <br> diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c<br> index 87bfbcdf52..0081bd7657 100644<br> --- a/tests/tcg/multiarch/sha1.c<br> +++ b/tests/tcg/multiarch/sha1.c<br> @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context);<br> void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t len);<br> void SHA1Final(unsigned char digest[20], SHA1_CTX* context);<br> /* ================ end of sha1.h ================ */<br> -#include <endian.h><br> <br> #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - (bits))))<br> <br> -- <br> 2.30.2<br> <br> </blockquote></div></div></div>
On Tue, Aug 3, 2021 at 7:55 AM Warner Losh <imp@bsdimp.com> wrote: > > > On Tue, Aug 3, 2021, 5:02 AM Alex Bennée <alex.bennee@linaro.org> wrote: > >> This doesn't exist in BSD world and doesn't seem to be needed by >> either. >> > > Sys/endian.h is common. FreeBSD has endian.h, but others don't. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> Cc: Warner Losh <imp@bsdimp.com> >> > > Acked by: Warner Losh <imp@bsdimp.com> > On second thought, this is Reviewed by: Warner Losh <imp@bsdimp.com> since I know the change is good. Warner > --- >> tests/tcg/multiarch/sha1.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c >> index 87bfbcdf52..0081bd7657 100644 >> --- a/tests/tcg/multiarch/sha1.c >> +++ b/tests/tcg/multiarch/sha1.c >> @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context); >> void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t >> len); >> void SHA1Final(unsigned char digest[20], SHA1_CTX* context); >> /* ================ end of sha1.h ================ */ >> -#include <endian.h> >> >> #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - >> (bits)))) >> >> -- >> 2.30.2 >> >> <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 3, 2021 at 7:55 AM Warner Losh <<a href="mailto:imp@bsdimp.com">imp@bsdimp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 3, 2021, 5:02 AM Alex Bennée <<a href="mailto:alex.bennee@linaro.org" target="_blank">alex.bennee@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This doesn't exist in BSD world and doesn't seem to be needed by<br> either.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Sys/endian.h is common. FreeBSD has endian.h, but others don't. </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Signed-off-by: Alex Bennée <<a href="mailto:alex.bennee@linaro.org" rel="noreferrer" target="_blank">alex.bennee@linaro.org</a>><br> Cc: Warner Losh <<a href="mailto:imp@bsdimp.com" rel="noreferrer" target="_blank">imp@bsdimp.com</a>><br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Acked by: Warner Losh <<a href="mailto:imp@bsdimp.com" target="_blank">imp@bsdimp.com</a>></div></div></blockquote><div><br></div><div>On second thought, this is</div><div><br></div><div>Reviewed by: Warner Losh <<a href="mailto:imp@bsdimp.com">imp@bsdimp.com</a>></div><div><br></div><div>since I know the change is good.</div><div><br></div><div>Warner</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> ---<br> tests/tcg/multiarch/sha1.c | 1 -<br> 1 file changed, 1 deletion(-)<br> <br> diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c<br> index 87bfbcdf52..0081bd7657 100644<br> --- a/tests/tcg/multiarch/sha1.c<br> +++ b/tests/tcg/multiarch/sha1.c<br> @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context);<br> void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t len);<br> void SHA1Final(unsigned char digest[20], SHA1_CTX* context);<br> /* ================ end of sha1.h ================ */<br> -#include <endian.h><br> <br> #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - (bits))))<br> <br> -- <br> 2.30.2<br> <br> </blockquote></div></div></div> </blockquote></div></div>
diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c index 87bfbcdf52..0081bd7657 100644 --- a/tests/tcg/multiarch/sha1.c +++ b/tests/tcg/multiarch/sha1.c @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context); void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t len); void SHA1Final(unsigned char digest[20], SHA1_CTX* context); /* ================ end of sha1.h ================ */ -#include <endian.h> #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - (bits))))
This doesn't exist in BSD world and doesn't seem to be needed by either. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Cc: Warner Losh <imp@bsdimp.com> --- tests/tcg/multiarch/sha1.c | 1 - 1 file changed, 1 deletion(-) -- 2.30.2