From patchwork Tue Aug 3 04:14:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 490864 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:396:0:0:0:0 with SMTP id y22csp312921jap; Mon, 2 Aug 2021 21:29:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCTbRUESBEgJvAPkslqOlyft+Xg6JkNsRjijOwsdHiMGNet13tj5egK2dPzaTfE+FQhCC8 X-Received: by 2002:a92:1942:: with SMTP id e2mr594541ilm.4.1627964968525; Mon, 02 Aug 2021 21:29:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627964968; cv=none; d=google.com; s=arc-20160816; b=cpXwM45LLm029VZuBOaPSGGFXHYASYB7r7mF3gx9m1+7VpDqD5tKRNz+91gX0GB6kI aohed78fIOHIKSYqEjprsGamWq2Ky0r1yGJP3Tt3js86kVsBm5hB1WjWDPAS5TB8lC0h 61VFM9BFO3YnxByYeDzuIEBbwmsKrkKDWGeXE0UdxVqGGvXcjq/VVV2dZO0vRhYt1DnX ebZ43kMcWZxhIHBD4T82+ANkIhwag7JMJMrY+25oD+DWYN2fNXjTkromVyvoaEs2RZO+ YXx7UUlm8bf7IxUlg4mHJVdfCKC2d9Sudd4G1yTGJMPxE8WBLX93Xb1nY3aoc0fiRw+z OkQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=K/7Y1V5oBIIfdjY20lpJpKxfET+Clwy5MMgM5y1dWLw=; b=q7L570NXic12/x3d8e8x0gPuhlFDev0s6LEXKEmoYxGUF9Ca1YUcJfOZDmq5cEfXCu WPGT4SdCPYub9Bp2jfz5aRoM3wSqHtVnsNFPexV6UXxscsjWZ6B98DbuM3l8mcalmoiv u8Cy1MsBzZsI59NyVIcS9EdkwzK+e8hzcS2a6i/OaEerTUfk1DoqT7qADMW9K0/wHbfl pegTV4bpyqUrUZxLrE8KjCZZ4k4rHmzNShxjLbjmanPTK2luvvc02k8OyphAL434qP49 A6sFG3qARJksJKv1MeUY4o2YC1aEWKcXFY0wUZHdtAfzeTfBM7btU+5GPI/WLitcx/tB 9vZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CD6wsUVx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f13si15203489ils.29.2021.08.02.21.29.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Aug 2021 21:29:28 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CD6wsUVx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAm3U-0001Fu-0h for patch@linaro.org; Tue, 03 Aug 2021 00:29:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAlpv-0003qL-Jq for qemu-devel@nongnu.org; Tue, 03 Aug 2021 00:15:27 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:42783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAlps-0002Td-Kx for qemu-devel@nongnu.org; Tue, 03 Aug 2021 00:15:27 -0400 Received: by mail-pl1-x635.google.com with SMTP id t3so20041911plg.9 for ; Mon, 02 Aug 2021 21:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K/7Y1V5oBIIfdjY20lpJpKxfET+Clwy5MMgM5y1dWLw=; b=CD6wsUVxO9fdAt2f9/G6dZ3yTbWANvbkrV72ToZ9OPo2bTHjFhwRsX/7DgMFR4XKyH 05szZqyBEBMv9XBUbtmMPgtTDHrbt3RZzPMqYJD3CNnMcc2iy7xFnCo9c63Ru3Od5fJo v6SA+k2LngcHoiktjHTHj9wz37zKHTSOyzFmEqac+iOsjduq5wG6yujIpCSe5raZOGIU +eNPj9FccqohYsSR2NZuVk9zaJT0FR/w6ymd7M4UDd12ImFXrESJ7pxRHEw1Lpi+AS6G yos35yzORlzikZYMtlGutM2RbRGo6OjM1cUOId4y293eUHL/u8Yi/nnFQY39E64YKuSi e+Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K/7Y1V5oBIIfdjY20lpJpKxfET+Clwy5MMgM5y1dWLw=; b=prLqX8cxl2biJ0Vq64G38+Ju8tvoY1J1Q6DNf6K9i3sBYm22hnJHK+kZXaXBXe7n8/ fk7pIOXW3abyaunm7o0WsqEfzAXOR1gy2ewTAztdrMcIcLfTdAcZkZIQp0zYAJTYG2fn ghiP/kNDkkqHW+vLBW1Y4/JSRzOWNmwSph33H59fb23F9r3eX7qAVap8PxzZSxY75a2h Kh5IaZH+hnUAOKPoi/7DBEqOgJPI+L14EiTeX57udw+980a1N942KtUVDyTeIMV99bJl Ypka7kohgvaU94ZbGuQTX0fp7s+gnDqkxNn+s48iXkaLjYnVVWcJcUvHsAVOUdZgbXxc UFuw== X-Gm-Message-State: AOAM530uB+C7aqzVGZ5sBPTTT9w+WR+On+F9ro3qluYVn616DM8lY1JJ LZn8Mrr3ADCbXwbNnowFs84RiEs2DsvUpQ== X-Received: by 2002:a17:90a:eb0c:: with SMTP id j12mr2392334pjz.116.1627964123475; Mon, 02 Aug 2021 21:15:23 -0700 (PDT) Received: from localhost.localdomain (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id c23sm13718532pfn.140.2021.08.02.21.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 21:15:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 32/55] target/s390x: Use MO_128 for 16 byte atomics Date: Mon, 2 Aug 2021 18:14:20 -1000 Message-Id: <20210803041443.55452-33-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210803041443.55452-1-richard.henderson@linaro.org> References: <20210803041443.55452-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , David Hildenbrand Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/s390x/tcg/mem_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index ec88f5dbb0..3782c1c098 100644 --- a/target/s390x/tcg/mem_helper.c +++ b/target/s390x/tcg/mem_helper.c @@ -1810,7 +1810,7 @@ void HELPER(cdsg_parallel)(CPUS390XState *env, uint64_t addr, assert(HAVE_CMPXCHG128); mem_idx = cpu_mmu_index(env, false); - oi = make_memop_idx(MO_TEQ | MO_ALIGN_16, mem_idx); + oi = make_memop_idx(MO_TE | MO_128 | MO_ALIGN, mem_idx); oldv = cpu_atomic_cmpxchgo_be_mmu(env, addr, cmpv, newv, oi, ra); fail = !int128_eq(oldv, cmpv); @@ -1939,7 +1939,7 @@ static uint32_t do_csst(CPUS390XState *env, uint32_t r3, uint64_t a1, cpu_stq_data_ra(env, a1 + 0, int128_gethi(nv), ra); cpu_stq_data_ra(env, a1 + 8, int128_getlo(nv), ra); } else if (HAVE_CMPXCHG128) { - MemOpIdx oi = make_memop_idx(MO_TEQ | MO_ALIGN_16, mem_idx); + MemOpIdx oi = make_memop_idx(MO_TE | MO_128 | MO_ALIGN, mem_idx); ov = cpu_atomic_cmpxchgo_be_mmu(env, a1, cv, nv, oi, ra); cc = !int128_eq(ov, cv); } else {