From patchwork Tue Aug 3 04:14:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 490850 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:396:0:0:0:0 with SMTP id y22csp308618jap; Mon, 2 Aug 2021 21:21:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJws5EOeJvnfqdyXgPuIRqEM+OiCmqQBc1JgmUvkWzdYxT3HZ0y3vYsjFTrwn8RgL6wKbFIy X-Received: by 2002:a92:c0cc:: with SMTP id t12mr500574ilf.47.1627964500588; Mon, 02 Aug 2021 21:21:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627964500; cv=none; d=google.com; s=arc-20160816; b=CaN7IxHv52UNYUWpoZgXlXilygfXCytD5EEKb0w5P9t22enI6FuerQcJCFzo8034pS yO23KD3r+idwU+YdwvLIsXfhztQfJ4qjJiEd9HA5tvISwZlUVVmODV6KKFiQF+ktk/09 vIuYLk1gq0G6tOvCCag2EtzcgJD+8d+UKCPdX9Mh8SWwB7Vm7hr1R2l65R0abuKIW02R U2mr3tOBwKwDsJKpOrbaj/S1Clmft07QKTjYMFzFjS3WZH0r7t3bRhh5bGTjbqQhNZF6 bMpnaaZgTqOkt/C3deuwjFyRnfOAcgxi0tbl0axFaWb1N4qwRiQRFJdv1o7DRKdm6YZ4 Hq0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=3YfZ/UL664PTCelhcyMYJoABRu6Hh76jEhtzzul4yt8=; b=w7G1n23OcFu/phD1LqK5Bjbsm3X8eHgYT08HI8ylHMF4ezqsamUpdviKPVu6hhc+Hx xcG3I1XFGXgEiveALL9tE8QkkUztD9XrTN0Jz82NYgNPYaP344zK/RyjAk7dpkSl7GU/ GOrTrnZjeWcrbUCizAEJ6Zu/dFHOOpNpvlULHhuO7S6CRZlHDJsKg0lrPs49GDxdSR1A Ba5Bt3BDqse8zsAznE10/o/zr4FjAZRiPGab3/ibvlVZjDCLKNilaVWVZNLymepB1/sZ 95Nn4GD1WHvUgv902rJReL5q6gQ6lR/ympqvy9Wz6npQnsBFNK0d+kUyX9jYm0vw6Xot RqNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AKQZMOFD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w4si15660051ilm.77.2021.08.02.21.21.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Aug 2021 21:21:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AKQZMOFD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAlvw-0005Zu-0N for patch@linaro.org; Tue, 03 Aug 2021 00:21:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAlpa-00037J-Cy for qemu-devel@nongnu.org; Tue, 03 Aug 2021 00:15:06 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:40548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAlpY-0002D1-OW for qemu-devel@nongnu.org; Tue, 03 Aug 2021 00:15:06 -0400 Received: by mail-pl1-x634.google.com with SMTP id c16so22133322plh.7 for ; Mon, 02 Aug 2021 21:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3YfZ/UL664PTCelhcyMYJoABRu6Hh76jEhtzzul4yt8=; b=AKQZMOFDu3jfZF/W4XXAaErD4sM2bnytc//mDM0Cm/vtw4WgPCARkm72zINo4aTJn2 5ZonM3ngy0DtxyNpZW065Wf3R3UtRgf+6HddL7kpIm3QUimqPJtC1tH668PUvzUQqEQ6 XAQZDN61N4eVEzW1s3OAc/sSXjTEP7o/swgZ0iSUq2O0VZffE40ifaakciuEbcdP4Kde u0w8D6yqyo18aaIa/jNqGLlEfqigX2YQvEgTXRP4+gkI9zSTa5KN7f0HNuBX04Xxt8HV oceqNF91NpvSGYIGaOSUsKkEXcfClzLO6s3Epknyia3qewbaWnumVNnVIYM+5IoIKWOG lHhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3YfZ/UL664PTCelhcyMYJoABRu6Hh76jEhtzzul4yt8=; b=D4QYpJ5N6T7/GYLTY8PmpglqzwWYcHKwBXRkMRMy4+pCdlkwlU8B6OxcNJ6hoKvkvT P8Zpu8d+meX51XZCLpSPcHulOnn0IMp/PwwGN/8SoRhJNH5mPiq4wq9zYEWD3CduBZ1j N5ut/kq072yUuBrMUJgMA6eW4GHgKnFxMpeww9TQQ+FeA8keBtAgSKwV9pgEtszqjsFh fXFhFmdbjb+Wkj6ED+n1UlyJyOjn+xjG27uIwSHn21QYkkO+dIHZ54ASVM/HMTrpCaJL SNSV5onffnfTrXy6QQBdZfm7woGxq3CzuZt22BpXIn+iAzHLvSLuTkB5G73+LnICpMZ9 h7YQ== X-Gm-Message-State: AOAM533etcR9K0z1eD4comJrRWZn5FPAM5kii6dNF6veUqAKpef5CdNa DbRzhdIWKEmzN12TminZ14lyXwOWRjda6Q== X-Received: by 2002:a05:6a00:1508:b029:332:3aab:d842 with SMTP id q8-20020a056a001508b02903323aabd842mr20040884pfu.59.1627964103510; Mon, 02 Aug 2021 21:15:03 -0700 (PDT) Received: from localhost.localdomain (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id c23sm13718532pfn.140.2021.08.02.21.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 21:15:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 15/55] target/sparc: Remove DEBUG_UNALIGNED Date: Mon, 2 Aug 2021 18:14:03 -1000 Message-Id: <20210803041443.55452-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210803041443.55452-1-richard.henderson@linaro.org> References: <20210803041443.55452-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The printf should have been qemu_log_mask, the parameters themselves no longer compile, and because this is placed before unwinding the PC is actively wrong. We get better (and correct) logging on the other side of raising the exception, in sparc_cpu_do_interrupt. Cc: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.25.1 Reviewed-by: Mark Cave-Ayland diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 22327d7d72..974afea041 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -27,7 +27,6 @@ //#define DEBUG_MMU //#define DEBUG_MXCC -//#define DEBUG_UNALIGNED //#define DEBUG_UNASSIGNED //#define DEBUG_ASI //#define DEBUG_CACHE_CONTROL @@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env, target_ulong addr, uint32_t align, uintptr_t ra) { if (addr & align) { -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, ra); } } @@ -1968,10 +1963,6 @@ void QEMU_NORETURN sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr, SPARCCPU *cpu = SPARC_CPU(cs); CPUSPARCState *env = &cpu->env; -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr); } #endif