From patchwork Mon Jul 26 21:47:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 485873 Delivered-To: patch@linaro.org Received: by 2002:a17:907:d92:0:0:0:0 with SMTP id go18csp4018663ejc; Mon, 26 Jul 2021 14:53:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1cuxc24rp+/iOmyT8aHGFgzdhqcenRr5aOlhVRLo7nZn+gUUc1Kg0VAlJP6MSAM8pNOEc X-Received: by 2002:a92:dcc5:: with SMTP id b5mr14823013ilr.234.1627336425405; Mon, 26 Jul 2021 14:53:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627336425; cv=none; d=google.com; s=arc-20160816; b=0My++4UXBn4tT06A4WBRjj9RbGEZSvr/lUJwyQDWMPQ/I+x/J+FDpey2l15L4adpga VTzzS1S4Pxxd/391cyDE8jzxbwdzOAD8E+8f4R6FxurMfjKUJuYf5j0XxgBS1x/mgsAi ux/hYVjMo5F8j90sFObGGbpmUaYJ1wHcUMLEc8R4tfC55ssDG/yl6TxmqKVbIsUTi/mJ g5iRAgqUZsey2TOf+l5498f87udZLAZnBOArdmOPYluhCSlTiuVW1HhtPy9fFny1W08S 9xgh97Yj/9mQB7Q03i675Sco+mfpJgnzP844ZdZaFL3lnnYjS/oVRQ5C941sDzkPes5t 35fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ulypwX8cmbI95lC2kA6TSEHH51l/u0q3kJ3MExHdI5k=; b=Akoq/Pr1WCef3o0pts6lFSJ5ruy3CHNIYvgdeWEVg7fFLriE3oExKsYYDcfcZ0ISR3 XSZ7LaBwW5LnL2tT0JqokWBk2h3l0sbRjK1jPAGUn+9OluCfNQBMFhl8lCkBc69iq/ip q0li9W7AgzqD8rQ59HZeG0kR80rrsSfD39KTC1U1Ckk6cWxFV3XIwiHGwQnOB4B7olzk Dkr+ONQlaKPo4zo/sGZYeH32OD4UeMb33kGOUChYCU6Z/3EMANga/vpFoF5sL07vn4Aw +iBybffGC5PTxvUb+S7cJJJZLdClNYzcn7h3FMdYLLife2oYPu5Ek+vTkBqA/3pM+v/6 dBUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ODbDqhlc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n13si1182862ioj.25.2021.07.26.14.53.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jul 2021 14:53:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ODbDqhlc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m88Xg-0006ip-P9 for patch@linaro.org; Mon, 26 Jul 2021 17:53:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m88Rx-0002z7-SB for qemu-devel@nongnu.org; Mon, 26 Jul 2021 17:47:49 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:41674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m88Rw-0006EO-C3 for qemu-devel@nongnu.org; Mon, 26 Jul 2021 17:47:49 -0400 Received: by mail-pl1-x62c.google.com with SMTP id e14so13367286plh.8 for ; Mon, 26 Jul 2021 14:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ulypwX8cmbI95lC2kA6TSEHH51l/u0q3kJ3MExHdI5k=; b=ODbDqhlcGV2tde0bIQEaH61FUBSHxyE30ZGBDmt5HKWZUkxAPstVBBmTVeE228fKe7 XgI8wwVVwafqYXqZF4LEIMx13SkZZohEXyDFt470L3fC8AZPjqINITgTC+/bkxKHi6jj jY7OgySI8sEesbdTz0a2UdAtIbxkBu/jK8lFfJUWbwei6MDe7D3HYkxYiMd1ayEQgf2W PSIymWAjPuyohzvRpuiBF3JbaontSaQyhVv8e/3WuvXjGyo2RcQppv2XUitlS+KSCCiw vYjPGNWSdOqW9+MkY7nQBr53JSWoiPRyy1A96vbCb5+iNZlhRrevrDeW+uANmMD7z3E2 9l1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ulypwX8cmbI95lC2kA6TSEHH51l/u0q3kJ3MExHdI5k=; b=BP+fwPdPx432DEjM3GiSqyTBQC8GxCuUdoTf5IibVkes8g16NsBjQAom+afvSWMeqG flTI3jdcwUbXAjg9kONF/09+lKDo7lnpFAtXpaCAWECi6ebjoWSyLMSB1vfeUcQs2xmH 3W8X0j5Jl+5wz4zD9BT6NyNlpDc1yQNqjovPx7DCLgoV4Y/V/UqPadxNM5WfuYhSEnye zA+TtRn2pftM4XuDjVBvBCrdJB57RU5+Yix895bMvg5UoYVohjG6+jTcJUSwHe+DjKQt Z6/4FttyLb/jd4URfZRcRZvYNpWt8L8yltNkkTn59DMWd3dknSp81Pl+1W2EDV0UPYfQ DjHw== X-Gm-Message-State: AOAM530PgI0AL2jylhzKtEE+dnUFVR1xLTYL09XhCRZ8m1u9L+dHyP3g r9qwrydPkpSMcqp+oGUc6fV8Bk9ELdwo3w== X-Received: by 2002:a17:902:7b83:b029:12c:2758:1d2d with SMTP id w3-20020a1709027b83b029012c27581d2dmr5395567pll.80.1627336067052; Mon, 26 Jul 2021 14:47:47 -0700 (PDT) Received: from cloudburst.home (2603-800c-3202-ffa7-497b-6ae4-953c-7ad1.res6.spectrum.com. [2603:800c:3202:ffa7:497b:6ae4:953c:7ad1]) by smtp.gmail.com with ESMTPSA id e8sm997679pfm.218.2021.07.26.14.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 14:47:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-6.1 10/12] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write Date: Mon, 26 Jul 2021 11:47:27 -1000 Message-Id: <20210726214729.2062862-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210726214729.2062862-1-richard.henderson@linaro.org> References: <20210726214729.2062862-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , David Gibson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" >From clang-13: hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \ [-Werror,-Wunused-but-set-variable] It's pretty clear that we meant to write back 'v' after all that computation and not 'val'. Acked-by: David Gibson Acked-by: Benjamin Herrenschmidt Reviewed-by: Cédric Le Goater Signed-off-by: Richard Henderson --- hw/pci-host/pnv_phb4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index 54f57c660a..5c375a9f28 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val) v &= 0xffffffffffff0000ull; v |= 0x000000000000cfffull & val; } - *tptr = val; + *tptr = v; break; } case IODA3_TBL_MBT: