diff mbox series

[PULL,21/28] plugins/cache: Fixed a bug with destroying FIFO metadata

Message ID 20210723170354.18975-22-alex.bennee@linaro.org
State Accepted
Commit de9fc40f36ab8e696d1c69727e80a80c46f20978
Headers show
Series doc, metadata, plugin and testing updates | expand

Commit Message

Alex Bennée July 23, 2021, 5:03 p.m. UTC 
From: Mahmoud Mandour <ma.mandourr@gmail.com>


This manifests itself when associativity degree is greater than the
number of sets and FIFO is used, otherwise it's also a memory leak
whenever FIFO was used.

Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20210714172151.8494-2-ma.mandourr@gmail.com>
Message-Id: <20210720232703.10650-22-alex.bennee@linaro.org>

-- 
2.20.1
diff mbox series

Patch

diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c
index bf0d2f6097..4a71602639 100644
--- a/contrib/plugins/cache.c
+++ b/contrib/plugins/cache.c
@@ -200,7 +200,7 @@  static void fifo_destroy(Cache *cache)
 {
     int i;
 
-    for (i = 0; i < cache->assoc; i++) {
+    for (i = 0; i < cache->num_sets; i++) {
         g_queue_free(cache->sets[i].fifo_queue);
     }
 }