From patchwork Wed Jul 21 06:41:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 483239 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp5903223jao; Tue, 20 Jul 2021 23:42:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTgY1nBZTy64epJ5xJlL/6uoPFaiDn9vQsDlPihTpllJlp/Nf74Zmc7yFttM85oDZVbCqN X-Received: by 2002:a25:da84:: with SMTP id n126mr43007943ybf.412.1626849763719; Tue, 20 Jul 2021 23:42:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626849763; cv=none; d=google.com; s=arc-20160816; b=Fkbd4grWlsvPANTqBHNwC7RvJWiZu/iYKDMTUS2j9XLfZw9Ml1NafSEHVDA6fnX/tl eyT8LHCHlyxAljuaPuHgH9TMKogei64aOttxaLc8Q+XJ8IEyTkDjoC/OqiFUTNFWTQo0 WSyEoXXgb1qB80/ieBrp8dQNns0HWrt0g8w9FaY4qQXAQrx9BKAEkNeRZbuaUTnHPIAg vwjG0cyQ+GXUgdG4sYTdDd8/4lxjK9nn+oppdrco2TC4tRfZkQ7iDDxjOSVF/jpZX5Gz vJZ2MJFYCppcbqNPA27f5m3Ro9WolrlOQwoPGstXYE/aQp43gTkopn/AFkd59Jfz1Bl4 QY5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=pwrBjNjNNTyCMJtkAsuRpXBoHyTgIOoOTRWqB1Tn0SI=; b=00zcSxu9+BP1ZcjlBGGJ7u7sp811+oXd9TQMQByU/KlUVhn1A74/fx2TmEdtea+i7h RZo4n6CasZaBVozUEPHzvCMhkCFtnBp2Mah7ddzPAsmB/1ljPM8WBciqfApwWRQd9X5t PiKVEFWgA6YaZMlqur9MbRc1yh27PQlyL/yyOLgfqIYLytOlflLt/DNdhtqmMefri2HD L1Fb8900vJ5E3Gc4YkPkzPlCajjglK9JD1DYT01G5N+Dh11RXfKfTEj705Qr6l9MoGOw 4+iXLT1sGb9KfUyF33cTxazaNBMXfwPD8QCx60RhiVM9ZD7AO0RylOQJQdk+zCTufiZO rEjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zcovy3ku; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b38si23524550ybj.257.2021.07.20.23.42.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Jul 2021 23:42:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zcovy3ku; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m65wJ-0005C0-6h for patch@linaro.org; Wed, 21 Jul 2021 02:42:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m65vk-00056P-Fx for qemu-devel@nongnu.org; Wed, 21 Jul 2021 02:42:08 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:35821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m65vi-0005Ri-RU for qemu-devel@nongnu.org; Wed, 21 Jul 2021 02:42:08 -0400 Received: by mail-pl1-x62c.google.com with SMTP id n11so489009plc.2 for ; Tue, 20 Jul 2021 23:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=pwrBjNjNNTyCMJtkAsuRpXBoHyTgIOoOTRWqB1Tn0SI=; b=zcovy3kufBWQ0yTqYFynM39cw8KgGmeuFocC4SFAWC/i/xc+5JuB7fw0yL464hiu94 Hyecy8O0PHWzxR2nVbbXjVPvZcMPKmi5JeCIr3PlOhL6aFXKNod+NArRlMaqkElBbm2n m7OYn4jm5upzLCF/HTRpqZ6J2FTDjeXgn+PaVM2yjy0dquZEyGZ2lYm5WDDpxGduzdDk /4Lgh7YOCBVXAXR4FSGiY6D5QFn9kegyQnAmjRwBcdKvfUgxI3Yq3sN3EfL91m0/+VdF DEtYWqA6J5Op4saOqP2QRaTMIaDiMyG1wZbS9w8VXEsAjMdQYjgvW1LFdKN/Kc9DofdA 8zeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pwrBjNjNNTyCMJtkAsuRpXBoHyTgIOoOTRWqB1Tn0SI=; b=ITlDnsXHy+rcC3is+wplBYZtT/EmMVWuBDHVVGIYQXLTEQtG0AJTgV+5aNA3b1Bw++ WXTUn+QcNXmI5E5q3YHWsuqOolWOe74RgzGo6CFCXIdTPi1cC68gJZwq7CwmvNAU/huD EuFKx8hI9NSIfDIRL4rtq6Ib9xtEIpXXNivc90NWd2MnBELm4rptnQaZ7kj3CsUwrG3a RBYAfDu06rYENZi44OWL4LYFiy5jxmuCRlMH3oJ9pxHdsWoCIf582IJQ00qsnHRGgHhw 89tM6XN/I8B7IrNxiUYDIc1wsfQiPsyXS5TceQdM49AIUI5Ecpnsnposcf4GfHXMaZkK 6wzA== X-Gm-Message-State: AOAM531fPcfw3HvhOyOQgClwhwFJ1JgRnc4BnMGFncak5NqDjTJcPYIB mpE7Qfl3oa6I6c0a45KSpuhsjsVox7IGrw== X-Received: by 2002:a17:903:32c5:b029:12b:9107:8684 with SMTP id i5-20020a17090332c5b029012b91078684mr8504556plr.73.1626849725409; Tue, 20 Jul 2021 23:42:05 -0700 (PDT) Received: from localhost.localdomain (204-210-126-223.res.spectrum.com. [204.210.126.223]) by smtp.gmail.com with ESMTPSA id q17sm21146132pjd.42.2021.07.20.23.42.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 23:42:05 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH for-6.2 07/23] target/hppa: Drop checks for singlestep_enabled Date: Tue, 20 Jul 2021 20:41:39 -1000 Message-Id: <20210721064155.645508-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210721064155.645508-1-richard.henderson@linaro.org> References: <20210721064155.645508-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) -- 2.25.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b18150ef8d..9e0524efef 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -817,11 +817,7 @@ static void gen_goto_tb(DisasContext *ctx, int which, } else { copy_iaoq_entry(cpu_iaoq_f, f, cpu_iaoq_b); copy_iaoq_entry(cpu_iaoq_b, b, ctx->iaoq_n_var); - if (ctx->base.singlestep_enabled) { - gen_excp_1(EXCP_DEBUG); - } else { - tcg_gen_lookup_and_goto_ptr(); - } + tcg_gen_lookup_and_goto_ptr(); } } @@ -2349,11 +2345,7 @@ static bool do_rfi(DisasContext *ctx, bool rfi_r) gen_helper_rfi(cpu_env); } /* Exit the TB to recognize new interrupts. */ - if (ctx->base.singlestep_enabled) { - gen_excp_1(EXCP_DEBUG); - } else { - tcg_gen_exit_tb(NULL, 0); - } + tcg_gen_exit_tb(NULL, 0); ctx->base.is_jmp = DISAS_NORETURN; return nullify_end(ctx); @@ -4277,10 +4269,9 @@ static void hppa_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) nullify_save(ctx); /* FALLTHRU */ case DISAS_IAQ_N_UPDATED: - if (ctx->base.singlestep_enabled) { - gen_excp_1(EXCP_DEBUG); - } else if (is_jmp != DISAS_IAQ_N_STALE_EXIT) { + if (is_jmp != DISAS_IAQ_N_STALE_EXIT) { tcg_gen_lookup_and_goto_ptr(); + break; } /* FALLTHRU */ case DISAS_EXIT: