From patchwork Mon Jul 19 21:22:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 480056 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4506854jao; Mon, 19 Jul 2021 14:28:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrx2ZV1F7J7NE1T0Vwdaz7uzo3KDpHJ+sp10KsW+zV0p650kh3fI57dJjVNXMQjede8NhF X-Received: by 2002:ac8:647:: with SMTP id e7mr23267667qth.156.1626730095161; Mon, 19 Jul 2021 14:28:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626730095; cv=none; d=google.com; s=arc-20160816; b=PVSStLnPIxLNH0+Z3/9DICkGsC0E6e1YQX2HB8stOWOST3t7CZX/16Bjk7uR/Jrb+i j/H7Xkvp6RwUuzei9cUbGnY00w+FwrBCLrJYosj0l6XEyIQO7MLFQX4zhgsKJ3xU66OT LzYAMF92ovH6Mqwt7Bou9clJKHjWy37IEvg3SICgWtnrpl1XPQj4QJ4juzQTug4iwhbM naLXg/OPOYeZ5SpAy7Sa/lmXKgitIPEjdmlRarY/HrjU6WW+rECBRMpO5a2FIFfNzM+f QJyAxvI5Tu27kURA2T1flZGiaCpjtilL94RLOay92kS28WLoABKnLKp4vTIYKwK56gCP YuWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=yz3cpE1v3usKVqxRjbCaLbAnRr3RaTGtZYXFSmK7X+Q=; b=z7elHWnVgXjXgUklLJhRmCKqqXfZc5xwGvnjKZgWKeZSpm2q9lIm04ZsMCiKuuKDSr l0kTBQikQUXanLLj3r39G9eKd4gCin/arzjLyywENmIQturnIlYBRvy6yzag16zwjCMv l+e6VeB06dLh1qtUeYwdu+ZCNbtzxXKSABSyN3Y9bWnKi0uE4g7i7XYS0SmWlv3+Xo7i GyBaJ6p7cjGY2ndy5lzWmUGKfGa1pnhCiTaaURYz0T9nP+azh0IJxBaUXPC17alAXZtC tEDOkkpG4rPSkGSikCj+nqwanXdMwqWIN+DWdQ04KF/e6Xhd3e9JkX+X8IrCUNSviUqf 9okg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Vuj59YEt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w5si16100739qvi.46.2021.07.19.14.28.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Jul 2021 14:28:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Vuj59YEt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5aoA-0008B2-Je for patch@linaro.org; Mon, 19 Jul 2021 17:28:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5aiw-0003sY-Pz for qemu-devel@nongnu.org; Mon, 19 Jul 2021 17:22:50 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:45889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5aiv-0000mh-7o for qemu-devel@nongnu.org; Mon, 19 Jul 2021 17:22:50 -0400 Received: by mail-pg1-x52e.google.com with SMTP id y17so20488106pgf.12 for ; Mon, 19 Jul 2021 14:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yz3cpE1v3usKVqxRjbCaLbAnRr3RaTGtZYXFSmK7X+Q=; b=Vuj59YEt3CTRu3ibvbow28G/DBoewW7w6p4G8Zo/tvRQM31LTx5PGNPNCdHD/pcdTH ndFncCbgW0mHZ5A6Q3IEMkFbGdgjdEBegLCW/3qj5SNUg21PGF+CC27ADqNMgmjP6piT V+/Hxl3bc5PkVG5FagiyJJTnqsU80ME3YB073sNSp63Ni48wHtNTCQ0rgVfT2hhlmKA/ LVi4OoPonu226WvZT3gQaWazkaK96dik47WOITU98EgiiLavbfJHGyg1JI6RYNx7+yDQ +imBFm8UMdYbAgj+Dwe24zcfkRjNAONuJXiC4CBjR9jU63j6j4zp91lTUiy3TME3O8lh taXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yz3cpE1v3usKVqxRjbCaLbAnRr3RaTGtZYXFSmK7X+Q=; b=JVo2U76hQLtMtJ2sMw00NpgApXxCCGwAb4jflusf+3iglSp5BoemeAiVUFRMbYqbD7 Lc+atDjgVYubBRUp1IwI33AW+Tfs0kRJrL/ROzQtPrEiCmSnrua4nMXoMRXxfuaniEWa g+3y/Ynd/8RUwTGxBQH6uhGvbqRdkfprgf3Y/MfE/DAvV4akGqm3mZUoOffzlyuMBWmG LnuQO0y6d36bzCT9eiCQN9N+Y+iuJ695PB2fEs1XB53D9VOZZMIn7AVytKGEqHRuzPMR X8UOrOeiNRMsfSlRUjbUG3stCXc2W/NX6g3WOHIMdaxCTWFjGU6oyC626ljS1SBDHUrc vpUQ== X-Gm-Message-State: AOAM53083K4NLMtVlDwxK7OzoUGhv95/jZvac1aOrtqzawiJIr5pvGTV kLZ/KyOEs9vGYa+xeEZqZh7kHVVMAqO+dQ== X-Received: by 2002:a65:568c:: with SMTP id v12mr27988732pgs.88.1626729767816; Mon, 19 Jul 2021 14:22:47 -0700 (PDT) Received: from localhost.localdomain (204-210-126-223.res.spectrum.com. [204.210.126.223]) by smtp.gmail.com with ESMTPSA id e4sm25008434pgi.94.2021.07.19.14.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 14:22:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH for-6.1 v4 03/15] target/alpha: Drop goto_tb path in gen_call_pal Date: Mon, 19 Jul 2021 11:22:27 -1000 Message-Id: <20210719212239.428740-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210719212239.428740-1-richard.henderson@linaro.org> References: <20210719212239.428740-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk, alex.bennee@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We are certain of a page crossing here, entering the PALcode image, so the call to use_goto_tb that should have been here will never succeed. We are shortly going to add an assert to tcg_gen_goto_tb that would trigger for this case. Signed-off-by: Richard Henderson --- target/alpha/translate.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) -- 2.25.1 diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 103c6326a2..949ba6ffde 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -1207,19 +1207,8 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, int palcode) ? 0x2000 + (palcode - 0x80) * 64 : 0x1000 + palcode * 64); - /* Since the destination is running in PALmode, we don't really - need the page permissions check. We'll see the existence of - the page when we create the TB, and we'll flush all TBs if - we change the PAL base register. */ - if (!ctx->base.singlestep_enabled) { - tcg_gen_goto_tb(0); - tcg_gen_movi_i64(cpu_pc, entry); - tcg_gen_exit_tb(ctx->base.tb, 0); - return DISAS_NORETURN; - } else { - tcg_gen_movi_i64(cpu_pc, entry); - return DISAS_PC_UPDATED; - } + tcg_gen_movi_i64(cpu_pc, entry); + return DISAS_PC_UPDATED; } #endif }