From patchwork Wed Jul 14 18:20:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 476839 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp827578jao; Wed, 14 Jul 2021 11:31:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+OsI9alyNMwO0lYaiwypiUyeOJxhKgwMKzhmovffOMOdHQKWvJ5lCk4FaAqqgv6e6o4DM X-Received: by 2002:a67:df85:: with SMTP id x5mr16216165vsk.3.1626287510136; Wed, 14 Jul 2021 11:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626287510; cv=none; d=google.com; s=arc-20160816; b=deskQiJ37N2V6hXQSUbbdAZ8VinPqxN1MwG6PP6SpWWyH6dJNbzGedkBYquoMU+bj8 5HQ9zJqJ5RS+hkFi8neL7xF9cqvGsv5mtAh+061v3PvpRvwpl07Yl8xqMpoC5y2U1wML DpI3A6lw+GyHtVcVBmYHY3trNVZtS7WLqxD9cSvIXjVZe6D4Vm2muZHMp78XDuZyQ2qF 2VGlm+aPKSrWnXEIT+e7hlenm1G/89L+Bdu7dq3vvqXMnKpDnK7D3MDR2+W7zOStdzI9 nvKmBmlqQXf+Wzx1abjG2TdPrjsTM25xpBQvZQ7PXeRSgNTDu/suE5eLE7d2uCvXfijl Iv3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=esIygr0E9T94j67boLNWQxTQpKP1kT5Tz5kmDwipelY=; b=c1lU7EpbIMCkZ42e4gWzNAOytcvFr4Tlatfrrc5oYWpU6NU4gSLGD+95Im+Qpo9Ohk 6fksLgQCIBhBLZ6D2enHuZdg730E8TX6N8I6JwHERvPRWDbA4qPY0xxKBAXh3tv/Xw2+ 9XZ3R6e7Edv4H19W+/MXVBqvixGIhSYoUi1apbpTGCse3512AYj0k60sjvvoTm9BJIH6 1xaW2cPk74Cmkf84j4nnbPbLYbnXvf557/xsTwj5bfZ7jRLD+480pAz7Gm8Ur63U8a+o LIQWwS/c6Ee3QVBGr6eBYIsNie2gAb81T++xu14ftgH4JLyElO9OuK11HgttvGbrbvou D4WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ryVyDvzd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i15si3886657vsf.236.2021.07.14.11.31.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jul 2021 11:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ryVyDvzd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3jfh-0008Rw-JC for patch@linaro.org; Wed, 14 Jul 2021 14:31:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3jVL-0003UX-5Q for qemu-devel@nongnu.org; Wed, 14 Jul 2021 14:21:07 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:42855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3jVJ-00020z-PB for qemu-devel@nongnu.org; Wed, 14 Jul 2021 14:21:06 -0400 Received: by mail-wr1-x42f.google.com with SMTP id r11so4351966wro.9 for ; Wed, 14 Jul 2021 11:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=esIygr0E9T94j67boLNWQxTQpKP1kT5Tz5kmDwipelY=; b=ryVyDvzdctBufGibagFnA7SHtJGHxjGenjQoJEWdkgHZwa+8Cvq5br0u52Xy4Vh3S8 WJT6axb+OiCXJGbpCIEPe3iR1pqz2IG2+d0ADOcEEZMp4DaGzdbWXB5YmnNkKmt/VGGO zkQ0wKv6A9i59HDopaZK4V6IuF+dngJhA6ZZ0Wk7ke/cx5HTM8QPKLGEwfdrTkD6i3qQ 9P1twRUkXj+a5lWTpTi5pF1oBwpBTTYKHmRYdYbk7jTjcwZLYCdFaJwuAbf9XK1Vm2WC 87LAcd/r5Is2odY1e4fggIUXTeuEhM1DGzmv+G7z6jWfHwhbpNoBeJlD6u+oSPHReF/A 2xvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=esIygr0E9T94j67boLNWQxTQpKP1kT5Tz5kmDwipelY=; b=Rf2P0p7aARkCGUpZyGeOwok+UICNVtprB46TKPDgHHJg7xxhI+E4mlJdMLQhcJ8Dhp oWuFVkWgTLiCbL7oErTlc78cmI6/vZwbdn3ybL9AimWGZVxwgN/hJTgNY49ZyP9/vnuM fyQQwDpySd73zjGsTjWlq9QAVUDz5DN0ZZH9ARtLb1S6nxtutwfln+wI5dOP3vzwsXNX kbyNS12WJQ9GES5UIZMnoOCQ3vrJG25IuVDwUXERbl+tHGcJolhDJzXiOeDbd0u5znEl SMx8kfgtN07Wvzb0biQt15HpNL6r7erq+II6UA3GFaMlEUC8FFnOvKSlMPKFtv5tG+IZ rRbQ== X-Gm-Message-State: AOAM530QPmAaPQ1b2Kklms++kXaDbXmMw4cPD+NYAIFfqySSkBPS0a0n IX/rz7EYfRLi+VPEQSd0Wg6j+g== X-Received: by 2002:a05:6000:1048:: with SMTP id c8mr14380181wrx.202.1626286864401; Wed, 14 Jul 2021 11:21:04 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p8sm4820363wmc.24.2021.07.14.11.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 11:21:01 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 08A7C1FF90; Wed, 14 Jul 2021 19:20:57 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 04/21] configure: remove needless if leg Date: Wed, 14 Jul 2021 19:20:39 +0100 Message-Id: <20210714182056.25888-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210714182056.25888-1-alex.bennee@linaro.org> References: <20210714182056.25888-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" It was pointed out in review of the previous patch that the if leg isn't needed as the for loop will not enter on an empty $device_archs. Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build") Signed-off-by: Alex Bennée Message-Id: <20210714093638.21077-5-alex.bennee@linaro.org> --- configure | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/configure b/configure index 4d0a2bfdd8..013f327f4a 100755 --- a/configure +++ b/configure @@ -5083,12 +5083,10 @@ if test "$skip_meson" = no; then echo "[properties]" >> $cross # unroll any custom device configs - if test -n "$device_archs"; then - for a in $device_archs; do - eval "c=\$devices_${a}" - echo "${a}-softmmu = '$c'" >> $cross - done - fi + for a in $device_archs; do + eval "c=\$devices_${a}" + echo "${a}-softmmu = '$c'" >> $cross + done test -z "$cxx" && echo "link_language = 'c'" >> $cross echo "[built-in options]" >> $cross