From patchwork Wed Jul 14 09:37:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 476424 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp395864jao; Wed, 14 Jul 2021 02:43:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwV+Yu0BCGMreigSt0QFipRVY1o1a32RBOFp4zFCXgUMRYTnasUCVZQEDBth2wQkVNVGibh X-Received: by 2002:ac8:7408:: with SMTP id p8mr2899529qtq.203.1626255830850; Wed, 14 Jul 2021 02:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626255830; cv=none; d=google.com; s=arc-20160816; b=SbDgq94IeIl8XOwKADFTIKfJWGO3vUdqKKPpk/DzuLGXhB22bDaBb7+M4DSu0MeYNQ KfUS+P87L1ovjAhLvabMXr9SrsXwZudar/A59LcqPMfzEC+pyptyoDRr21cKEZAzTeN8 k8WvIKb6fqAMlYYamwOVG7CsjqonPG8SEk/OgtB+MYFl6Jek4qsOVsT7ZITlZ2jzCefe 34FroR+BAdRCNwQChw/7DSwYxrjz3v5St8f4Y2jDpEU3BZEynBC/VNrwVlGKkDWkhckN fl3vZEB9MTfkTf3OJcr10YOFfe/Qf/XSceJ+sx9CIjSqt1ftnl7cr6PRrAJnZzypp3R7 PVFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1YFfcNF4LkvFeRrj0McNGwJ95momCe8V6bBvEw7Hvfw=; b=KBzYqNd2eHK8vhmVx4G3b5Mt5XwtbLLBQEHtAiyTu9bHpcQx5Hb4RBKSJ94XsSc1Fk ZReH387veFRvKjO7kNh+NiiqICQ59pjqZT6D2799uAlD+ot/Tf0NlgRt4iLNi+Q5+pTU X0LHBNVw+1hxRfJx1QQ4L3c3ADuMAw4Tp8GMH/CeaM5kobVWdwn1xeoFscR4d9zsYgIQ hjvYcktYEFDc91cv7fylxeGRmhfHpPe++4RMFXfdAptUtzHIfMtwURJMYvaRcj/t63YJ MxF4ZxptzstGKITXkEDxw/pPOZfQudwLDFOBabt5fBkKLmIgqM+LsnHWcDBbLTKlLJu4 Ko0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UqNGForL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 13si1894980qtw.381.2021.07.14.02.43.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jul 2021 02:43:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UqNGForL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:36082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3bQk-0005PC-96 for patch@linaro.org; Wed, 14 Jul 2021 05:43:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3bKY-00032d-VQ for qemu-devel@nongnu.org; Wed, 14 Jul 2021 05:37:27 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:37503) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3bKX-0004fv-JL for qemu-devel@nongnu.org; Wed, 14 Jul 2021 05:37:26 -0400 Received: by mail-wr1-x432.google.com with SMTP id i94so2395939wri.4 for ; Wed, 14 Jul 2021 02:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1YFfcNF4LkvFeRrj0McNGwJ95momCe8V6bBvEw7Hvfw=; b=UqNGForLMMp19Lw5UIA4gWcyAfFmTBl643TKoPa029Kd5J43mWkJS7CJ55wO+QRRzq Tw0pWMug8PAkkes9lWu1i/tI5Gwmygb1SPx8Sq+Eq26p3vi+q3U6tEkFuVto3KtLLSfl bDM9gHY8laqQMVmWOlEMtKvbT6h0/WnuI99fsBIipH6tefFKUKNvGXh5HLULHNPbIdMU Zese1ScBX/YURUO29cS34UUAyzL+STHIpXns0nJSOBo4b8XuxIS92XgpjOl6u0nquH7o 0lVGLy+j4SitxshAil3a2sBFNh8M/BO9sWq5kE0xBMLthFtlP/XuSzWcaB97R6i9fD5r lBNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1YFfcNF4LkvFeRrj0McNGwJ95momCe8V6bBvEw7Hvfw=; b=b2cHY1xOun3jaiFJX6YJf7eQ2cQdDXBtsqEcnzVqSvLGytdeXFrN7iQ678J2F0iHdK Smp5ZLobsqTL0qmBKMkpCy/TNM5MWjGoy5ec2uEic5hxyXCRkr/qMnPjpbaO0J91VtsS WUyYAbuKGUYFmx0YsR/ldn+qgCztsS8AgFL7kFbCzdqLALwQlpjJ6bQOUP+c8r73Obhd Y8QFtTeE4DOamFFYSIFRBzaFK1lGA15xF1JJ3UqrZ8+QAOAl1qGEIyR+jkLODRQ8RuWu hupuxqZGBac/yqaRqd1KbDTLMmGkLnPUS+j2aMoQU80cvQOaYVFMyLO7Q3plCZPw1YQ6 HjVg== X-Gm-Message-State: AOAM531Qu2tMTRT45FDo+I4y61pQB22gzosmuF3Ve2BK6IL5GIu5W/Vp MBhDDqbLiVjwUieWHH4uN/Zw/Q== X-Received: by 2002:a5d:4a44:: with SMTP id v4mr11451804wrs.219.1626255444287; Wed, 14 Jul 2021 02:37:24 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p9sm1837495wrx.59.2021.07.14.02.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 02:37:20 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0782E1FF98; Wed, 14 Jul 2021 10:37:20 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 04/21] configure: remove needless if leg Date: Wed, 14 Jul 2021 10:37:02 +0100 Message-Id: <20210714093719.21429-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210714093719.21429-1-alex.bennee@linaro.org> References: <20210714093719.21429-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" It was pointed out in review of the previous patch that the if leg isn't needed as the for loop will not enter on an empty $device_archs. Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build") Signed-off-by: Alex Bennée --- configure | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.20.1 diff --git a/configure b/configure index 4d0a2bfdd8..013f327f4a 100755 --- a/configure +++ b/configure @@ -5083,12 +5083,10 @@ if test "$skip_meson" = no; then echo "[properties]" >> $cross # unroll any custom device configs - if test -n "$device_archs"; then - for a in $device_archs; do - eval "c=\$devices_${a}" - echo "${a}-softmmu = '$c'" >> $cross - done - fi + for a in $device_archs; do + eval "c=\$devices_${a}" + echo "${a}-softmmu = '$c'" >> $cross + done test -z "$cxx" && echo "link_language = 'c'" >> $cross echo "[built-in options]" >> $cross