diff mbox series

[v2,30/39] configure: stop user enabling plugins on Windows for now

Message ID 20210708190941.16980-31-alex.bennee@linaro.org
State Superseded
Headers show
Series testing and plugins pre-PR series | expand

Commit Message

Alex Bennée July 8, 2021, 7:09 p.m. UTC 
There are some patches on the list that enable plugins on Windows but
they still need some changes to be ready:

  https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/

In the meantime lets stop the user from being able to configure the
support so they don't get confused by the weird linker error messages
later.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Cc: Yonggang Luo <luoyonggang@gmail.com>

---
v2
  - move targetos check to if we try to --enable-plugins, default no otherwise
---
 configure | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.20.1

Comments

Richard Henderson July 8, 2021, 8:33 p.m. UTC | #1 
On 7/8/21 12:09 PM, Alex Bennée wrote:
> There are some patches on the list that enable plugins on Windows but

> they still need some changes to be ready:

> 

>    https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/

> 

> In the meantime lets stop the user from being able to configure the

> support so they don't get confused by the weird linker error messages

> later.

> 

> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>

> Cc: Yonggang Luo<luoyonggang@gmail.com>

> 

> ---

> v2

>    - move targetos check to if we try to --enable-plugins, default no otherwise

> ---

>   configure | 7 ++++++-

>   1 file changed, 6 insertions(+), 1 deletion(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
diff mbox series

Patch

diff --git a/configure b/configure
index 7f906be68d..43f4d3220a 100755
--- a/configure
+++ b/configure
@@ -708,6 +708,7 @@  MINGW32*)
     audio_drv_list=""
   fi
   supported_os="yes"
+  plugins="no"
   pie="no"
 ;;
 GNU/kFreeBSD)
@@ -1510,7 +1511,11 @@  for opt do
   ;;
   --disable-xkbcommon) xkbcommon="disabled"
   ;;
-  --enable-plugins) plugins="yes"
+  --enable-plugins) if "$targetos" = "MINGW32"; then
+                        error_exit "TCG plugins not currently supported on Windows platforms"
+                    else
+                        plugins="yes"
+                    fi
   ;;
   --disable-plugins) plugins="no"
   ;;