diff mbox series

[PULL,6/7] tests/tcg: skip the signals test for hppa/s390x for now

Message ID 20210625091355.25673-7-alex.bennee@linaro.org
State Accepted
Commit f101c9fe29cfb009a7e20b68142a575b3384a4d0
Headers show
Series misc fixes (docs, plugins, tests) | expand

Commit Message

Alex Bennée June 25, 2021, 9:13 a.m. UTC
There are fixes currently in flight but as this is getting in the way
of a green CI we might as well skip for now. For reference the fix
series are:

  linux-user: Move signal trampolines to new page
  20210616011209.1446045-1-richard.henderson@linaro.org

and

  linux-user: Load a vdso for x86_64 and hppa
  20210619034329.532318-1-richard.henderson@linaro.org

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Acked-by: Cornelia Huck <cohuck@redhat.com>

Cc: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210623102749.25686-7-alex.bennee@linaro.org>

-- 
2.20.1

Comments

Philippe Mathieu-Daudé Sept. 11, 2021, 9:57 p.m. UTC | #1
On Fri, Jun 25, 2021 at 11:21 AM Alex Bennée <alex.bennee@linaro.org> wrote:
>

> There are fixes currently in flight but as this is getting in the way

> of a green CI we might as well skip for now. For reference the fix

> series are:

>

>   linux-user: Move signal trampolines to new page

>   20210616011209.1446045-1-richard.henderson@linaro.org

>

> and

>

>   linux-user: Load a vdso for x86_64 and hppa

>   20210619034329.532318-1-richard.henderson@linaro.org

>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> Acked-by: Cornelia Huck <cohuck@redhat.com>

> Cc: Richard Henderson <richard.henderson@linaro.org>

> Message-Id: <20210623102749.25686-7-alex.bennee@linaro.org>

>

> diff --git a/tests/tcg/hppa/Makefile.target b/tests/tcg/hppa/Makefile.target

> index 8bf01966bd..71791235f6 100644

> --- a/tests/tcg/hppa/Makefile.target

> +++ b/tests/tcg/hppa/Makefile.target

> @@ -4,3 +4,7 @@

>

>  # On parisc Linux supports 4K/16K/64K (but currently only 4k works)

>  EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536

> +

> +# There is a race that causes this to fail about 1% of the time

> +run-signals: signals

> +       $(call skip-test, $<, "BROKEN awaiting vdso support")

> diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target

> index 241ef28f61..0036b8a505 100644

> --- a/tests/tcg/s390x/Makefile.target

> +++ b/tests/tcg/s390x/Makefile.target

> @@ -8,3 +8,7 @@ TESTS+=exrl-trtr

>  TESTS+=pack

>  TESTS+=mvo

>  TESTS+=mvc

> +

> +# This triggers failures on s390x hosts about 4% of the time

> +run-signals: signals

> +       $(call skip-test, $<, "BROKEN awaiting sigframe clean-ups")


Odd, still failing?
https://app.travis-ci.com/gitlab/qemu-project/qemu/jobs/536639512#L12456
diff mbox series

Patch

diff --git a/tests/tcg/hppa/Makefile.target b/tests/tcg/hppa/Makefile.target
index 8bf01966bd..71791235f6 100644
--- a/tests/tcg/hppa/Makefile.target
+++ b/tests/tcg/hppa/Makefile.target
@@ -4,3 +4,7 @@ 
 
 # On parisc Linux supports 4K/16K/64K (but currently only 4k works)
 EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536
+
+# There is a race that causes this to fail about 1% of the time
+run-signals: signals
+	$(call skip-test, $<, "BROKEN awaiting vdso support")
diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
index 241ef28f61..0036b8a505 100644
--- a/tests/tcg/s390x/Makefile.target
+++ b/tests/tcg/s390x/Makefile.target
@@ -8,3 +8,7 @@  TESTS+=exrl-trtr
 TESTS+=pack
 TESTS+=mvo
 TESTS+=mvc
+
+# This triggers failures on s390x hosts about 4% of the time
+run-signals: signals
+	$(call skip-test, $<, "BROKEN awaiting sigframe clean-ups")