From patchwork Fri Jun 11 23:41:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 458540 Delivered-To: patch@linaro.org Received: by 2002:a17:907:7409:0:0:0:0 with SMTP id gj9csp706862ejc; Fri, 11 Jun 2021 16:48:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdLDJT3+wNyRaculzXY9KJ/aPOD8UFwHECvXUdZtdLoiYHIx0hn/nfOr7Fal4rncJiLk/3 X-Received: by 2002:a02:7110:: with SMTP id n16mr6089172jac.69.1623455299035; Fri, 11 Jun 2021 16:48:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623455299; cv=none; d=google.com; s=arc-20160816; b=ms/fWunUuwptEzU664x4Mp/KIEElyw+aYv8tzTK6ImBAAkNo7xpdc9e+lv2ouDlb29 f8jbS0P0Z4uAHFezGkDZI1Q2Xqc7IAD4WRHOwQokfNMnOEqfzVhgHrzrbOYzeXjaUrKG J8vZrOK++1qSUyqkr7Sp5LE9iDW2cXc7A74U/nY3K+3PqSSW2Z6htCx/qhYAtr3qRh+q qjI+slP0R7ozeN+wGdZJ9/IeYvgTUVRmeCOtDKRb5mEDKIGKLTpdFta9mSGaxccAwaPb FsqkUmwEjNcXFOEBjymvjkWuzTs/ftIs4+v+FHu4ag6cMX338/fn3box4Z6IR5LRYKYE nZXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=DEGK7taWTLgaAQxBCsJBdKV8XPOvsryzrwUIPNhMs30=; b=wVDIDyvSOiXoUSUqJ0Kw1po6HdAucM3soxOfM79B+OX/QmsNDGGM37fxgQPtoFOxcq rbYuGkwsHxCRse1q92kq8yOFyWtd4YLRRRuRB87gBUC+3Gu8KMW8yohil+mWb7BfCFV6 qqzfbWnr3QCjTDFq0cHD3/4jri4kMKGQP9QcIFPgp2l1PIdk26Dbp4VuyybglNO/yYuA 1wXJy9NwZz14YSR+UK6I5Dm4sTLCBaK0p13nQmk+73VrVwEGwCN8N144Y3l1ekG0bc9b h2j/xL4QOesBZbt4DrPCXx7SaS90Ul8XkVoFPGME+FjtJbl2/huRYiwYJKx/92ndugjR ZhLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=RDS9NXO3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z4si8495865iod.34.2021.06.11.16.48.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jun 2021 16:48:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=RDS9NXO3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrqss-0005is-Ac for patch@linaro.org; Fri, 11 Jun 2021 19:48:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrqmv-00036f-Su for qemu-devel@nongnu.org; Fri, 11 Jun 2021 19:42:10 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:35491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrqms-0002mj-BA for qemu-devel@nongnu.org; Fri, 11 Jun 2021 19:42:09 -0400 Received: by mail-pf1-x432.google.com with SMTP id h12so5700133pfe.2 for ; Fri, 11 Jun 2021 16:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DEGK7taWTLgaAQxBCsJBdKV8XPOvsryzrwUIPNhMs30=; b=RDS9NXO3+DcqOqnv2DsN5MNdOijH1reVjSyDyGV8MktpCEEGOPAwucFlVtC19IDmAW FL1sl2e1JhDY7W0DXQ9sGKIpjP6+E6DektVlBkeCCJwbDCh9befju9zMSA1a4p2jtwHy 0iwnUOLaRvWubB1t9eMjxYGTOBBBkhGsECQQK6d0mCl9dobr2dIqIwPmyNuzrPpM5YXX dft3jLUr2V72/4Wc40pCZV6Y2F7LRGS+8+TGWyDc3Tv89GTl0OljILyWMxeQ/hn79oxv x8nOMBA5tO+vwrRe7XoEaC1m28A6LGKyTZukcDkOVkRVi5xxDiHj/mQM/Ds/9c2pmtqF zpnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DEGK7taWTLgaAQxBCsJBdKV8XPOvsryzrwUIPNhMs30=; b=a2epc9UG0VfUH4WQYr4puLGrn+OJ4CPO8oo4b8pfPlzSQLKMjJBab3u9tI0QphWjZx HcpXwFxd/ECEuQPdeqym6Qb3MB3Hq6DmmracXRdAQrnVb6UrHMW9T3/m6Hgexcbzikxl Vyzc5amz16ztmqrQ75xozIQWvtAOjGwxlSl/NUKZEQ95jRSxc3yxDgyEKQuv7FlXK0yq eCswplFePXf000+B6w0YGl3rvBwjscDFcVyiBCyAXFNu0ma2QY5F4cMdet/6I2WdhB0M vCPh+J1BKLdwcbyJFLsuiZYDiaG6wPYnGxDhlO+FlyJYFv+DrHvdLGVO/yedxa9n3Nbd BScw== X-Gm-Message-State: AOAM532g/dpgIkxGYPEnoTB6EX4Af4AfpwWSg+VOdUTtj1BoSfJ92zjw lrm3+PWHFyTie/P5+5mL9QprZykRzB6rxA== X-Received: by 2002:a65:64c8:: with SMTP id t8mr5969601pgv.96.1623454924415; Fri, 11 Jun 2021 16:42:04 -0700 (PDT) Received: from localhost.localdomain (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id q23sm6139829pgm.31.2021.06.11.16.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 16:42:04 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 31/34] tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_* Date: Fri, 11 Jun 2021 16:41:41 -0700 Message-Id: <20210611234144.653682-32-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611234144.653682-1-richard.henderson@linaro.org> References: <20210611234144.653682-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Luis Pires , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" At some point during the development of tcg_constant_*, I changed my mind about whether such temps should be able to be passed to tcg_temp_free_*. The final version committed allows this, but the commentary was not updated to match. Fixes: c0522136adf Reported-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Luis Pires Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h index 1d056ed0ed..064dab383b 100644 --- a/include/tcg/tcg.h +++ b/include/tcg/tcg.h @@ -1095,7 +1095,8 @@ TCGv_vec tcg_const_ones_vec_matching(TCGv_vec); /* * Locate or create a read-only temporary that is a constant. - * This kind of temporary need not and should not be freed. + * This kind of temporary need not be freed, but for convenience + * will be silently ignored by tcg_temp_free_*. */ TCGTemp *tcg_constant_internal(TCGType type, int64_t val);