diff mbox series

[v5,08/23] target/ppc: Use translator_loop_temp_check

Message ID 20210517205025.3777947-9-matheus.ferst@eldorado.org.br
State New
Headers show
Series [v5,01/23] target/ppc: Introduce gen_icount_io_start | expand

Commit Message

Matheus K. Ferst May 17, 2021, 8:50 p.m. UTC
From: Richard Henderson <richard.henderson@linaro.org>


The special logging is unnecessary.  It will have been done
immediately before in the log file.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>

Reviewed-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>

---
 target/ppc/translate.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

-- 
2.25.1

Comments

David Gibson May 18, 2021, 12:20 a.m. UTC | #1
On Mon, May 17, 2021 at 05:50:10PM -0300, matheus.ferst@eldorado.org.br wrote:
> From: Richard Henderson <richard.henderson@linaro.org>

> 

> The special logging is unnecessary.  It will have been done

> immediately before in the log file.

> 

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>

> Reviewed-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>


Applied to ppc-for-6.1, thanks.

> ---

>  target/ppc/translate.c | 6 +-----

>  1 file changed, 1 insertion(+), 5 deletions(-)

> 

> diff --git a/target/ppc/translate.c b/target/ppc/translate.c

> index e68152810e..ea200f9637 100644

> --- a/target/ppc/translate.c

> +++ b/target/ppc/translate.c

> @@ -9091,11 +9091,7 @@ static void ppc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)

>      handler->count++;

>  #endif

>  

> -    if (tcg_check_temp_count()) {

> -        qemu_log("Opcode %02x %02x %02x %02x (%08x) leaked "

> -                 "temporaries\n", opc1(ctx->opcode), opc2(ctx->opcode),

> -                 opc3(ctx->opcode), opc4(ctx->opcode), ctx->opcode);

> -    }

> +    translator_loop_temp_check(&ctx->base);

>  }

>  

>  static void ppc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)


-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
diff mbox series

Patch

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index e68152810e..ea200f9637 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -9091,11 +9091,7 @@  static void ppc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
     handler->count++;
 #endif
 
-    if (tcg_check_temp_count()) {
-        qemu_log("Opcode %02x %02x %02x %02x (%08x) leaked "
-                 "temporaries\n", opc1(ctx->opcode), opc2(ctx->opcode),
-                 opc3(ctx->opcode), opc4(ctx->opcode), ctx->opcode);
-    }
+    translator_loop_temp_check(&ctx->base);
 }
 
 static void ppc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)