From patchwork Mon May 17 18:14:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 440215 Delivered-To: patch@linaro.org Received: by 2002:a02:7a1b:0:0:0:0:0 with SMTP id a27csp1352609jac; Mon, 17 May 2021 11:53:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyg9v9USZSKYRkc8xtr/O6K4pO1H5v6W3ADmsr3SYU5ihhVsPHXyVzGV6xjTZ51FyUJ0C9R X-Received: by 2002:a92:d7c3:: with SMTP id g3mr918922ilq.114.1621277605146; Mon, 17 May 2021 11:53:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621277605; cv=none; d=google.com; s=arc-20160816; b=mnnNQDcfAq4+lv0cfcNyDD+WNGqzbYl7bG2noW6NmXqGMSegg/GMkJWex39YTvuz72 mUZQqB5xMOGwnAhSMv4zav3ZNry2xCoG6utKSUpnvkaNAK6Jkm6plU+f92+iZPVJUQyb Ic4+iHxvwWlZANt+gpslb09xXI51gKPXDNIdkQgO0d9MTSsSQsQ5QVzViR7OJ5YOZLaI 94G6OzxxKuLkqaPUYByKjHj54AE64rE5NEVpnVhpouZVaOu4cDre6rXWs0FmqzQLhKTO fY1L9p/TqzzaEUfcqS5hcp842teFVL9iKnl1v0hI3ELRdPFORha20rIlJ5rcwnEEOEgC TzhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=njA1vIsCq4RtA6O2hMBIync3H+LHwCosZAH7cFlzsH0=; b=Z8tXRHTbUa3Pi4cCCR1RGINtG9c6QxtmnOl9++gW3+y4U25snrW/BXy/DNM/diTtAU xJTZIzoSbxvrNoI30aXWpGw2UG6SJftb/TsXcFJuf4G1Vqo0gfdnViQVV7J+Ry5UaHKP EJLtLsmDYMm6YhKs0+nFAorSebiertjfG/MYatq76SVne1Qw3xuWM3GxMKpKxAge6+dk trc1eB2nY1/0RFNs+aMRAMiseUkFWUoWgND5D8xdzWxX4dwxVM9gcG7XF5o+mFst5nu8 jlCcp4ER+uKkzm6T9WZkB2kmZoyxNQLvV2dvvj3foQ4Kt2k12J4d7gEjNKRDxsY8R37I Hqnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i17si5050432jar.93.2021.05.17.11.53.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 May 2021 11:53:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:48788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liiMm-0004El-II for patch@linaro.org; Mon, 17 May 2021 14:53:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lihlv-0006pi-Ih for qemu-devel@nongnu.org; Mon, 17 May 2021 14:15:25 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:48215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lihlZ-0004Xm-9z for qemu-devel@nongnu.org; Mon, 17 May 2021 14:15:19 -0400 Received: from quad ([82.142.31.78]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MQy0N-1m5aEY3SfH-00O0co; Mon, 17 May 2021 20:14:50 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 45/59] linux-user/s390x: Add build asserts for sigset sizes Date: Mon, 17 May 2021 20:14:10 +0200 Message-Id: <20210517181424.8093-46-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517181424.8093-1-laurent@vivier.eu> References: <20210517181424.8093-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:R6HjJXjyG1ZInBrhVPsshMwqybr4sLAVUEny48o6ZhIf1mi7PzT +PZTF1WmyhaFwMNsvATMX0RKeFdOEhokugXuGupyd/cFeQnOUBpIxVxGELitlxUc7fbUP8o 4aAHZY3ae0iN60PbQewzm9o+v7mfqUD9DhpNot1aFloecxBhuIDbhedXFNn075sbeqFaTMr 6efYBRbsHc4FEEbNN7ZbQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:Z9d6FwXX8vc=:1PwEbhzYXdRekt/aMv7H+Q XRy473ldfFu+pAVKNpeN//U4oez2RfzHHX/8QpcibWXWnbV66guC5rX0VdePq0NCUymdnN2mk 5w4DUga+ApS2eRvM7bXt8kOW6HBNaTBtaFAsdQqQTuL356V9RyMnMF3uf1Cm3ik3NZZw0D7Wy 3sOPfyy7gm16ToHVQRg3O24U/kMUlKOvrWSNvRxypzfsK8gRWMzNAASf1Qi0nbfOQ6pH08gYb rvMWx1bOGajXtx6vrnOJM1CYQlJUei23cK+bPgiQzIl6OvCzQ9KjX4lytjp89BPwK8obeRj7Z 43ODrKnCFXI95qouhGInUCfOp6zu+TnI/BuKEvZc85toaoq3j0fkvBYHuJU5OhEEdvoyJZreL zsSGQA8ed59Hy/jObXoplGNH6P3ElU5zQcW/Ig/Ab/eNsHmkmRkMQevSuKIU3JgfaVr58pVMp 71jWx7rPN85YjC+DXNQJluSL2PVu6CTztBTk6+p0qAvWqU1s3yMFTcmAlaYOF5StAzw/Eabl8 AaNAoafOf3Se+GyuDD4isU= Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Laurent Vivier , David Hildenbrand Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson At point of usage, it's not immediately obvious that we don't need a loop to copy these arrays. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-14-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.31.1 diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 81ba59b46af5..839a7ae4b3d6 100644 --- a/linux-user/s390x/signal.c +++ b/linux-user/s390x/signal.c @@ -141,6 +141,8 @@ void setup_frame(int sig, struct target_sigaction *ka, return; } + /* Make sure that we're initializing all of oldmask. */ + QEMU_BUILD_BUG_ON(ARRAY_SIZE(frame->sc.oldmask) != 1); __put_user(set->sig[0], &frame->sc.oldmask[0]); save_sigregs(env, &frame->sregs); @@ -266,6 +268,9 @@ long do_sigreturn(CPUS390XState *env) force_sig(TARGET_SIGSEGV); return -TARGET_QEMU_ESIGRETURN; } + + /* Make sure that we're initializing all of target_set. */ + QEMU_BUILD_BUG_ON(ARRAY_SIZE(target_set.sig) != 1); __get_user(target_set.sig[0], &frame->sc.oldmask[0]); target_to_host_sigset_internal(&set, &target_set);