diff mbox series

[v4,17/31] target/ppc: Use translator_loop_temp_check

Message ID 20210512185441.3619828-18-matheus.ferst@eldorado.org.br
State Superseded
Headers show
Series [v4,01/31] target/ppc: Add cia field to DisasContext | expand

Commit Message

Matheus K. Ferst May 12, 2021, 6:54 p.m. UTC
From: Richard Henderson <richard.henderson@linaro.org>


The special logging is unnecessary.  It will have been done
immediately before in the log file.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>

---
 target/ppc/translate.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

-- 
2.25.1

Comments

Bruno Piazera Larsen May 12, 2021, 7:45 p.m. UTC | #1
On 12/05/2021 15:54, matheus.ferst@eldorado.org.br wrote:
> From: Richard Henderson <richard.henderson@linaro.org>

>

> The special logging is unnecessary.  It will have been done

> immediately before in the log file.

>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>

> ---

>   target/ppc/translate.c | 6 +-----

>   1 file changed, 1 insertion(+), 5 deletions(-)

>

> diff --git a/target/ppc/translate.c b/target/ppc/translate.c

> index 9912686496..cd4b34aa91 100644

> --- a/target/ppc/translate.c

> +++ b/target/ppc/translate.c

> @@ -9282,11 +9282,7 @@ static void ppc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)

>       handler->count++;

>   #endif

>   

> -    if (tcg_check_temp_count()) {

> -        qemu_log("Opcode %02x %02x %02x %02x (%08x) leaked "

> -                 "temporaries\n", opc1(ctx->opcode), opc2(ctx->opcode),

> -                 opc3(ctx->opcode), opc4(ctx->opcode), ctx->opcode);

> -    }

> +    translator_loop_temp_check(&ctx->base);

>   }

>   

>   static void ppc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)


Reviewed-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>


-- 

Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO 
<https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station>
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 12/05/2021 15:54,
      <a class="moz-txt-link-abbreviated" href="mailto:matheus.ferst@eldorado.org.br">matheus.ferst@eldorado.org.br</a> wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20210512185441.3619828-18-matheus.ferst@eldorado.org.br">
      <pre class="moz-quote-pre" wrap="">From: Richard Henderson <a class="moz-txt-link-rfc2396E" href="mailto:richard.henderson@linaro.org">&lt;richard.henderson@linaro.org&gt;</a>

The special logging is unnecessary.  It will have been done
immediately before in the log file.

Signed-off-by: Richard Henderson <a class="moz-txt-link-rfc2396E" href="mailto:richard.henderson@linaro.org">&lt;richard.henderson@linaro.org&gt;</a>

Signed-off-by: Matheus Ferst <a class="moz-txt-link-rfc2396E" href="mailto:matheus.ferst@eldorado.org.br">&lt;matheus.ferst@eldorado.org.br&gt;</a>

---
 target/ppc/translate.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 9912686496..cd4b34aa91 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -9282,11 +9282,7 @@ static void ppc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
     handler-&gt;count++;
 #endif
 
-    if (tcg_check_temp_count()) {
-        qemu_log("Opcode %02x %02x %02x %02x (%08x) leaked "
-                 "temporaries\n", opc1(ctx-&gt;opcode), opc2(ctx-&gt;opcode),
-                 opc3(ctx-&gt;opcode), opc4(ctx-&gt;opcode), ctx-&gt;opcode);
-    }
+    translator_loop_temp_check(&amp;ctx-&gt;base);
 }
 
 static void ppc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)</pre>
    </blockquote>
    <p>Reviewed-by: Bruno Larsen (billionai)
      <a class="moz-txt-link-rfc2396E" href="mailto:bruno.larsen@eldorado.org.br">&lt;bruno.larsen@eldorado.org.br&gt;</a></p>
    <p>-- </p>
    <div class="moz-signature">Bruno Piazera Larsen<br>
      <a
href="https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&amp;utm_medium=email&amp;utm_source=RD+Station">Instituto
        de Pesquisas ELDORADO</a><br>
      Departamento Computação Embarcada<br>
      Analista de Software Trainee<br>
      <a href="https://www.eldorado.org.br/disclaimer.html">Aviso Legal
        - Disclaimer</a></div>
  </body>
</html>
diff mbox series

Patch

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 9912686496..cd4b34aa91 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -9282,11 +9282,7 @@  static void ppc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
     handler->count++;
 #endif
 
-    if (tcg_check_temp_count()) {
-        qemu_log("Opcode %02x %02x %02x %02x (%08x) leaked "
-                 "temporaries\n", opc1(ctx->opcode), opc2(ctx->opcode),
-                 opc3(ctx->opcode), opc4(ctx->opcode), ctx->opcode);
-    }
+    translator_loop_temp_check(&ctx->base);
 }
 
 static void ppc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)