Message ID | 20210502235727.1979457-15-richard.henderson@linaro.org |
---|---|
State | Superseded |
Headers | show
Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp2396260jao; Sun, 2 May 2021 17:11:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycMwFy5dAm74+FbGJNNmG/nQqv74W65y4MGJemy6RvXm6m5eg3wldR5F6+uifmLnheJ6+y X-Received: by 2002:a92:8751:: with SMTP id d17mr13133214ilm.96.1620000677377; Sun, 02 May 2021 17:11:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620000677; cv=none; d=google.com; s=arc-20160816; b=yMCs2pIETO+r3HLebPuAQUQ9GyqylJ4/UUww0dKiVrchzkC9n/OQV1HmbRund8YFXe i2W7lGpezdySNxOCaBKC/hTXXbACVBOVIXpoQH8mcKPb5V4UfgybSd6IDcnN0N5wAaqm btRU0oqhf+D37dPeezmPXQWCkmflUHH3BcOGqchb3EtrMnwNCJplG6ijUTlJfChnTo1V IFebXsgiEmZy55eN9WNrPmuJLQPiTAEy7jXhy7Zz6IqyFUlzgq9mQ84AWebnfRGmM8G8 Rzhi7GVbmk8ahYlBgFPkWz7ZRun1ONECBTxBCbnqeFHKekAUDWTZcaBqjKlgo5m09Tud 2Egw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=/Lw6h+zhYOb/AKJ1XNWDOgLJcyj6yKfNAsAjmmI79uM=; b=s2qfPOV1Jz6P6Q+z+Tgn8NfyX2UOvxfHzWzDl4mDfQ9cFqb2DPGrSWdvsWOZFAiLbx BBvVax7oxjAeHcWQ485lWeSYfcTG7QVxokBZpr4S97HNOrl68wrAsA2AGrTBnJqXFcT0 3KIZM2D2tVt+1aG4Y94Z8DT0B/rd6IUdZK+BNlb7R91HhvcGrfHGrIZDUwxtUV/nUFL3 4djI8MZ/Ym/tFK0xEEiTtZaNR7Aj/MBvwwburXtUSQt4N/kTJz5qMV4onXWjm0XRjY1J zqadGDf8qZbJBxi7VKe0/mPHEmn+KuErZAM2FElwz0z5qA18RTckSgEmqwkWbg2V5QV+ JSKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ue87oc3S; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <qemu-devel-bounces+patch=linaro.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t23si2075724ioj.71.2021.05.02.17.11.17 for <patch@linaro.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 May 2021 17:11:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ue87oc3S; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces+patch=linaro.org@nongnu.org>) id 1ldMBA-0006eR-U8 for patch@linaro.org; Sun, 02 May 2021 20:11:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>) id 1ldLy5-0007jG-PE for qemu-devel@nongnu.org; Sun, 02 May 2021 19:57:46 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:52764) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>) id 1ldLy1-0000cf-9k for qemu-devel@nongnu.org; Sun, 02 May 2021 19:57:45 -0400 Received: by mail-pj1-x1034.google.com with SMTP id ge1so2085112pjb.2 for <qemu-devel@nongnu.org>; Sun, 02 May 2021 16:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=/Lw6h+zhYOb/AKJ1XNWDOgLJcyj6yKfNAsAjmmI79uM=; b=Ue87oc3SPFwZtLnF0PmVZ1TwpfrzlmhW082YQvfB+Akd5pMkoZcIF7nuFAoHarnMWU 2tvfZOq5Xt1OS23m/d6XvtU6cUh9iBmSenKOJQN9M6SLV/K8EdT2vmgswZu+7Q8JcEuP +8xdJEoZi0Q9+HzRBXNbvX9HFlaXngsQRaYBF6cUvCS7y8BMZqlNrDCjb5yRstRU0NSc t5zXQUQdwsTPDHku/zPSkImkKYM6j0wcagVohkSNWwm6tnXhy/PE9yZUJ5idUuOkFe6x XY6zLoyfKEtHekofFtztwC8YY9dc3QDI396Sa5xhKZZXEWwbjgyTZJI+SMbNN/dGH7HT fyIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/Lw6h+zhYOb/AKJ1XNWDOgLJcyj6yKfNAsAjmmI79uM=; b=L1ESPB4mM7ii4+u4h3jmn5ha4Ae33I+997pPm8FI3Oc3IqGv2Sq9mcrrN5y+A9W1Ze 6xSXGLKrW4PD8Hw1rhYsWsls7XO+5lDymt6I14opDnaEcNOSXoFSk2BvAI319b8sl25n vTANQCQx3EGHpm4xyI9J3R1woYQOuVUC6xHI5uvxIH/2IgJI+p/fguneBqQ0ofe85rEB K+UUbZTUw2BYnBVfG+HvpTTCMjA6/HI5q3ixzuw0/+qFr90TfwCrLkkozBkoHPicvnpy h326E0D8eNQsn7pFNgh8OclnCRQykdnEIYXCo0GZcQwuLCc1JmA10I2y4ooR6YhIMJry BlPw== X-Gm-Message-State: AOAM532jFavFfin+GG/PpjgZb6khwF8bz775TNIMibdYkFQJLR/T8YxY TYWTl8J5CzT7PvGqQMrG3yoRwycdZN51Rw== X-Received: by 2002:a17:90b:3706:: with SMTP id mg6mr27327363pjb.90.1619999859982; Sun, 02 May 2021 16:57:39 -0700 (PDT) Received: from localhost.localdomain ([71.212.144.24]) by smtp.gmail.com with ESMTPSA id t184sm8098054pgt.32.2021.05.02.16.57.39 for <qemu-devel@nongnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 16:57:39 -0700 (PDT) From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH v6 14/26] tcg/tci: Remove tci_write_reg Date: Sun, 2 May 2021 16:57:15 -0700 Message-Id: <20210502235727.1979457-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210502235727.1979457-1-richard.henderson@linaro.org> References: <20210502235727.1979457-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org> |
Series |
TCI fixes and cleanups
|
expand
|
On 5/3/21 1:57 AM, Richard Henderson wrote: > Inline it into its one caller, tci_write_reg64. > Drop the asserts that are redundant with tcg_read_r. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > tcg/tci.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff --git a/tcg/tci.c b/tcg/tci.c index 5677c3544a..6900c3e891 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -36,20 +36,11 @@ __thread uintptr_t tci_tb_ptr; -static void -tci_write_reg(tcg_target_ulong *regs, TCGReg index, tcg_target_ulong value) -{ - tci_assert(index < TCG_TARGET_NB_REGS); - tci_assert(index != TCG_AREG0); - tci_assert(index != TCG_REG_CALL_STACK); - regs[index] = value; -} - static void tci_write_reg64(tcg_target_ulong *regs, uint32_t high_index, uint32_t low_index, uint64_t value) { - tci_write_reg(regs, low_index, value); - tci_write_reg(regs, high_index, value >> 32); + regs[low_index] = value; + regs[high_index] = value >> 32; } /* Create a 64 bit value from two 32 bit values. */
Inline it into its one caller, tci_write_reg64. Drop the asserts that are redundant with tcg_read_r. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- tcg/tci.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) -- 2.25.1