| Message ID | 20210428193408.233706-14-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | linux-user/s390x: some signal fixes | expand |
On 28.04.21 21:34, Richard Henderson wrote: > At point of usage, it's not immediately obvious that > we don't need a loop to copy these arrays. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > linux-user/s390x/signal.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c > index 81ba59b46a..839a7ae4b3 100644 > --- a/linux-user/s390x/signal.c > +++ b/linux-user/s390x/signal.c > @@ -141,6 +141,8 @@ void setup_frame(int sig, struct target_sigaction *ka, > return; > } > > + /* Make sure that we're initializing all of oldmask. */ > + QEMU_BUILD_BUG_ON(ARRAY_SIZE(frame->sc.oldmask) != 1); > __put_user(set->sig[0], &frame->sc.oldmask[0]); > > save_sigregs(env, &frame->sregs); > @@ -266,6 +268,9 @@ long do_sigreturn(CPUS390XState *env) > force_sig(TARGET_SIGSEGV); > return -TARGET_QEMU_ESIGRETURN; > } > + > + /* Make sure that we're initializing all of target_set. */ > + QEMU_BUILD_BUG_ON(ARRAY_SIZE(target_set.sig) != 1); > __get_user(target_set.sig[0], &frame->sc.oldmask[0]); > > target_to_host_sigset_internal(&set, &target_set); > Reviewed-by: David Hildenbrand <david@redhat.com> -- Thanks, David / dhildenb
diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 81ba59b46a..839a7ae4b3 100644 --- a/linux-user/s390x/signal.c +++ b/linux-user/s390x/signal.c @@ -141,6 +141,8 @@ void setup_frame(int sig, struct target_sigaction *ka, return; } + /* Make sure that we're initializing all of oldmask. */ + QEMU_BUILD_BUG_ON(ARRAY_SIZE(frame->sc.oldmask) != 1); __put_user(set->sig[0], &frame->sc.oldmask[0]); save_sigregs(env, &frame->sregs); @@ -266,6 +268,9 @@ long do_sigreturn(CPUS390XState *env) force_sig(TARGET_SIGSEGV); return -TARGET_QEMU_ESIGRETURN; } + + /* Make sure that we're initializing all of target_set. */ + QEMU_BUILD_BUG_ON(ARRAY_SIZE(target_set.sig) != 1); __get_user(target_set.sig[0], &frame->sc.oldmask[0]); target_to_host_sigset_internal(&set, &target_set);
At point of usage, it's not immediately obvious that we don't need a loop to copy these arrays. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- linux-user/s390x/signal.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.25.1