diff mbox series

[v2,4/7] linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall

Message ID 20210422230227.314751-5-richard.henderson@linaro.org
State Superseded
Headers show
Series linux-user: sigaction fixes/cleanups | expand

Commit Message

Richard Henderson April 22, 2021, 11:02 p.m. UTC 
Do not access a field that may not be present.  This will
become an issue when sharing more code in the next patch.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 linux-user/syscall.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.25.1

Comments

Philippe Mathieu-Daudé April 23, 2021, 10:21 a.m. UTC | #1 
On 4/23/21 1:02 AM, Richard Henderson wrote:
> Do not access a field that may not be present.  This will

> become an issue when sharing more code in the next patch.

> 

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  linux-user/syscall.c | 4 ++++

>  1 file changed, 4 insertions(+)


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Alex Bennée April 23, 2021, 1:14 p.m. UTC | #2 
Richard Henderson <richard.henderson@linaro.org> writes:

> Do not access a field that may not be present.  This will

> become an issue when sharing more code in the next patch.

>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


-- 
Alex Bennée
diff mbox series

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 36169a0ded..89d641856c 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -9038,7 +9038,9 @@  static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
                 act._sa_handler = old_act->_sa_handler;
                 target_siginitset(&act.sa_mask, old_act->sa_mask);
                 act.sa_flags = old_act->sa_flags;
+#ifdef TARGET_ARCH_HAS_SA_RESTORER
                 act.sa_restorer = old_act->sa_restorer;
+#endif
                 unlock_user_struct(old_act, arg2, 0);
                 pact = &act;
             } else {
@@ -9051,7 +9053,9 @@  static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
                 old_act->_sa_handler = oact._sa_handler;
                 old_act->sa_mask = oact.sa_mask.sig[0];
                 old_act->sa_flags = oact.sa_flags;
+#ifdef TARGET_ARCH_HAS_SA_RESTORER
                 old_act->sa_restorer = oact.sa_restorer;
+#endif
                 unlock_user_struct(old_act, arg3, 1);
             }
 #endif