From patchwork Fri Apr 16 23:59:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 422846 Delivered-To: patch@linaro.org Received: by 2002:a02:6a6f:0:0:0:0:0 with SMTP id m47csp813381jaf; Fri, 16 Apr 2021 17:01:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTTa5oVSo+nmddvcI3ygwXSNzj1UTahkUQmsOAX7HYKmNAYmq7si/iH7yPfa+tY6QCMjvn X-Received: by 2002:a05:6102:1256:: with SMTP id p22mr9081291vsg.56.1618617705675; Fri, 16 Apr 2021 17:01:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618617705; cv=none; d=google.com; s=arc-20160816; b=itd9cmn6sMweT+phbmuDCMhDzG2fD3Uisv9L/oumAOKUakW0TKNtCOI9P5Pz+QX9KO bKo18cu8SKuVevCNKBgkSFaknKXPvJfojz2SBrJJoYpbyCmVopv0n+BOFgoHyqfroiA8 cVjIXPD3PIpQ/zZWYYGm4yjJ0acHuwq2KiYJE/zKCABiRGG06swPdVsNod4azMtNjt6Q YMWxXSVYi5sWPzkuiTgwNcDRfBuda5/qBnUpc34aR25RBinG0xhqTeTSRrWQcRU0MCwi sRNlAAdGh0Z8kRPm8J4pjp/1M2AXesnYfhE8qLXgWC3CWo7xOxXT8fasigg9ubu+eCxs u8pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=/N6ThJ9lpoodnukC32bBD9hHhS8zuwX7N8aEvzIih5o=; b=bnq2+HHMzp6+1yDoEfoR8MUieAGWdWV7jfEtjbUMZiDkoSW7ogNNntVfC9XYK043XJ uKSH8hSs/LJfJgV6uFQjoQ6Sp+uatxiC3iMpq+PUzH4TBRzZXAiHHhe4vHE8Y/O3iCrL JzO0oskKznd0kAamHnLf4BF8bJjEOKLushyYNhpDcnHR8MfC/uVHqkgzV0hWzr6jgwGd rUf3gEmvYEKPJ4mnkEy7fRFRiQTmcJaeQrieSzZsm+AlhyMD5n8TYX0emodZGHH+pjMP 51JTZ4BEZ7Dz++7N3EwOTucXFhTN9l+cz9+8unKnRednDI398Wxcijpp7eIxx9H9PIVE L1Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DIlY8w0T; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s23si3472257uae.196.2021.04.16.17.01.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Apr 2021 17:01:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DIlY8w0T; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXYPB-0007Tq-0i for patch@linaro.org; Fri, 16 Apr 2021 20:01:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXYN7-0005CD-5p for qemu-devel@nongnu.org; Fri, 16 Apr 2021 19:59:37 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:56007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXYN3-0005b1-Ur for qemu-devel@nongnu.org; Fri, 16 Apr 2021 19:59:36 -0400 Received: by mail-pj1-x1031.google.com with SMTP id s14so9995707pjl.5 for ; Fri, 16 Apr 2021 16:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/N6ThJ9lpoodnukC32bBD9hHhS8zuwX7N8aEvzIih5o=; b=DIlY8w0TzDz7sSwpPz0Z10wMUhe4PIfaFC/qPi5eceXtGXYRhLvFYPkJyzTKSFRnct /2rQIZ6S6qev8XKbRX7kcxHPoKzWzoGZTgwHiTLVGmhuCsv/MZKkVy1JCphrFVqz/9Wv oJo48UN0PqhblcO6rVIZlF7FtgCM6D1/KgBH6nQWjTBybefUU0uFQc2KnqbH7SNpvAQA 6d0bl4EgD5dSEBFwnFiKT2ClFlbHwmv8kaVJwZpGh5bJvc3E0mXH0cyYo9NNG1rjXLtE 5TKiyuxq1qqBYD9YZGi7i4moaIPJaZ1u79VIhj+62H6aOHnmq5pzOdWrSBeHpth6tyYy sePw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/N6ThJ9lpoodnukC32bBD9hHhS8zuwX7N8aEvzIih5o=; b=K3WhxCH5EIpG2J/z1FI4izI9l8usJMsaGSGA6sIxiVR0Kf2l1pWoxctdvPzdRodpmQ u3JacVyraL9Y/a9dIW1IA1DSVZbiEa/zyNnngjXNmakQ7+2u+a912lAtwamx1U1JloNz UTxLVHXMYa36qYQF/aagwxU7XmgsGHbLsqsWfm6BNlB4sMBYdHhFhWxjnxpdkZjbzmzI nIulIj3V7nsm48uHm2OCIuBv69IE281AqmlIo/5R+K2f78JPjeZbTVsl9RdW/9a/cak/ NosrJp4mKJuc3KXXFzp7Cux+D8u6ecJkv2cEalzndhBBnbJDItvjullH53ft0L+Q7XfP e7QQ== X-Gm-Message-State: AOAM533ONn8BKqMgCIkgjlv4MxsK+nOpF3x6r1LCMbSAlbz1MjjudZLB 1NRzAq+XlWTzaa2OXOQWpHPO5Ubsbnejrw== X-Received: by 2002:a17:90a:4f41:: with SMTP id w1mr10603836pjl.231.1618617572489; Fri, 16 Apr 2021 16:59:32 -0700 (PDT) Received: from localhost.localdomain ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id d71sm560853pfd.83.2021.04.16.16.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 16:59:32 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v1 02/11] target/arm: Unify unallocated path in disas_fp_1src Date: Fri, 16 Apr 2021 16:59:19 -0700 Message-Id: <20210416235928.1631788-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210416235928.1631788-1-richard.henderson@linaro.org> References: <20210416235928.1631788-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) -- 2.25.1 Reviewed-by: Peter Maydell diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 668edf3a00..d8ec219bb2 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -6509,8 +6509,7 @@ static void disas_fp_1src(DisasContext *s, uint32_t insn) int rd = extract32(insn, 0, 5); if (mos) { - unallocated_encoding(s); - return; + goto do_unallocated; } switch (opcode) { @@ -6519,8 +6518,7 @@ static void disas_fp_1src(DisasContext *s, uint32_t insn) /* FCVT between half, single and double precision */ int dtype = extract32(opcode, 0, 2); if (type == 2 || dtype == type) { - unallocated_encoding(s); - return; + goto do_unallocated; } if (!fp_access_check(s)) { return; @@ -6532,8 +6530,7 @@ static void disas_fp_1src(DisasContext *s, uint32_t insn) case 0x10 ... 0x13: /* FRINT{32,64}{X,Z} */ if (type > 1 || !dc_isar_feature(aa64_frint, s)) { - unallocated_encoding(s); - return; + goto do_unallocated; } /* fall through */ case 0x0 ... 0x3: @@ -6555,8 +6552,7 @@ static void disas_fp_1src(DisasContext *s, uint32_t insn) break; case 3: if (!dc_isar_feature(aa64_fp16, s)) { - unallocated_encoding(s); - return; + goto do_unallocated; } if (!fp_access_check(s)) { @@ -6565,11 +6561,12 @@ static void disas_fp_1src(DisasContext *s, uint32_t insn) handle_fp_1src_half(s, opcode, rd, rn); break; default: - unallocated_encoding(s); + goto do_unallocated; } break; default: + do_unallocated: unallocated_encoding(s); break; }