From patchwork Sat Mar 6 21:36:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 394564 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp551689jai; Sat, 6 Mar 2021 13:43:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrPqCpnGQrnMU0CCN7f7UCSvjkNxKArtrbPsZlVxm1PrmFjBHVmCdxrpsnP8ITmWoTMj38 X-Received: by 2002:a5d:9510:: with SMTP id d16mr13005973iom.81.1615067013757; Sat, 06 Mar 2021 13:43:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615067013; cv=none; d=google.com; s=arc-20160816; b=qqrdNQyr29fjDx+20pRLwbsaxOROG1+t61oU02SILwu6vSqq4apBUxxdXHg+0KpUkh ibxcjEY7dppC8NE44bl4TRD+HiwJstW+D70gne/MmgXiuEYvFsH1GSTHiHUuBoXD9j6T 013Z8DFN3Az18Omiq11+nq+X3miOYDKuJK5nYOAYW1LJZ5O0ijjnkYuTTuiPIDQSOz04 +1hAQhpeJ74iogk9FE9/2FkukfB1kMib8NjPynZ2dO4FVZzbLuumwQIBIG7pKYTc0Pid ZNLdwm2/LXpgGOg8OQ3IeDIllarRfCtuDcgxdZtVL0tPVmhJTC5yt4jPzBMxwMYKBWHc +Nuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=CWFm3ag7LIImv7AYnXLhQJhOkm+Ptc6YBLG0M9ot5EY=; b=msmx6b/vXl3xIjrFIhuNmMqzZBPe2ZFv1S/t+K2BGSOtFpUVBWABcOg61GWvQ+9dR5 FQhQjgiG1vqFGJu+N+VvZuITnjmGtALDXicadsZ52TnUnNKZDLrXyynZgqCZS8HkerPA 1jJDYgxXnUdFA53olhxDukVbaigtb35aPmiR+KQquhT4jXRIQrn71w6XG7Ll4JzI9fqN T5KziP7cgrXHBwv48hC1kbwdGg63j0ooX6QtvumE7Z3B/JgOFeybGDVHpf9Z8/Ck0QzT bG3MtVTyaKcYLcbqHCfu6iw/ys9b4JTjEozAseA7yW1Ri7EGXftxfpB+IirOmowHsTXh r+jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wxMK1rsQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s4si6800395ilv.10.2021.03.06.13.43.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Mar 2021 13:43:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wxMK1rsQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIehx-0000WM-6M for patch@linaro.org; Sat, 06 Mar 2021 16:43:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIebD-0006zg-ID for qemu-devel@nongnu.org; Sat, 06 Mar 2021 16:36:35 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:37667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIebB-0002yd-V1 for qemu-devel@nongnu.org; Sat, 06 Mar 2021 16:36:35 -0500 Received: by mail-pl1-x631.google.com with SMTP id p5so3112380plo.4 for ; Sat, 06 Mar 2021 13:36:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CWFm3ag7LIImv7AYnXLhQJhOkm+Ptc6YBLG0M9ot5EY=; b=wxMK1rsQwgQ2ujJT/ccnz5qdKxjNaZzpXJn5w528Vf9unN96BUll7GfvPiFK0WL56R 7TWQf/3I6C+lEHRnxOwLW1gTzinR6eHyywuxvJ/BF52pF/vg1+qxbqCthxIqY/Z7XHil WvqvHQCH2alEO4ZIArKZFgaOEufuI5Ng1SGXG5+Tt0j3dwQQ/3QaepC50As99iIJ/KdT tXJ6WqHz8cTU8OlnK7ahqnWCXuTJRbiRIG8prukuaeEPHmFdpHGVHjrzG79jup/tp84g cuiIg2Uu59ny9IY9x1xkboDg53i7DOvf04uOghAvfdEauY8SKl4+JzPB4OTNLNRHRDr0 pGDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CWFm3ag7LIImv7AYnXLhQJhOkm+Ptc6YBLG0M9ot5EY=; b=p40e684fbvj4a8kcgjXhk0SjY0Seebc6ALZbvofTssSrCWx9GKtvtze2PMcUqAkvHz 5av9kPUQUw3WBQnHKc33i+ICl8/2A+FP5fvFlhB6m45nh7vnmqppNXH04UV17CSs3Zt+ 7q1UNHVrbKXGU+FvR456Cx6JwGRDS/T5PCQ946kLlAs3U3kGuijx7/v3orYIbCD1C/UR uY+3H8i9wzpso0I+MsxIiau9+ai/l7Hy4sEwEHZMbAwBHNbK+6aL1fwD3dD8HXQLkY2X cDIXLJAk7Zx8newJ0ovXC8gNdMlkApmU8OpC7DaMYi528Yb0QjOgmteqIsooxqD8B2LN 6S4Q== X-Gm-Message-State: AOAM533qSP1lc3vCkjx6NI/b1ALTNEGPU1bp0OEJUgSeniwc5LE9OfHm bQ0id5Lx9r9xVEE03406xvU+/iRZqesNXQ== X-Received: by 2002:a17:90a:be0e:: with SMTP id a14mr185207pjs.131.1615066592624; Sat, 06 Mar 2021 13:36:32 -0800 (PST) Received: from localhost.localdomain ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id r30sm6365616pgu.86.2021.03.06.13.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 13:36:32 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 17/27] tcg/tci: Remove tci_read_r32s Date: Sat, 6 Mar 2021 13:36:03 -0800 Message-Id: <20210306213613.85168-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210306213613.85168-1-richard.henderson@linaro.org> References: <20210306213613.85168-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Use explicit casts for ext32s opcodes. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tci.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) -- 2.25.1 diff --git a/tcg/tci.c b/tcg/tci.c index a5aaa763f8..cef12f263d 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -57,13 +57,6 @@ static tcg_target_ulong tci_read_reg(const tcg_target_ulong *regs, TCGReg index) return regs[index]; } -#if TCG_TARGET_REG_BITS == 64 -static int32_t tci_read_reg32s(const tcg_target_ulong *regs, TCGReg index) -{ - return (int32_t)tci_read_reg(regs, index); -} -#endif - #if TCG_TARGET_REG_BITS == 64 static uint64_t tci_read_reg64(const tcg_target_ulong *regs, TCGReg index) { @@ -149,15 +142,6 @@ static uint64_t tci_read_r64(const tcg_target_ulong *regs, return tci_uint64(tci_read_r(regs, tb_ptr), low); } #elif TCG_TARGET_REG_BITS == 64 -/* Read indexed register (32 bit signed) from bytecode. */ -static int32_t tci_read_r32s(const tcg_target_ulong *regs, - const uint8_t **tb_ptr) -{ - int32_t value = tci_read_reg32s(regs, **tb_ptr); - *tb_ptr += 1; - return value; -} - /* Read indexed register (64 bit) from bytecode. */ static uint64_t tci_read_r64(const tcg_target_ulong *regs, const uint8_t **tb_ptr) @@ -870,8 +854,8 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, #endif case INDEX_op_ext_i32_i64: t0 = *tb_ptr++; - t1 = tci_read_r32s(regs, &tb_ptr); - tci_write_reg(regs, t0, t1); + t1 = tci_read_r(regs, &tb_ptr); + tci_write_reg(regs, t0, (int32_t)t1); break; #if TCG_TARGET_HAS_ext32u_i64 case INDEX_op_ext32u_i64: