From patchwork Fri Mar 5 17:14:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 393557 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp644847jai; Fri, 5 Mar 2021 10:05:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyTW7I+m5tRb+pAIuPi2P+Q8x3TLnQqTs6+fxhAjh+NyICFCYZFaqwVugQQPll0eEwH9a8x X-Received: by 2002:aca:4886:: with SMTP id v128mr8126601oia.168.1614967509092; Fri, 05 Mar 2021 10:05:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614967509; cv=none; d=google.com; s=arc-20160816; b=cVMkbLTBl+B177kTrJjm06DUL813oLy7/urcXRn7kXnsTLkZcwE3V4Gtm5y/1ucWbB JwkVvohN1whpPK2FR9hZ94+PEuhuqeNot8P9KUw+mHR2XTuTQaYVc75giKf2wFwGVjbQ 6XdKWjn0UQCjMFHqT0nQQqc3u0uOZ2Tdg/bZnAes5/V/txgp0rpi6QWp493JcruqTXYW 2+cbucK/XQsZzWgpWVADEyXRpegUTp7stVO6Qb5Lni8KRpNJvPLxOzUEAdeOQsYspJHt TcUIDkBc9j++Ukzi7x9S4ZXMIep5xbg9RyoEGn1BRCO+2UwTkbF7fzn8X/84kD53LIn+ bizg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=COi/9CAUq6+7DdssMpbU7FxBJPwnXWMtPeffciNh4Dk=; b=DJlgeIn7itK/QZJkgHRzVJjFJPfVK3J9vCgkZXSHfOWwJsVWBENw00FKrI058OEneJ FFnehpR/Lm50D9whYNz9q22M4XYATyuSPxxgSl/gvt37Hw/cetX7HYc3kFGBo/Q45sGW fwvRT5CFJzLI62PiYRWqXgdmc1Hfm+UsFZZlM7pz7aJrlBS0NxrrDFlYMJJ9lMmaS8uL gu0vPBjQr0uC23SznZOlXz+I8GzwaPdJcCZf7/pJNV+Bo5dkq+VrP9vG78//rcDymtB4 CqnC8Xs4dAEtWgf+13zDvB2c072At7yaTzj9D0N3b73mbDLNvi9QYXsk+f51OGWd7O6S Qo3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QRa1t9ef; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k204si2975510oif.276.2021.03.05.10.05.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Mar 2021 10:05:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QRa1t9ef; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIEp2-0008IK-EK for patch@linaro.org; Fri, 05 Mar 2021 13:05:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIE34-0006fb-1Q for qemu-devel@nongnu.org; Fri, 05 Mar 2021 12:15:34 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:52356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIE2y-0007UW-Q5 for qemu-devel@nongnu.org; Fri, 05 Mar 2021 12:15:33 -0500 Received: by mail-wm1-x330.google.com with SMTP id n22so2103954wmc.2 for ; Fri, 05 Mar 2021 09:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=COi/9CAUq6+7DdssMpbU7FxBJPwnXWMtPeffciNh4Dk=; b=QRa1t9eflhb6pVjjyk91nTMiCv2oEGtznJk+qcAX/oYBeiMp67tSo+nde86VLgtAf/ YjznsoJKNVBr2nPuB0KOxiOWN6XN8cqCZ5gx7+Bt6ofLUiQIKKRK9TF50sVxv47fnNqf shxQMW2TGLFCMC7L9ENyl9r8Mn1Dvu6P8YnZjKb3DAbZCKypMR6Qrj+ni33piu9tRL/Z 4YnxM5jonHCaUfDhqRWnpiIi6/ZD+yCU8mCF0brOKLxkAnIDvLzsdmcN/a2IhCQiK4gQ fwcvY6GOohVQEsbePEEfuldTQ2knBiLYPxuiUFcvvyZn+wTW0fH2gLnIEP/CF8omHGQD 1EPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=COi/9CAUq6+7DdssMpbU7FxBJPwnXWMtPeffciNh4Dk=; b=SuD5FwPeo1Kb+xnqQDH7eRNIS9SUPi7RHEievgRpzhrkUD3unZxHg4iR2+M057w01M RV9M1ZhqHpTh1ni0LPpY5SyAvIs7pyf9i2dW6d52yv2xfQJlKHi+TVe/6sf89zkIpeNu 1vDxPS9+mGuQBzPVWMQHc75jjKLhtQC8O/hbmY2sl12z7DfQE8MSZjeM8XHjFyxwWmjx wLKco7I1INvKx1Gv+/5Rb4RLWF73SViZ9fXAmPlCOl3AturvfsP2vRbKYB0UVVJUGMmW ZjgFwPttuyljGuOJ9DyiYxxmyg0PAni6RZk0bN+75acnToFFlehwaGOjBbda0Py+bpfb eAkw== X-Gm-Message-State: AOAM530tpIfCPNa/zRmjPAe1kr5UEoTbUBz29pvy7wUUT+OuJHyjPCnS bGz7wbc2iI9oV1pgdNCokNUVzWrJyfb1PQ== X-Received: by 2002:a1c:17:: with SMTP id 23mr9984021wma.6.1614964526170; Fri, 05 Mar 2021 09:15:26 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id m132sm5942357wmf.45.2021.03.05.09.15.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:15:25 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 11/49] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init() Date: Fri, 5 Mar 2021 17:14:37 +0000 Message-Id: <20210305171515.1038-12-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210305171515.1038-1-peter.maydell@linaro.org> References: <20210305171515.1038-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé The STATUS register will be reset to IDLE in cnpcm7xx_smbus_enter_reset(), no need to preset it in instance_init(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Hao Wu Message-id: 20210228224813.312532-1-f4bug@amsat.org Signed-off-by: Peter Maydell --- hw/i2c/npcm7xx_smbus.c | 1 - 1 file changed, 1 deletion(-) -- 2.20.1 diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c index 6b2f9e1aaad..e7e0ba66fe7 100644 --- a/hw/i2c/npcm7xx_smbus.c +++ b/hw/i2c/npcm7xx_smbus.c @@ -1040,7 +1040,6 @@ static void npcm7xx_smbus_init(Object *obj) sysbus_init_mmio(sbd, &s->iomem); s->bus = i2c_init_bus(DEVICE(s), "i2c-bus"); - s->status = NPCM7XX_SMBUS_STATUS_IDLE; } static const VMStateDescription vmstate_npcm7xx_smbus = {